-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compose credit element #4358
Merged
Merged
Compose credit element #4358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rm field values of it's elements. This simplifies the form quite a bit!
…that we don't have to iterate through section element fields to get the form field values.
… not displaying right.
…ipe-android into michelleb/credit-card-compose
* Don't show cardbrand if there are multiple possible * Account for accountRangeService
…ipe-android into michelleb/credit-card-compose
skyler-stripe
previously approved these changes
Mar 30, 2022
skyler-stripe
previously approved these changes
Mar 31, 2022
skyler-stripe
approved these changes
Mar 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is the compose credit element added into PaymentSheet.
Just FYI, RUN-MOBILESDK 738 is dependent on this - Save for future use checkbox updates
In future reviews:
Testing
Screenshots