Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compose credit element #4358

Merged
merged 127 commits into from
Mar 31, 2022
Merged

Compose credit element #4358

merged 127 commits into from
Mar 31, 2022

Conversation

michelleb-stripe
Copy link
Contributor

@michelleb-stripe michelleb-stripe commented Nov 5, 2021

Summary

This is the compose credit element added into PaymentSheet.

Just FYI, RUN-MOBILESDK 738 is dependent on this - Save for future use checkbox updates

In future reviews:

  • trailing icon - future review - michelleb
  • accessibility reading of expiration date 2/12 is read as "two hundred twelve"
  • card metadata service (required before merging to master) -- should remove the ability to add more than the allowed numbers to the credit card element
  • Save for future use checkbox text doesn't show up.
  • Passing unit tests - michelleb
  • On master the card brand doesn't populate until the last zero of 6205 50 is entered. Not sure what exactly is causing that different behavior
  • The CVV icon in michelleb/credit-card-compose is not showing up, but the placeholder text does change.
  • Next field from the card number appears to be the CVV instead of the date
  • Only the card number shows a red line under the text when it loses focus, in dark mode, but all fields have the line under in light mode. It should be that the CVC and expiration text have a red line when the field is in error.
  • If only a CVC is entered the error message shows that the card number is invalid. It should be blank, but not an error.
  • Final testing

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before After
before screenshot after screenshot

…rm field values of it's elements. This simplifies the form quite a bit!
…that we don't have to iterate through section element fields to get the form field values.
skyler-stripe
skyler-stripe previously approved these changes Mar 30, 2022
skyler-stripe
skyler-stripe previously approved these changes Mar 31, 2022
@michelleb-stripe michelleb-stripe merged commit 397b486 into master Mar 31, 2022
@michelleb-stripe michelleb-stripe deleted the michelleb/credit-card-compose branch March 31, 2022 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants