Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[shared network stack] Replace FraudDetectionDataRequestExecutor with StripeNetworkClient #4360

Merged
merged 1 commit into from
Nov 8, 2021

Conversation

ccen-stripe
Copy link
Contributor

Summary

  • Delete FraudDetectionDataRequestExecutor and replace it with StripeNetworkClient
  • Update corresponding tests

Follow up

  1. Replace AnalyticsRequestExecutor with StripeNetworkClient (See this section for details) - complete milestone 1

  2. Create stripe-core module, move StripeNetworkClient, StripeRequest, AnalyticsRequest and StripeResponse into it - complete milestone 2

  3. Let cardverification depend on stripe-core and use the network stack (see this section for details) - complete milestone 3

Motivation

Please see details in this internal doc

Testing

  • Added tests
  • Modified tests
  • Manually verified

@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2021

Diffuse output:

@ccen-stripe ccen-stripe merged commit fbd6965 into master Nov 8, 2021
@ccen-stripe ccen-stripe deleted the network3 branch November 8, 2021 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants