Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Eps, Giropay, p24, klarna and paypal in payment sheet #4489

Merged
merged 1 commit into from
Jan 4, 2022

Conversation

skyler-stripe
Copy link
Contributor

Summary

Enables Klarna, Paypal, EPS, Giropay, P24, and Afterpay for PaymentSheet

Motivation

Match with iOS: https://github.com/stripe-ios/stripe-ios/pull/565

https://paper.dropbox.com/doc/PaymentSheet-December-release--BXXdYEs7PwD4GBjX9n5pvycjAg-0lBp7fRvXHaLBjSmPyZxE

Testing

  • Added tests
  • Modified tests
  • Manually verified

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2022

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: none)
NEW: paymentsheet-example-release-pr.apk (signature: none)

          │          compressed           │         uncompressed          
          ├───────────┬───────────┬───────┼───────────┬───────────┬───────
 APK      │ old       │ new       │ diff  │ old       │ new       │ diff  
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼───────
      dex │  11.8 MiB │  11.8 MiB │ +10 B │  40.1 MiB │  40.1 MiB │ +80 B 
     arsc │   1.4 MiB │   1.4 MiB │   0 B │   1.4 MiB │   1.4 MiB │   0 B 
 manifest │   2.6 KiB │   2.6 KiB │   0 B │  10.8 KiB │  10.8 KiB │   0 B 
      res │ 653.2 KiB │ 653.2 KiB │   0 B │     1 MiB │     1 MiB │   0 B 
    asset │  77.7 KiB │  77.7 KiB │   0 B │ 109.2 KiB │ 109.2 KiB │   0 B 
    other │  78.3 KiB │  78.3 KiB │  -4 B │   154 KiB │   154 KiB │   0 B 
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼───────
    total │    14 MiB │    14 MiB │  +6 B │  42.8 MiB │  42.8 MiB │ +80 B 


         │          raw           │           unique            
         ├────────┬────────┬──────┼────────┬────────┬───────────
 DEX     │ old    │ new    │ diff │ old    │ new    │ diff      
─────────┼────────┼────────┼──────┼────────┼────────┼───────────
   files │      3 │      3 │    0 │        │        │           
 strings │ 183508 │ 183508 │    0 │ 168739 │ 168739 │ 0 (+2 -2) 
   types │  32799 │  32799 │    0 │  30799 │  30799 │ 0 (+0 -0) 
 classes │  28421 │  28421 │    0 │  28421 │  28421 │ 0 (+0 -0) 
 methods │ 164802 │ 164802 │    0 │ 159923 │ 159923 │ 0 (+0 -0) 
  fields │ 115672 │ 115672 │    0 │ 115052 │ 115052 │ 0 (+0 -0) 


 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  295 │  295 │  0   
 entries │ 4370 │ 4370 │  0
APK
   compressed    │  uncompressed   │                                                       
─────────┬───────┼─────────┬───────┤                                                       
 size    │ diff  │ size    │ diff  │ path                                                  
─────────┼───────┼─────────┼───────┼───────────────────────────────────────────────────────
 2.7 MiB │ +10 B │ 7.7 MiB │ +80 B │ ∆ classes2.dex                                        
   184 B │  -4 B │     6 B │   0 B │ ∆ META-INF/androidx.activity_activity-compose.version 
─────────┼───────┼─────────┼───────┼───────────────────────────────────────────────────────
 2.7 MiB │  +6 B │ 7.7 MiB │ +80 B │ (total)
DEX
STRINGS:

   old    │ new    │ diff      
  ────────┼────────┼───────────
   168739 │ 168739 │ 0 (+2 -2) 
  
  + SMAP
  SupportedPaymentMethod.kt
  Kotlin
  *S Kotlin
  *F
  + 1 SupportedPaymentMethod.kt
  com/stripe/android/paymentsheet/model/SupportedPaymentMethod
  + 2 _Collections.kt
  kotlin/collections/CollectionsKt___CollectionsKt
  *L
  1#1,395:1
  1547#2:396
  1618#2,3:397
  817#2:400
  845#2,2:401
  *S KotlinDebug
  *F
  + 1 SupportedPaymentMethod.kt
  com/stripe/android/paymentsheet/model/SupportedPaymentMethod
  *L
  303#1:396
  303#1:397,3
  337#1:400
  337#1:401,2
  *E
  
  + SMAP
  SupportedPaymentMethod.kt
  Kotlin
  *S Kotlin
  *F
  + 1 SupportedPaymentMethod.kt
  com/stripe/android/paymentsheet/model/SupportedPaymentMethod_Companion
  + 2 _Collections.kt
  kotlin/collections/CollectionsKt___CollectionsKt
  + 3 fake.kt
  kotlin/jvm/internal/FakeKt
  *L
  1#1,395:1
  286#2,2:396
  1601#2,9:398
  1849#2:407
  1850#2:409
  1610#2:410
  764#2:411
  855#2,2:412
  1601#2,9:414
  1849#2:423
  1850#2:425
  1610#2:426
  764#2:427
  855#2,2:428
  817#2:430
  845#2,2:431
  1#3:408
  1#3:424
  *S KotlinDebug
  *F
  + 1 SupportedPaymentMethod.kt
  com/stripe/android/paymentsheet/model/SupportedPaymentMethod_Companion
  *L
  359#1:396,2
  368#1:398,9
  368#1:407
  368#1:409
  368#1:410
  370#1:411
  370#1:412,2
  382#1:414,9
  382#1:423
  382#1:425
  382#1:426
  384#1:427
  384#1:428,2
  389#1:430
  389#1:431,2
  368#1:408
  382#1:424
  *E
  
  
  - SMAP
  SupportedPaymentMethod.kt
  Kotlin
  *S Kotlin
  *F
  + 1 SupportedPaymentMethod.kt
  com/stripe/android/paymentsheet/model/SupportedPaymentMethod
  + 2 _Collections.kt
  kotlin/collections/CollectionsKt___CollectionsKt
  *L
  1#1,393:1
  1547#2:394
  1618#2,3:395
  817#2:398
  845#2,2:399
  *S KotlinDebug
  *F
  + 1 SupportedPaymentMethod.kt
  com/stripe/android/paymentsheet/model/SupportedPaymentMethod
  *L
  303#1:394
  303#1:395,3
  337#1:398
  337#1:399,2
  *E
  
  - SMAP
  SupportedPaymentMethod.kt
  Kotlin
  *S Kotlin
  *F
  + 1 SupportedPaymentMethod.kt
  com/stripe/android/paymentsheet/model/SupportedPaymentMethod_Companion
  + 2 _Collections.kt
  kotlin/collections/CollectionsKt___CollectionsKt
  + 3 fake.kt
  kotlin/jvm/internal/FakeKt
  *L
  1#1,393:1
  286#2,2:394
  1601#2,9:396
  1849#2:405
  1850#2:407
  1610#2:408
  764#2:409
  855#2,2:410
  1601#2,9:412
  1849#2:421
  1850#2:423
  1610#2:424
  764#2:425
  855#2,2:426
  817#2:428
  845#2,2:429
  1#3:406
  1#3:422
  *S KotlinDebug
  *F
  + 1 SupportedPaymentMethod.kt
  com/stripe/android/paymentsheet/model/SupportedPaymentMethod_Companion
  *L
  357#1:394,2
  366#1:396,9
  366#1:405
  366#1:407
  366#1:408
  368#1:409
  368#1:410,2
  380#1:412,9
  380#1:421
  380#1:423
  380#1:424
  382#1:425
  382#1:426,2
  387#1:428
  387#1:429,2
  366#1:406
  380#1:422
  *E

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants