Remove force portrait in PaymentLauncher

[jameswoo-stripe]

Summary

Removed force portrait mode for tablets.

Motivation

Make sure that PaymentLauncher works in landscape mode on tablets.

Testing

• Added tests
• Modified tests
• Manually verified

Screenshots

3ds1 testing

paymentlauncher.mov

3ds2 testing

3ds2.mov

Changelog

• [CHANGED] Removed force portrait mode for tablets

[github-actions]

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: none)
NEW: paymentsheet-example-release-pr.apk (signature: none)

          │           compressed           │          uncompressed          
          ├───────────┬───────────┬────────┼───────────┬───────────┬────────
 APK      │ old       │ new       │ diff   │ old       │ new       │ diff   
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼────────
      dex │  13.2 MiB │  13.2 MiB │ +148 B │  44.1 MiB │  44.1 MiB │  -32 B 
     arsc │   1.6 MiB │   1.6 MiB │    0 B │   1.6 MiB │   1.6 MiB │    0 B 
 manifest │   2.9 KiB │   2.9 KiB │    0 B │  12.3 KiB │  12.3 KiB │    0 B 
      res │ 676.2 KiB │ 676.2 KiB │    0 B │   1.1 MiB │   1.1 MiB │    0 B 
    asset │  78.9 KiB │  79.4 KiB │ +530 B │ 108.4 KiB │ 108.9 KiB │ +530 B 
    other │  80.3 KiB │  80.3 KiB │   +4 B │ 154.9 KiB │ 154.9 KiB │    0 B 
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼────────
    total │  15.6 MiB │  15.6 MiB │ +682 B │  47.1 MiB │  47.1 MiB │ +498 B 

         │          raw           │            unique            
         ├────────┬────────┬──────┼────────┬────────┬────────────
 DEX     │ old    │ new    │ diff │ old    │ new    │ diff       
─────────┼────────┼────────┼──────┼────────┼────────┼────────────
   files │      3 │      3 │    0 │        │        │            
 strings │ 213143 │ 213143 │    0 │ 187973 │ 187973 │  0 (+1 -1) 
   types │  36819 │  36819 │    0 │  34229 │  34229 │  0 (+0 -0) 
 classes │  31655 │  31655 │    0 │  31655 │  31655 │  0 (+0 -0) 
 methods │ 189777 │ 189776 │   -1 │ 183855 │ 183854 │ -1 (+0 -1) 
  fields │ 130646 │ 130646 │    0 │ 129806 │ 129806 │  0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  292 │  292 │  0   
 entries │ 5596 │ 5596 │  0

APK

    compressed    │   uncompressed    │                                                       
─────────┬────────┼──────────┬────────┤                                                       
 size    │ diff   │ size     │ diff   │ path                                                  
─────────┼────────┼──────────┼────────┼───────────────────────────────────────────────────────
 7.5 KiB │ +530 B │  7.4 KiB │ +530 B │ ∆ assets/dexopt/baseline.prof                         
 3.5 MiB │ +148 B │ 10.2 MiB │  -32 B │ ∆ classes3.dex                                        
   196 B │   +4 B │     14 B │    0 B │ ∆ META-INF/androidx.activity_activity-compose.version 
─────────┼────────┼──────────┼────────┼───────────────────────────────────────────────────────
 3.5 MiB │ +682 B │ 10.2 MiB │ +498 B │ (total)

DEX

STRINGS:

   old    │ new    │ diff      
  ────────┼────────┼───────────
   187973 │ 187973 │ 0 (+1 -1) 
  + SMAP
  PaymentLauncherConfirmationActivity.kt
  Kotlin
  *S Kotlin
  *F
  + 1 PaymentLauncherConfirmationActivity.kt
  com/stripe/android/payments/paymentlauncher/PaymentLauncherConfirmationActivity
  + 2 ActivityViewModelLazy.kt
  androidx/activity/ActivityViewModelLazyKt
  *L
  1#1,102:1
  43#2,5:103
  *S KotlinDebug
  *F
  + 1 PaymentLauncherConfirmationActivity.kt
  com/stripe/android/payments/paymentlauncher/PaymentLauncherConfirmationActivity
  *L
  32#1:103,5
  *E
  
  
  - SMAP
  PaymentLauncherConfirmationActivity.kt
  Kotlin
  *S Kotlin
  *F
  + 1 PaymentLauncherConfirmationActivity.kt
  com/stripe/android/payments/paymentlauncher/PaymentLauncherConfirmationActivity
  + 2 ActivityViewModelLazy.kt
  androidx/activity/ActivityViewModelLazyKt
  *L
  1#1,109:1
  43#2,5:110
  *S KotlinDebug
  *F
  + 1 PaymentLauncherConfirmationActivity.kt
  com/stripe/android/payments/paymentlauncher/PaymentLauncherConfirmationActivity
  *L
  34#1:110,5
  *E
  
  

METHODS:

   old    │ new    │ diff       
  ────────┼────────┼────────────
   183855 │ 183854 │ -1 (+0 -1) 
  - com.stripe.android.payments.paymentlauncher.PaymentLauncherConfirmationActivity setRequestedOrientation(int)

[skyler-stripe]

I want to see some screenshots of the 3ds2 challenges in portrait before we merge this. Unsure if they'll work.

[skyler-stripe]

Curious why only tablets?

[jameswoo-stripe]

I just want to make sure we aren't changing behavior for other device types. If we are confident that all device types can have this change, then I can remove this code.

[keithmacklin]

FYI This is what the webview looks like in landscape on Android SDK 26 (the one version that currently works)