Renames LinkAccountSession to FinancialConnectionsSession. #4910

carlosmuvi-stripe · 2022-04-25T17:55:29Z

Summary

A few renames to match the gaveled naming changes:

Before	After
LinkAccountSession	FinancialConnectionsSession
LinkedAccount	FinancialConnectionsAccount

Testing

Added tests
Modified tests
Manually verified

Changelog

- [Changed] 
  - LinkAccountSession -> FinancialConnectionsSession
  - LinkedAccount -> FinancialConnectionsAccount

github-actions · 2022-04-25T17:59:15Z

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: none)
NEW: paymentsheet-example-release-pr.apk (signature: none)

          │           compressed           │         uncompressed         
          ├───────────┬───────────┬────────┼──────────┬──────────┬────────
 APK      │ old       │ new       │ diff   │ old      │ new      │ diff   
──────────┼───────────┼───────────┼────────┼──────────┼──────────┼────────
      dex │  13.5 MiB │  13.5 MiB │ +178 B │ 45.1 MiB │ 45.1 MiB │ +568 B 
     arsc │   1.7 MiB │   1.7 MiB │    0 B │  1.7 MiB │  1.7 MiB │    0 B 
 manifest │   3.1 KiB │   3.1 KiB │    0 B │ 13.7 KiB │ 13.7 KiB │    0 B 
      res │ 709.9 KiB │ 709.9 KiB │    0 B │  1.1 MiB │  1.1 MiB │    0 B 
   native │   5.4 MiB │   5.4 MiB │    0 B │ 13.4 MiB │ 13.4 MiB │    0 B 
    asset │     3 MiB │     3 MiB │    0 B │    3 MiB │    3 MiB │    0 B 
    other │    80 KiB │    80 KiB │    0 B │  155 KiB │  155 KiB │    0 B 
──────────┼───────────┼───────────┼────────┼──────────┼──────────┼────────
    total │  24.3 MiB │  24.3 MiB │ +178 B │ 64.5 MiB │ 64.5 MiB │ +568 B 

         │          raw           │             unique              
         ├────────┬────────┬──────┼────────┬────────┬───────────────
 DEX     │ old    │ new    │ diff │ old    │ new    │ diff          
─────────┼────────┼────────┼──────┼────────┼────────┼───────────────
   files │      3 │      3 │    0 │        │        │               
 strings │ 218401 │ 218401 │    0 │ 192282 │ 192282 │ 0 (+74 -74)   
   types │  37856 │  37856 │    0 │  35089 │  35089 │ 0 (+23 -23)   
 classes │  32460 │  32460 │    0 │  32460 │  32460 │ 0 (+21 -21)   
 methods │ 195128 │ 195128 │    0 │ 188781 │ 188781 │ 0 (+123 -123) 
  fields │ 139278 │ 139278 │    0 │ 138399 │ 138399 │ 0 (+50 -50)   

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  292 │  292 │  0   
 entries │ 5757 │ 5757 │  0

APK

    compressed    │   uncompressed    │                
─────────┬────────┼──────────┬────────┤                
 size    │ diff   │ size     │ diff   │ path           
─────────┼────────┼──────────┼────────┼────────────────
 3.8 MiB │ +141 B │ 11.1 MiB │ +592 B │ ∆ classes3.dex 
 3.2 MiB │  +37 B │  8.7 MiB │  -24 B │ ∆ classes2.dex 
─────────┼────────┼──────────┼────────┼────────────────
 7.1 MiB │ +178 B │ 19.8 MiB │ +568 B │ (total)

DEX

STRINGS:

   old    │ new    │ diff        
  ────────┼────────┼─────────────
   192282 │ 192282 │ 0 (+74 -74) 
  + CreateFinancialConnectionsSessionParams(clientSecret=
  + CreateFinancialConnectionsSessionParams.kt
  + FinancialConnectionsSession(clientSecret=
  + FinancialConnectionsSession.kt
  + FinancialConnectionsSessionJsonParser.kt
  + Lcom/stripe/android/model/CreateFinancialConnectionsSessionParams_Companion;
  + Lcom/stripe/android/model/CreateFinancialConnectionsSessionParams;
  + Lcom/stripe/android/model/FinancialConnectionsSession_Creator;
  + Lcom/stripe/android/model/FinancialConnectionsSession;
  + Lcom/stripe/android/model/parsers/FinancialConnectionsSessionJsonParser_Companion;
  + Lcom/stripe/android/model/parsers/FinancialConnectionsSessionJsonParser;
  + [Lcom/stripe/android/model/FinancialConnectionsSession;
  + @
  ���
  ���
  
  ���
  
  ���
  ��	
  ���
  
  ���
  
  ��
  ���
  ���
  
  ���
  
  ���
  �������2�0�B�������0�������0�¢����J	����0�HÆ�J	���0�HÆ�J��
  ��02�������0�2�������0�HÆ�J	����0�HÖ�J�����0�2�������0�HÖ�J	����0�HÖ�J	����0�HÖ�J�����0�2�����0�2�����0�HÖ�R�����0�¢��
  ������R�����0�¢��
  ���	�
  ¨��
  + _financialConnectionsSession
  + ()Lcom/stripe/android/financialconnections/model/FinancialConnectionsSession;
  + (Lcom/stripe/android/model/StripeIntent;Lcom/stripe/android/financialconnections/model/FinancialConnectionsSession;)V
  + (Lcom/stripe/android/payments/bankaccount/navigation/CollectBankAccountContract_Args;Lkotlinx/coroutines/flow/MutableSharedFlow;Lcom/stripe/android/payments/bankaccount/domain/CreateFinancialConnectionsSession;Lcom/stripe/android/payments/bankaccount/domain/AttachFinancialConnectionsSession;Lcom/stripe/android/payments/bankaccount/domain/RetrieveStripeIntent;Lcom/stripe/android/core/Logger;)V
  + (Ljava/lang/String;Lcom/stripe/android/model/CreateFinancialConnectionsSessionParams;Lcom/stripe/android/core/networking/ApiRequest_Options;Lkotlin/coroutines/Continuation;)Ljava/lang/Object;
  + , financialConnectionsSession=
  + AttachFinancialConnectionsSession.kt
  + AttachFinancialConnectionsSession_Factory.java
  + CreateFinancialConnectionsSession.kt
  + CreateFinancialConnectionsSession_Factory.java
  + Lcom/stripe/android/financialconnections/model/FinancialConnectionsSession;
  + Lcom/stripe/android/networking/StripeApiRepository_attachFinancialConnectionsSessionToPaymentIntent_2;
  + Lcom/stripe/android/networking/StripeApiRepository_attachFinancialConnectionsSessionToSetupIntent_2;
  + Lcom/stripe/android/networking/StripeApiRepository_createPaymentIntentFinancialConnectionsSession_2;
  + Lcom/stripe/android/networking/StripeApiRepository_createSetupIntentFinancialConnectionsSession_2;
  + Lcom/stripe/android/payments/bankaccount/domain/AttachFinancialConnectionsSession_forPaymentIntent_1;
  + Lcom/stripe/android/payments/bankaccount/domain/AttachFinancialConnectionsSession_forSetupIntent_1;
  + Lcom/stripe/android/payments/bankaccount/domain/AttachFinancialConnectionsSession;
  + Lcom/stripe/android/payments/bankaccount/domain/AttachFinancialConnectionsSession_Factory;
  + Lcom/stripe/android/payments/bankaccount/domain/CreateFinancialConnectionsSession_forPaymentIntent_1;
  + Lcom/stripe/android/payments/bankaccount/domain/CreateFinancialConnectionsSession_forSetupIntent_1;
  + Lcom/stripe/android/payments/bankaccount/domain/CreateFinancialConnectionsSession;
  + Lcom/stripe/android/payments/bankaccount/domain/CreateFinancialConnectionsSession_Factory;
  + Lcom/stripe/android/payments/bankaccount/ui/CollectBankAccountViewModel_attachFinancialConnectionsSessionToIntent_1;
  + Lcom/stripe/android/payments/bankaccount/ui/CollectBankAccountViewModel_createFinancialConnectionsSession_1;
  + Lcom/stripe/android/payments/bankaccount/ui/CollectBankAccountViewModel_finishWithFinancialConnectionsSession_1;
  + SMAP
  AttachFinancialConnectionsSession.kt
  Kotlin
  *S Kotlin
  *F
  + 1 AttachFinancialConnectionsSession.kt
  com/stripe/android/payments/bankaccount/domain/AttachFinancialConnectionsSession
  + 2 fake.kt
  kotlin/jvm/internal/FakeKt
  *L
  1#1,51:1
  1#2:52
  *E
  
  + SMAP
  CollectBankAccountViewModel.kt
  Kotlin
  *S Kotlin
  *F
  + 1 CollectBankAccountViewModel.kt
  com/stripe/android/payments/bankaccount/ui/CollectBankAccountViewModel_attachFinancialConnectionsSessionToIntent_1
  + 2 fake.kt
  kotlin/jvm/internal/FakeKt
  *L
  1#1,171:1
  1#2:172
  *E
  
  + SMAP
  CreateFinancialConnectionsSession.kt
  Kotlin
  *S Kotlin
...✂

…ial-connections-session

carlosmuvi-stripe · 2022-04-26T23:09:54Z

...main/java/com/stripe/android/financialconnections/domain/FetchFinancialConnectionsSession.kt

+import com.stripe.android.financialconnections.repository.FinancialConnectionsRepository
+import javax.inject.Inject
+
+internal class FetchFinancialConnectionsSession @Inject constructor(


No changes, just renamed the class.

carlosmuvi-stripe · 2022-04-26T23:10:06Z

...a/com/stripe/android/financialconnections/domain/FetchFinancialConnectionsSessionForToken.kt

+import org.json.JSONObject
+import javax.inject.Inject
+
+internal class FetchFinancialConnectionsSessionForToken @Inject constructor(


No changes, just renamed the class.

jameswoo-stripe

Lgtm other than some file naming

jameswoo-stripe · 2022-04-28T17:03:50Z

...va/com/stripe/android/financialconnections/FinancialFinancialConnectionsSheetContractTest.kt

@@ -20,22 +20,22 @@ class FinancialFinancialConnectionsSheetContractTest {
    @Test


File naming?

jameswoo-stripe · 2022-04-28T17:04:25Z

...va/com/stripe/android/financialconnections/FinancialFinancialConnectionsSheetActivityTest.kt

@@ -33,7 +33,7 @@ class FinancialFinancialConnectionsSheetActivityTest {
    private val context = ApplicationProvider.getApplicationContext<Context>()


The name of this file seems off :D

jameswoo-stripe · 2022-04-28T17:05:01Z

.../android/financialconnections/analytics/DefaultFinancialFinancialConnectionsEventReporter.kt

@@ -20,7 +20,7 @@ internal class DefaultFinancialFinancialConnectionsEventReporter @Inject constru
        fireEvent(


File naming?

jameswoo-stripe · 2022-04-28T17:06:51Z

...a/com/stripe/android/financialconnections/FinancialFinancialConnectionsSheetViewModelTest.kt

@@ -6,16 +6,16 @@ import androidx.lifecycle.SavedStateHandle
 import androidx.test.ext.junit.runners.AndroidJUnit4


File naming?

…ial-connections-session

charliecruzan-stripe

lgtm 👍 (im not a codeowner though)

will be aware of these changes next time we update stripe-react-native

Renames LinkAccountSession to FinancialConnectionsSession.

b42ba1e

carlosmuvi-stripe added 2 commits April 25, 2022 11:13

Renames endpoints (WIP)

0dd4987

Merge remote-tracking branch 'origin/master' into f/renames-to-financ…

73d9de0

…ial-connections-session

carlosmuvi-stripe requested a review from vardges-stripe April 26, 2022 17:01

carlosmuvi-stripe added 3 commits April 26, 2022 11:59

Style fixes.

926e4de

Revert endpoint changes.

2ff6a32

Updates missing session and account occurrences.

80439f9

carlosmuvi-stripe commented Apr 26, 2022

View reviewed changes

Updates example.

b61eb3e

carlosmuvi-stripe requested review from charliecruzan-stripe and jameswoo-stripe April 26, 2022 23:13

carlosmuvi-stripe added 3 commits April 26, 2022 16:22

Updates example.

6154f9e

Updates payments api.

67aeb83

Updates changelog.

76f575e

carlosmuvi-stripe marked this pull request as ready for review April 28, 2022 16:43

carlosmuvi-stripe requested review from brnunes-stripe, michelleb-stripe, skyler-stripe, ccen-stripe and awush-stripe as code owners April 28, 2022 16:43

carlosmuvi-stripe changed the title ~~[WIP] Renames LinkAccountSession to FinancialConnectionsSession.~~ Renames LinkAccountSession to FinancialConnectionsSession. Apr 28, 2022

carlosmuvi-stripe removed request for brnunes-stripe, michelleb-stripe and ccen-stripe April 28, 2022 16:49

jameswoo-stripe reviewed Apr 28, 2022

View reviewed changes

carlosmuvi-stripe added 3 commits April 28, 2022 10:16

Merge remote-tracking branch 'origin/master' into f/renames-to-financ…

4f15247

…ial-connections-session

Adds missing renames.

2cc3260

Removes double financial occurrences.

24fda77

Api updates.

5861b98

carlosmuvi-stripe assigned jameswoo-stripe Apr 28, 2022

carlosmuvi-stripe requested a review from jameswoo-stripe April 28, 2022 20:02

charliecruzan-stripe approved these changes Apr 28, 2022

View reviewed changes

jameswoo-stripe approved these changes Apr 28, 2022

View reviewed changes

stripe-ci assigned carlosmuvi-stripe and unassigned jameswoo-stripe Apr 28, 2022

carlosmuvi-stripe merged commit a3a2796 into master Apr 28, 2022

carlosmuvi-stripe deleted the f/renames-to-financial-connections-session branch April 28, 2022 21:57

carlosmuvi-stripe added the financial-connections Relates to the Financial Connections SDK label Jul 22, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Renames LinkAccountSession to FinancialConnectionsSession. #4910

Renames LinkAccountSession to FinancialConnectionsSession. #4910

carlosmuvi-stripe commented Apr 25, 2022 •

edited

Loading

github-actions bot commented Apr 25, 2022 •

edited

Loading

carlosmuvi-stripe Apr 26, 2022

carlosmuvi-stripe Apr 26, 2022

jameswoo-stripe left a comment

jameswoo-stripe Apr 28, 2022

jameswoo-stripe Apr 28, 2022

jameswoo-stripe Apr 28, 2022

jameswoo-stripe Apr 28, 2022

charliecruzan-stripe left a comment

		@@ -20,22 +20,22 @@ class FinancialFinancialConnectionsSheetContractTest {
		@Test

		@@ -33,7 +33,7 @@ class FinancialFinancialConnectionsSheetActivityTest {
		private val context = ApplicationProvider.getApplicationContext<Context>()

		@@ -20,7 +20,7 @@ internal class DefaultFinancialFinancialConnectionsEventReporter @Inject constru
		fireEvent(

		@@ -6,16 +6,16 @@ import androidx.lifecycle.SavedStateHandle
		import androidx.test.ext.junit.runners.AndroidJUnit4

Renames LinkAccountSession to FinancialConnectionsSession. #4910

Renames LinkAccountSession to FinancialConnectionsSession. #4910

Conversation

carlosmuvi-stripe commented Apr 25, 2022 • edited Loading

Summary

Testing

Changelog

github-actions bot commented Apr 25, 2022 • edited Loading

carlosmuvi-stripe Apr 26, 2022

Choose a reason for hiding this comment

carlosmuvi-stripe Apr 26, 2022

Choose a reason for hiding this comment

jameswoo-stripe left a comment

Choose a reason for hiding this comment

jameswoo-stripe Apr 28, 2022

Choose a reason for hiding this comment

jameswoo-stripe Apr 28, 2022

Choose a reason for hiding this comment

jameswoo-stripe Apr 28, 2022

Choose a reason for hiding this comment

jameswoo-stripe Apr 28, 2022

Choose a reason for hiding this comment

charliecruzan-stripe left a comment

Choose a reason for hiding this comment

carlosmuvi-stripe commented Apr 25, 2022 •

edited

Loading

github-actions bot commented Apr 25, 2022 •

edited

Loading