-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 3ds2 url to list of completion URLs so callbacks work correctly. #5079
Conversation
…s fired correctly
"https://hooks.stripe.com/3d_secure/complete/", | ||
"https://hooks.stripe.com/3d_secure_2/hosted/complete" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may be for a future PR, but can't we just match all urls that are https://hooks.stripe.com
, then we don't need to maintain this list?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's also https://hooks.stripe.com/three_d_secure/authenticate
which triggers a different flow. So unfortunately not :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does feel like a value that should come from a server rather than be hard coded though. Hopefully we can add it later this year after we have that capability.
Diffuse output:
APK
DEX
|
Summary
Stripe.handleNextAction
orPaymentLauncher.handleNextAction
.handleNextAction
does not do this, so we need add to our list of URLs so the activity result is fired correctly.Motivation
Testing
Created a PI with a next-action of 3ds, and hard coded it both with
PaymentLauncher
andStripe
. I confirmed that the webview would not hang and fires the callback correctly.