Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OXXO so that processing is a terminal state. #5308

Merged
merged 2 commits into from
Jul 21, 2022

Conversation

michelleb-stripe
Copy link
Contributor

Summary

Fix OXXO so that processing is considered a successful terminal state, similar to Konbini and Boleto

Testing

  • Added tests
  • Modified tests
  • Manually verified

Changelog

[Fixed] OXXO so that processing is considered a successful terminal state, similar to Konbini and Boleto.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 21, 2022

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: none)
NEW: paymentsheet-example-release-pr.apk (signature: none)

          │          compressed           │         uncompressed         
          ├───────────┬───────────┬───────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff  │ old       │ new       │ diff 
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼──────
      dex │  15.3 MiB │  15.3 MiB │ +31 B │  51.7 MiB │  51.7 MiB │ +8 B 
     arsc │   1.8 MiB │   1.8 MiB │   0 B │   1.8 MiB │   1.8 MiB │  0 B 
 manifest │     4 KiB │     4 KiB │   0 B │  18.5 KiB │  18.5 KiB │  0 B 
      res │ 870.7 KiB │ 870.7 KiB │   0 B │   1.4 MiB │   1.4 MiB │  0 B 
   native │   2.5 MiB │   2.5 MiB │   0 B │   5.9 MiB │   5.9 MiB │  0 B 
    asset │     3 MiB │     3 MiB │   0 B │     3 MiB │     3 MiB │  0 B 
    other │  81.7 KiB │  81.7 KiB │   0 B │ 155.5 KiB │ 155.5 KiB │  0 B 
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼──────
    total │  23.5 MiB │  23.5 MiB │ +31 B │  63.9 MiB │  63.9 MiB │ +8 B 

         │          raw           │           unique            
         ├────────┬────────┬──────┼────────┬────────┬───────────
 DEX     │ old    │ new    │ diff │ old    │ new    │ diff      
─────────┼────────┼────────┼──────┼────────┼────────┼───────────
   files │      4 │      4 │    0 │        │        │           
 strings │ 250160 │ 250160 │    0 │ 213275 │ 213275 │ 0 (+0 -0) 
   types │  44119 │  44119 │    0 │  40499 │  40499 │ 0 (+0 -0) 
 classes │  37701 │  37701 │    0 │  37701 │  37701 │ 0 (+0 -0) 
 methods │ 220526 │ 220526 │    0 │ 212576 │ 212576 │ 0 (+0 -0) 
  fields │ 162578 │ 162578 │    0 │ 161543 │ 161543 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  292 │  292 │  0   
 entries │ 6223 │ 6223 │  0
APK
   compressed    │  uncompressed  │                
─────────┬───────┼─────────┬──────┤                
 size    │ diff  │ size    │ diff │ path           
─────────┼───────┼─────────┼──────┼────────────────
 2.2 MiB │ +31 B │ 6.8 MiB │ +8 B │ ∆ classes3.dex 
─────────┼───────┼─────────┼──────┼────────────────
 2.2 MiB │ +31 B │ 6.8 MiB │ +8 B │ (total)

@michelleb-stripe michelleb-stripe merged commit e12cfe6 into master Jul 21, 2022
@michelleb-stripe michelleb-stripe deleted the michelleb/fix-oxxo branch July 21, 2022 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants