Fix issue with custom flow PaymentSheet getting clipped #5545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameswoo-stripe
requested review from
brnunes-stripe and
tillh-stripe
as code owners
jameswoo-stripe
force-pushed
the
jameswoo/1470-payment-sheet-clipping
branch
from
4d608dc to
c85aef0
Compare
jameswoo-stripe
requested review from
ccen-stripe and
awush-stripe
as code owners
brnunes-stripe
approved these changes
Sep 13, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix an issue where the custom flow PaymentSheet is getting clipped when save for future use and zip code are present in the billing address form.
The clipping issue was introduced in #4961. Added the animations back in and verified that the keyboard issue is not present when there is only 1 payment method and google pay is disabled. Also added a browserstack test just to make sure it is not reintroduced.
Motivation
https://jira.corp.stripe.com/browse/RUN_MOBILESDK-1470
Testing
Screenshots
Changelog