Fix Alipay integration #5554
Merged
Fix Alipay integration #5554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brnunes-stripe
requested review from
ccen-stripe,
awush-stripe,
tillh-stripe and
jameswoo-stripe
as code owners
|
Diffuse output: APKDEX |
# Conflicts: # CHANGELOG.md
tillh-stripe
previously approved these changes
Sep 14, 2022
ccen-stripe
reviewed
Sep 17, 2022
| updateStatus("\n\nUser canceled confirmation") | ||
| else -> | ||
| updateStatus( | ||
| "\n\nPayment failed or canceled." + |
There was a problem hiding this comment.
It seems last time I checked, an in-app web browser would be opened if we cancel the native flow, seems that's no longer happening with the recording, could you elaborate a bit why that happened?
There was a problem hiding this comment.
I removed line 32 here, and have a PR updating the documentation.
When the user completes the payment in the Alipay app, the PI status will be Suceeded. If they cancel, it will be RequiresAction.
Calling Stripe.handleNextActionForPayment would try to confirm again, using a webview. That's not what we want, since the user just canceled. The docs are also not showing how to handle the result of that call, which is handled in onActivityResult.
jameswoo-stripe
approved these changes
Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix Alipay integration when using the Alipay SDK.
We were trying to parse the response of the call to
nextActionData.authCompleteUrlto a JSON object, when the response is not necessarily in JSON format.Add example activities to test the native and web integrations.
Motivation
RUN_APAC_PAYMENT_METHODS-6838
Testing
alipay.mp4