Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate Bitcoin #559

Merged
merged 1 commit into from
Apr 25, 2018
Merged

Deprecate Bitcoin #559

merged 1 commit into from
Apr 25, 2018

Conversation

ksun-stripe
Copy link

@ksun-stripe ksun-stripe requested a review from danj-stripe April 25, 2018 00:31
@ksun-stripe ksun-stripe removed the request for review from danj-stripe April 25, 2018 00:33
@ksun-stripe ksun-stripe force-pushed the ksun-deprecate-bitcoin branch from 5bf5d31 to 46302fd Compare April 25, 2018 00:45
@ksun-stripe ksun-stripe force-pushed the ksun-deprecate-bitcoin branch from 46302fd to 5ae008f Compare April 25, 2018 00:57
joeydong-stripe
joeydong-stripe approved these changes Apr 25, 2018
View reviewed changes
Copy link
Contributor

@joeydong-stripe joeydong-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

We should also make a note in CHANGELOG and maybe MIGRATING too if you were handling BITCOIN in a switch statement or something. Mostly mention that the source will be an "unknown" type now and you can no longer create BITCOIN sources.

@ksun-stripe ksun-stripe merged commit cf5828b into master Apr 25, 2018
@mshafrir-stripe mshafrir-stripe deleted the ksun-deprecate-bitcoin branch January 24, 2019 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeydong-stripe joeydong-stripe joeydong-stripe approved these changes

Assignees

@ksun-stripe ksun-stripe

Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ksun-stripe @joeydong-stripe @stripe-ci @danj-stripe @ksun2-stripe