Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent multiple invocations of final result #5749

Conversation

awush-stripe
Copy link
Collaborator

Summary

Prevent multiple invocations of the final result, which could trigger multiple calls to the /verify_frames endpoint

Motivation

Elevated 500s on the /verify_frames endpoint

Testing

  • Added tests
  • Modified tests
  • Manually verified

Changelog

@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2022

Diffuse output:

OLD: identity-example-release-base.apk (signature: none)
NEW: identity-example-release-pr.apk (signature: none)

          │           compressed           │         uncompressed         
          ├───────────┬───────────┬────────┼──────────┬──────────┬────────
 APK      │ old       │ new       │ diff   │ old      │ new      │ diff   
──────────┼───────────┼───────────┼────────┼──────────┼──────────┼────────
      dex │   1.7 MiB │   1.7 MiB │ +376 B │  3.7 MiB │  3.7 MiB │ +264 B 
     arsc │   1.1 MiB │   1.1 MiB │    0 B │  1.1 MiB │  1.1 MiB │    0 B 
 manifest │     2 KiB │     2 KiB │    0 B │  7.1 KiB │  7.1 KiB │    0 B 
      res │ 382.4 KiB │ 382.4 KiB │    0 B │  580 KiB │  580 KiB │    0 B 
   native │   6.1 MiB │   6.1 MiB │    0 B │ 15.6 MiB │ 15.6 MiB │    0 B 
    asset │   5.7 KiB │   5.7 KiB │    0 B │  5.4 KiB │  5.4 KiB │    0 B 
    other │  28.8 KiB │  28.8 KiB │    0 B │   30 KiB │   30 KiB │    0 B 
──────────┼───────────┼───────────┼────────┼──────────┼──────────┼────────
    total │   9.3 MiB │   9.3 MiB │ +376 B │ 20.9 MiB │ 20.9 MiB │ +264 B 

 DEX     │ old   │ new   │ diff        
─────────┼───────┼───────┼─────────────
   files │     1 │     1 │  0          
 strings │ 18814 │ 18814 │  0 (+3 -3)  
   types │  6622 │  6622 │  0 (+0 -0)  
 classes │  5693 │  5693 │  0 (+0 -0)  
 methods │ 29240 │ 29240 │  0 (+0 -0)  
  fields │ 14574 │ 14578 │ +4 (+12 -8) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  259 │  259 │  0   
 entries │ 4740 │ 4740 │  0
APK
    compressed    │   uncompressed   │               
─────────┬────────┼─────────┬────────┤               
 size    │ diff   │ size    │ diff   │ path          
─────────┼────────┼─────────┼────────┼───────────────
 1.7 MiB │ +376 B │ 3.7 MiB │ +264 B │ ∆ classes.dex 
─────────┼────────┼─────────┼────────┼───────────────
 1.7 MiB │ +376 B │ 3.7 MiB │ +264 B │ (total)
DEX
STRINGS:

   old   │ new   │ diff      
  ───────┼───────┼───────────
   18814 │ 18814 │ 0 (+3 -3) 
  + com.stripe.android.camera.framework.ResultAggregator_onResult_2_1_1
  + com.stripe.android.camera.framework.ResultAggregator_onResult_2_1_2
  + ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:45f914f,r8-mode:compatibility,version:3.3.83}
  
  - com.stripe.android.camera.framework.ResultAggregator_onResult_2_1
  - com.stripe.android.camera.framework.ResultAggregator_onResult_2_2_1
  - ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:27a7afc,r8-mode:compatibility,version:3.3.83}
  

FIELDS:

   old   │ new   │ diff        
  ───────┼───────┼─────────────
   14574 │ 14578 │ +4 (+12 -8) 
  + com.stripe.android.camera.framework.ResultAggregator o: c
  + com.stripe.android.camera.framework.ResultAggregator r: boolean
  + com.stripe.android.camera.framework.ResultAggregator s: u
  + com.stripe.android.camera.framework.ResultAggregator t: k
  + com.stripe.android.identity.camera.IdentityAggregator u: boolean
  + q5.t n: b
  + q5.t o: ResultAggregator
  + q5.t q: Object
  + q5.t r: int
  + q5.t t: ResultAggregator
  + q5.t u: Object
  + q5.t v: Object
  
  - com.stripe.android.camera.framework.ResultAggregator o: boolean
  - com.stripe.android.camera.framework.ResultAggregator r: u
  - com.stripe.android.camera.framework.ResultAggregator s: k
  - com.stripe.android.identity.camera.IdentityAggregator t: boolean
  - q5.t n: Object
  - q5.t o: int
  - q5.t q: ResultAggregator
  - q5.t r: Object

@awush-stripe awush-stripe force-pushed the awush/ir-cliff-genre/prevent_multiple_invocations_of_final_result branch from 9585e7a to 5ccfaf1 Compare October 26, 2022 21:22
@awush-stripe awush-stripe enabled auto-merge (squash) October 26, 2022 21:28
@awush-stripe awush-stripe merged commit 928d3ee into master Oct 27, 2022
@awush-stripe awush-stripe deleted the awush/ir-cliff-genre/prevent_multiple_invocations_of_final_result branch October 27, 2022 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants