-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add autocomplete affordance to the address element. #5927
Conversation
Diffuse output:
APK
DEX
ARSC
|
fec446e
to
41a2051
Compare
Waiting for search strings to be localized: https://jira.corp.stripe.com/browse/L10N-4155 |
41a2051
to
7776adc
Compare
@@ -230,3 +226,47 @@ open class AddressElement constructor( | |||
this.rawValuesMap = rawValuesMap | |||
} | |||
} | |||
|
|||
internal suspend fun updateLine1WithAutocompleteAffordance( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I won't claim this to be my finest work. But this was the best place I could find to do it. And it is tested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected. Only a single comment about the release notes.
payments-ui-core/src/main/java/com/stripe/android/ui/core/elements/AddressElement.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small nit, but lgtm
9d96e11
Summary
Motivation
Testing
Screenshots
AutocompleteAffordanceDemo.webm
Changelog