Add support for downloading images for LUXE payment methods. #5928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Diffuse output: APKDEXARSC |
This was referenced Dec 8, 2022
jaynewstrom-stripe
requested review from
tillh-stripe,
jameswoo-stripe,
ccen-stripe,
awush-stripe and
carlosmuvi-stripe
as code owners
|
|
||
| /** | ||
| * The customer's selected payment option. | ||
| */ | ||
| data class PaymentOption( | ||
| data class PaymentOption | ||
| @Deprecated("Not intended for public use.") |
There was a problem hiding this comment.
Should call this out in the changelog?
| /** | ||
| * The drawable resource id of the icon that represents the payment option. | ||
| */ | ||
| @DrawableRes val drawableResourceId: Int, | ||
| @Deprecated("Please use fetchIcon instead.") |
There was a problem hiding this comment.
Should call this out in changelog?
| /** | ||
| * Fetches the icon associated with this [PaymentOption]. | ||
| */ | ||
| fun icon(): Drawable { |
There was a problem hiding this comment.
This is new public API. Should be in the changelog.
There was a problem hiding this comment.
Good catch. I updated the Changelog with the suggested items.
| private val paymentOption: PaymentOption, | ||
| ) : Drawable() { | ||
| init { | ||
| @OptIn(DelicateCoroutinesApi::class) |
There was a problem hiding this comment.
Since this is used in integrators code, what happens when this API changes? Wouldn't the integrator be forced to update Stripe SDK version? Should we be more careful here?
There was a problem hiding this comment.
This is a stable API. The annotation has a description of:
Marks declarations in the coroutines that are delicate — they have limited use-case and shall be used with care in general code. Any use of a delicate declaration has to be carefully reviewed to make sure it is properly used and does not create problems like memory and resource leaks. Carefully read documentation of any declaration marked as DelicateCoroutinesApi.
Basically saying don't use this unless you're really sure you want to. In our case, I think it's the right API to use (GlobalScope), due to us not being in coroutines/structured concurrency land.
jameswoo-stripe
approved these changes
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Different approach to #5851
Motivation
https://paper.dropbox.com/doc/LUXE-Milestone-Images-V2--BtOExZa66TaUp8wYBzPWDezaAg-oIaL68ZVfjQ8J64zthANK
Testing
Screenshots
Changelog