Rename methods to include params #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
danj-stripe
approved these changes
Jul 13, 2018
| @@ -273,7 +273,7 @@ public void disabled_confirmPaymentIntent_withSourceData_canSuccessfulConfirm() | |||
| try { | |||
|
|
|||
| Card card = new Card("4242424242424242", 1, 2050, "123"); | |||
| PaymentIntentParams paymentIntentParams = PaymentIntentParams.createConfirmPaymentIntentWithSourceData( | |||
| PaymentIntentParams paymentIntentParams = PaymentIntentParams.createConfirmPaymentIntentWithSourceDataParams( | |||
There was a problem hiding this comment.
Is it worth renaming the test case method names to include the Params word?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per https://www.google.com/url?hl=en&q=https://git.corp.stripe.com/stripe-internal/pay-server/pull/100790%23discussion_r350269&source=gmail&ust=1531590867887000&usg=AFQjCNH-8yMe9QkzB2CutxftNNIUqmaCIg
Separate from this we will want to make sure we update all the docs to contain the strong method string names
cc: @garrett-stripe