Fix link inline for custom flow. #6090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pretty subtle. But I missed this in my original PR. https://github.com/stripe/stripe-android/pull/6004/files#diff-f311031c234ce3fc5f9425a479114c55440d6aede03a085e857e0ff3da40320dL435 In the base view model, it does one thing, then payment sheet overrides it to do both things. When I copied the implementation, I combined payment sheet with the base, and missed this difference in behavior. |
jaynewstrom-stripe
requested review from
tillh-stripe,
jameswoo-stripe,
ccen-stripe,
awush-stripe and
carlosmuvi-stripe
as code owners
CHANGELOG.md
Outdated
| @@ -4,6 +4,7 @@ | |||
|
|
|||
| ### PaymentSheet | |||
| * [CHANGED][5927](https://github.com/stripe/stripe-android/pull/5927) Customers can now re-enter the autocomplete flow of the Address Element by tapping an icon in the line 1 text field. | |||
| * [FIXED][6090](https://github.com/stripe/stripe-android/pull/6090) Fixed an issue where link was not working for users adding a payment method via the custom flow. | |||
There was a problem hiding this comment.
Should we give some more detail here?
Suggested change
| * [FIXED][6090](https://github.com/stripe/stripe-android/pull/6090) Fixed an issue where link was not working for users adding a payment method via the custom flow. | |
| * [FIXED][6090](https://github.com/stripe/stripe-android/pull/6090) Fixed an issue where adding a payment method to an existing Link account didn’t work when using `PaymentSheet.FlowController`. |
There was a problem hiding this comment.
Changed minorly, since it affects any user adding a payment method, not just an existing user.
tillh-stripe
approved these changes
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This was causing end to end tests to fail.
Motivation
Testing
Screenshots
Changelog