-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix BLIK bindings #6376
Fix BLIK bindings #6376
Conversation
Diffuse output:
APK
|
StripeIntent.NextActionType.WeChatPayRedirect, | ||
StripeIntent.NextActionType.CashAppRedirect, | ||
null -> { | ||
false | ||
} | ||
StripeIntent.NextActionType.BlikAuthorize, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, this and the change in PaymentIntent
is the actual fix, everything else is to add the example.
It could, and I thought about it, but the code does nothing in test mode, so there isn't much point in adding it, but if you think we need it I'll add it. |
I tested some error scenarios and tested the The confirmation succeeds on the client: On dashboard it is a fail, which it should be: You can inspect this payment intent: |
Interesting, thanks for the scenarios link, I'll test those |
Ok, I see what's going on here, the payment fails after the secondary action, but the client only receives a response after creating the PI, here is what the PI looks like after it is created and the client receives it: It has As explained in the docs, it means that this part of the flow has succeeded but there is still another step that the customer needs to take. |
Makes sense to me, thank you! |
Summary
BLIK was returning a cancelled status in bindings because the next action was not treated as a successful status.
Motivation
https://jira.corp.stripe.com/browse/RUN_MOBILESDK-2179
Testing
Added example activity to visually verify.
Screenshots
Changelog