Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Identity] Use ml-core-default by default #6380

Merged
merged 7 commits into from
Mar 20, 2023
Merged

Conversation

ccen-stripe
Copy link
Contributor

@ccen-stripe ccen-stripe commented Mar 16, 2023

Summary

Use ml-core-default module for Identity and update the README on how to replace it with ml-core-googleplay

Motivation

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before After
before screenshot after screenshot

Changelog

  • [ADDED]6380 Integrate with ml-core and allow user to swap TFLite runtime.

@ccen-stripe ccen-stripe requested review from a team as code owners March 16, 2023 23:46
@ccen-stripe ccen-stripe requested review from jameswoo-stripe and removed request for a team March 16, 2023 23:46
@ccen-stripe ccen-stripe requested review from awush-stripe and jaynewstrom-stripe and removed request for jameswoo-stripe March 16, 2023 23:47
@github-actions
Copy link
Contributor

github-actions bot commented Mar 16, 2023

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │            compressed            │           uncompressed           
          ├───────────┬───────────┬──────────┼───────────┬───────────┬──────────
 APK      │ old       │ new       │ diff     │ old       │ new       │ diff     
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
      dex │   1.8 MiB │   1.8 MiB │ +1.9 KiB │   3.8 MiB │   3.8 MiB │ +3.3 KiB 
     arsc │   1.2 MiB │   1.2 MiB │      0 B │   1.2 MiB │   1.2 MiB │      0 B 
 manifest │   2.1 KiB │   2.1 KiB │      0 B │   7.4 KiB │   7.4 KiB │      0 B 
      res │ 337.4 KiB │ 337.4 KiB │      0 B │ 466.3 KiB │ 466.3 KiB │      0 B 
   native │   6.2 MiB │   6.2 MiB │      0 B │  15.8 MiB │  15.8 MiB │      0 B 
    asset │  67.4 KiB │  67.4 KiB │    +31 B │  87.3 KiB │  87.4 KiB │    +31 B 
    other │ 109.2 KiB │ 109.2 KiB │    +10 B │ 249.9 KiB │ 249.9 KiB │      0 B 
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
    total │   9.8 MiB │   9.8 MiB │   +2 KiB │  21.6 MiB │  21.6 MiB │ +3.3 KiB 

 DEX     │ old   │ new   │ diff              
─────────┼───────┼───────┼───────────────────
   files │     1 │     1 │   0               
 strings │ 18998 │ 19074 │ +76 (+427 -351)   
   types │  5863 │  5872 │  +9 (+359 -350)   
 classes │  4755 │  4764 │  +9 (+335 -326)   
 methods │ 29365 │ 29386 │ +21 (+6901 -6880) 
  fields │ 16369 │ 16391 │ +22 (+2622 -2600) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  258 │  258 │  0   
 entries │ 5108 │ 5108 │  0
APK
     compressed      │     uncompressed     │                                
──────────┬──────────┼───────────┬──────────┤                                
 size     │ diff     │ size      │ diff     │ path                           
──────────┼──────────┼───────────┼──────────┼────────────────────────────────
  1.8 MiB │ +1.9 KiB │   3.8 MiB │ +3.3 KiB │ ∆ classes.dex                  
    697 B │    +19 B │     565 B │    +19 B │ ∆ assets/dexopt/baseline.profm 
  5.6 KiB │    +12 B │   5.5 KiB │    +12 B │ ∆ assets/dexopt/baseline.prof  
 47.5 KiB │     +9 B │ 108.8 KiB │      0 B │ ∆ META-INF/CERT.SF             
 30.4 KiB │     +2 B │ 108.7 KiB │      0 B │ ∆ META-INF/MANIFEST.MF         
  1.2 KiB │     -1 B │   1.2 KiB │      0 B │ ∆ META-INF/CERT.RSA            
──────────┼──────────┼───────────┼──────────┼────────────────────────────────
  1.9 MiB │   +2 KiB │     4 MiB │ +3.3 KiB │ (total)
DEX
STRINGS:

   old   │ new   │ diff            
  ───────┼───────┼─────────────────
   18998 │ 19074 │ +76 (+427 -351) 
  + A3
  + B3
  + C3
  + D3
  + E3
  + F3
  + Failed to initialize TFLite runtime: 
  + G3
  + H3
  + I3
  + Instantiated delegates (other than NnApiDelegate) are not allowed when using TF Lite from Google Play Services. Please use InterpreterApi.Options.addDelegateFactory() with an appropriate DelegateFactory instead.
  + J3
  + JILLLIZZZJ
  + K2
  + K3
  + L2
  + L3
  + La8/c;
  + La8/d;
  + La8/e;
  + La8/f;
  + La8/g;
  + La8/h;
  + Lb8/c;
  + Lc9/a;
  + Lc9/b;
  + Lc9/c;
  + Lc9/d;
  + Lc9/e;
  + Lc9/f;
  + Lc9/g;
  + Lc9/h;
  + Lc9/i;
  + Lc9/j;
  + Lc9/k;
  + Lc9/l;
  + Lc9/m;
  + Lc9/n;
  + Ld9/a;
  + Ld9/b;
  + Le8/f;
  + Le8/g;
  + Le8/h;
  + Le8/i;
  + Le9/a;
  + Le9/b;
  + Le9/c;
  + Lf8/b;
  + Lf8/c;
  + Lf8/d;
  + Lf8/e;
  + Lf8/f;
  + Lf8/g;
  + Lf8/h;
  + Lf8/i;
  + Lf8/j;
  + Lf8/k;
  + Lf8/l;
  + Lf8/m;
  + Lf8/n;
  + Lf8/o;
  + Lf8/p;
  + Lf8/q;
  + Lf8/r;
  + Lf8/s;
  + Lf8/t;
  + Lg8/e;
  + Lk7/l0;
  + Lm8/d;
  + Lm8/e;
  + Lm8/f;
  + Lm8/g;
  + Lm8/h;
  + Lm8/i;
  + Lm8/j;
  + Ln8/g;
  + Ln8/h;
  + Ln8/i;
  + Ln8/j;
  + Ln8/k;
  + Ln8/l;
  + Lo7/b;
  + Lo7/c;
  + Lo7/d;
  + Lo7/e;
  + Lo7/f;
  + Lo7/g;
  + Lo7/h;
  + Lo7/i;
  + Lo7/j;
  + Lo7/k;
  + Lo7/l;
  + Lo7/m;
  + Lo7/n;
  + Lo7/o;
  + Lo7/p;
  + Lo7/q;
  + Lo7/r;
  + Lo7/s;
  + Lorg/tensorflow/lite/e;
  + Lorg/tensorflow/lite/f;
  + Lp7/a0;
  + Lp7/a1;
  + Lp7/b0;
  + Lp7/b1;
  + Lp7/c0;
  + Lp7/c1;
  + Lp7/d0;
  + Lp7/d1;
  + Lp7/e0;
  + Lp7/e1;
  + Lp7/f0;
  + Lp7/f1;
  + Lp7/g0;
  + Lp7/g1;
  + Lp7/h0;
  + Lp7/h1;
  + Lp7/i0;
  + Lp7/i1;
  + Lp7/j0;
  + Lp7/j1;
  + Lp7/k0;
  + Lp7/k1;
  + Lp7/l0;
  + Lp7/l1;
  + Lp7/m0;
  + Lp7/m1;
  + Lp7/n0;
  + Lp7/n1;
  + Lp7/o0;
  + Lp7/o1;
  + Lp7/p0;
  + Lp7/p1;
  + Lp7/q0;
  + Lp7/q1;
  + Lp7/r0;
  + Lp7/r1;
  + Lp7/s0;
  + Lp7/s1;
  + Lp7/t0;
  + Lp7/u0;
  + Lp7/v0;
  + Lp7/w0;
  + Lp7/x0;
  + Lp7/y0;
  + Lp7/z0;
  + Lq8/a0;
  + Lq8/b0;
  + Lq8/c0;
  + Lq8/d0;
  + Lq8/e0;
  + Lq8/f;
  + Lq8/g;
  + Lq8/h;
  + Lq8/i;
  + Lq8/j;
  + Lq8/k;
  + Lq8/l;
  + Lq8/m;
  + Lq8/n;
  + Lq8/o;
  + Lq8/p;
  + Lq8/q;
  + Lq8/r;
  + Lq8/s;
  + Lq8/t;
  + Lq8/u;
  + Lq8/v;
  + Lq8/w;
  + Lq8/x;
  + Lq8/y;
  + Lq8/z;
  + Lr0/y0;
  + Lr7/c;
  + Lr7/d;
  + Lr7/e;
  + Lr7/f;
  + Lr7/g;
  + Lr7/h;
  + Lr7/i;
  + Lr7/j;
  + Lr7/k;
  + Lr7/l;
  + Lr7/m;
  + Lr7/n;
  + Lr7/o;
  + Lr7/p;
  + Lr7/q;
  + Lr7/r;
  + Lr7/s;
  + Lr7/t;
  + Lr7/u;
  + Lr7/v;
  + Lr7/w;
  + Lr7/x;
  + Lr7/y;
  + Lr7/z;
  + Lr8/a0;
  + Lr8/b0;
  + Lr8/c0;
  + Lr8/d0;
  + Lr8/e0;
  + Lr8/o;
  + Lr8/p;
  + Lr8/q;
  + Lr8/r;
  + Lr8/s;
  + Lr8/t;
  + Lr8/u;
  + Lr8/v;
  + Lr8/w;
  + Lr8/x;
  + Lr8/y;
  + Lr8/z;
  + Ls7/b;
  + Ls7/c;
  + Ls7/d;
  + Ls7/e;
  + Ls7/f;
  + Ls7/g;
  + Ls7/h;
  + Ls7/i;
  + Ls8/e;
  + Lu5/m;
  + Lv7/b;
  + Lv7/c;
  + Lv7/d;
  + Lv7/e;
  + Lv7/f;
  + Lv7/g;
  + Lv7/h;
  + Lv7/i;
  + Lv7/j;
  + Lv7/k;
  + Lv7/l;
  + Lv7/m;
  + Lv7/n;
  + Lv7/o;
  + Lv7/p;
  + Lv7/q;
  + Lv7/r;
  + Lv7/s;
  + Lv7/t;
  + Lv7/u;
  + Lv8/a0;
  + Lv8/a1;
  + Lv8/b0;
  + Lv8/b1;
  + Lv8/c0;
  + Lv8/c1;
  + Lv8/d0;
  + Lv8/d1;
  + Lv8/e0;
  + Lv8/e1;
  + Lv8/f0;
  + Lv8/f1;
  + Lv8/g0;
  + Lv8/g1;
  + Lv8/h0;
  + Lv8/h1;
  + Lv8/i0;
  + Lv8/i1;
  + Lv8/j0;
  + Lv8/j1;
  + Lv8/k0;
  + Lv8/k1;
  + Lv8/l0;
  + Lv8/l1;
  + Lv8/m0;
  + Lv8/m1;
  + Lv8/n0;
  + Lv8/n1;
  + Lv8/o0;
  + Lv8/p0;
  + Lv8/q0;
  + Lv8/r0;
  + Lv8/s0;
  + Lv8/t0;
  + Lv8/u0;
  + Lv8/v0;
  + Lv8/w0;
  + Lv8/x0;
  + Lv8/y0;
  + Lv8/z0;
  + Lv8/z;
  + Lw7/k;
  + Lw7/l;
  + Lw7/m;
  + Lw7/n;
  + Lw7/o;
  + Lw7/p;
  + Lw7/q;
  + Lw7/r;
  + Lw7/s;
  + Lw7/t;
  + Lw7/u;
  + Lw7/v;
  + Lw8/a0;
  + Lw8/b0;
  + Lw8/c0;
  + Lw8/c;
  + Lw8/d;
  + Lw8/e;
  + Lw8/f;
  + Lw8/g;
  + Lw8/h;
  + Lw8/i;
  + Lw8/j;
  + Lw8/k;
  + Lw8/l;
  + Lw8/m;
  + Lw8/n;
  + Lw8/o;
  + Lw8/p;
  + Lw8/q;
  + Lw8/r;
  + Lw8/s;
  + Lw8/t;
  + Lw8/u;
  + Lw8/v;
  + Lw8/w;
  + Lw8/x;
  + Lw8/y;
  + Lw8/z;
  + Lx8/b;
  + Lx8/c;
  + Lx8/d;
  + Lx8/e;
  + Lx8/f;
  + Lx8/g;
  + Lx8/h;
  + Lx8/i;
  + Lx8/j;
  + Lx8/k;
  + Lx8/l;
  + Lx8/m;
  + Lx8/n;
  + Lx8/o;
  + Lx8/p;
  + Lx8/q;
  + Lx8/r;
  + Lx8/s;
  + Lx8/t;
  + Lx8/u;
  + Lx8/v;
  + Lx8/w;
  + Lx8/x;
  + Lx8/y;
  + Ly7/i;
  + Ly7/j;
  + Ly8/b;
  + Ly8/c;
  + M2
  + M3
  + N2
  + N3
  + O2
  + O3
  + P2
  + Q2
  + R2
  + S2
  + Should not access delegate after delegate has been closed.
  + Should not access delegate before interpreter has been 
...✂

Base automatically changed from ccen/tflite to master March 17, 2023 00:50
@ccen-stripe ccen-stripe force-pushed the ccen/identityMlCore branch from 2dbf991 to 3f5a620 Compare March 17, 2023 00:53
awush-stripe
awush-stripe previously approved these changes Mar 17, 2023
@ccen-stripe ccen-stripe enabled auto-merge (squash) March 17, 2023 18:06
@ccen-stripe ccen-stripe merged commit 3f15146 into master Mar 20, 2023
@ccen-stripe ccen-stripe deleted the ccen/identityMlCore branch March 20, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants