[stripecardscan] Use ml-core for CardScan
#6409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccen-stripe
requested review from
tillh-stripe and
awush-stripe
and removed request for
tillh-stripe
ccen-stripe
commented
Mar 22, 2023
| import java.io.Closeable | ||
| import java.nio.ByteBuffer | ||
|
|
||
| /** | ||
| * A TensorFlowLite analyzer uses an [Interpreter] to analyze data. | ||
| */ | ||
| internal abstract class TensorFlowLiteAnalyzer<Input, MLInput, Output, MLOutput>( | ||
| private val tfInterpreter: Interpreter, | ||
| private val delegate: NnApiDelegate? = null |
There was a problem hiding this comment.
this is removed as it's never set
awush-stripe
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replace the dependency to
ml-core:cardscanby default and document the option to swap with google play.Motivation
Use TFLite in Google play
Testing
ScanActivityandScanFragmentwithml-core:cardscanScanActivityandScanFragmentwithml-core:googleplayScreenshots
Changelog