-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add remember
methods for PaymentSheet
integration in Compose
#6583
Merged
tillh-stripe
merged 4 commits into
master
from
tillh/paymentsheet-in-compose-improvements
Jun 26, 2023
Merged
Add remember
methods for PaymentSheet
integration in Compose
#6583
tillh-stripe
merged 4 commits into
master
from
tillh/paymentsheet-in-compose-improvements
Jun 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
tillh-stripe
force-pushed
the
tillh/paymentsheet-in-compose-improvements
branch
7 times, most recently
from
April 20, 2023 21:42
16f2d0b
to
f7e25b1
Compare
Diffuse output:
APK
DEX
|
tillh-stripe
force-pushed
the
tillh/paymentsheet-in-compose-improvements
branch
from
April 21, 2023 13:22
f7e25b1
to
e7bfe32
Compare
tillh-stripe
force-pushed
the
tillh/paymentsheet-in-compose-improvements
branch
3 times, most recently
from
June 15, 2023 13:44
eddc288
to
6b20df7
Compare
tillh-stripe
commented
Jun 15, 2023
Comment on lines
-6
to
-8
internal class PaymentSheetActivityStarter internal constructor( | ||
activity: Activity | ||
) : ActivityStarter<PaymentSheetActivity, PaymentSheetContract.Args>( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unused.
tillh-stripe
force-pushed
the
tillh/paymentsheet-in-compose-improvements
branch
3 times, most recently
from
June 15, 2023 14:27
444696b
to
5455655
Compare
3 tasks
tillh-stripe
requested review from
ccen-stripe,
jameswoo-stripe and
jaynewstrom-stripe
and removed request for
ccen-stripe
June 15, 2023 14:42
paymentsheet/src/main/java/com/stripe/android/paymentsheet/PaymentSheetCompose.kt
Show resolved
Hide resolved
tillh-stripe
force-pushed
the
tillh/paymentsheet-in-compose-improvements
branch
from
June 16, 2023 19:42
1112999
to
7764b91
Compare
This was referenced Jun 22, 2023
tillh-stripe
force-pushed
the
tillh/paymentsheet-in-compose-improvements
branch
from
June 22, 2023 20:47
51cb4d6
to
bc97a35
Compare
tillh-stripe
force-pushed
the
tillh/paymentsheet-in-compose-improvements
branch
3 times, most recently
from
June 23, 2023 16:55
1cb697a
to
e27d38c
Compare
3 tasks
tillh-stripe
force-pushed
the
tillh/paymentsheet-in-compose-improvements
branch
from
June 26, 2023 15:33
e27d38c
to
a100b95
Compare
jameswoo-stripe
previously approved these changes
Jun 26, 2023
tillh-stripe
force-pushed
the
tillh/paymentsheet-in-compose-improvements
branch
from
June 26, 2023 20:56
a100b95
to
248abf6
Compare
tillh-stripe
force-pushed
the
tillh/paymentsheet-in-compose-improvements
branch
from
June 26, 2023 20:57
248abf6
to
5046bea
Compare
jameswoo-stripe
approved these changes
Jun 26, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request makes
PaymentSheet
andPaymentSheet.FlowController
easier to use in Compose. Instead of creating these instances outside of the Compose scope, you can now use remember methods.As a consequence, we’re deprecating
PaymentSheetContract
and itsArgs
class. These classes will eventually be restricted to internal visibility.Motivation
MOBILE_APIREVIEW-35
Testing
Screenshots
Changelog
[ADDED] Added dedicated remember methods for
PaymentSheet
andPaymentSheet.FlowController
for easier integration in Compose.[DEPRECATED] Deprecated
PaymentSheetContract
andPaymentSheetContract.Args
. Use thePaymentSheet
constructor or newrememberPaymentSheet
method instead.