Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an issue where google places caused errors with R8. #6736

Merged
merged 2 commits into from
May 18, 2023

Conversation

jaynewstrom-stripe
Copy link
Collaborator

Summary

The R class is not in the API package, which caused errors with R8.

Motivation

#6735

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before After
before screenshot after screenshot

Changelog

@jaynewstrom-stripe jaynewstrom-stripe force-pushed the jaynewstrom/places-r8-fix branch from b51cef1 to ba06c45 Compare May 18, 2023 16:00
@jaynewstrom-stripe jaynewstrom-stripe marked this pull request as ready for review May 18, 2023 16:00
@jaynewstrom-stripe jaynewstrom-stripe requested review from a team as code owners May 18, 2023 16:00
CHANGELOG.md Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented May 18, 2023

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │   3.4 MiB │   3.4 MiB │  0 B │   7.4 MiB │   7.4 MiB │  0 B 
     arsc │   2.1 MiB │   2.1 MiB │  0 B │   2.1 MiB │   2.1 MiB │  0 B 
 manifest │   4.6 KiB │   4.6 KiB │  0 B │  22.3 KiB │  22.3 KiB │  0 B 
      res │   869 KiB │   869 KiB │  0 B │   1.3 MiB │   1.3 MiB │  0 B 
   native │   2.6 MiB │   2.6 MiB │  0 B │     6 MiB │     6 MiB │  0 B 
    asset │     3 MiB │     3 MiB │  0 B │     3 MiB │     3 MiB │  0 B 
    other │ 199.6 KiB │ 199.6 KiB │  0 B │ 446.8 KiB │ 446.8 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │  12.1 MiB │  12.1 MiB │  0 B │  20.3 MiB │  20.3 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 36245 │ 36245 │ 0 (+0 -0) 
   types │ 12048 │ 12048 │ 0 (+0 -0) 
 classes │ 10148 │ 10148 │ 0 (+0 -0) 
 methods │ 53663 │ 53663 │ 0 (+0 -0) 
  fields │ 34121 │ 34121 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  291 │  291 │  0   
 entries │ 6940 │ 6940 │  0

Co-authored-by: Till Hellmund <tillh@stripe.com>
@jaynewstrom-stripe jaynewstrom-stripe merged commit 72d3378 into master May 18, 2023
@jaynewstrom-stripe jaynewstrom-stripe deleted the jaynewstrom/places-r8-fix branch May 18, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants