Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CameraX in CIV #7057

Merged
merged 2 commits into from
Jul 21, 2023
Merged

Use CameraX in CIV #7057

merged 2 commits into from
Jul 21, 2023

Conversation

awush-stripe
Copy link
Collaborator

Summary

Swap CIV to use CameraX by default with a fallback to Camera1

Motivation

Camera1 is causing an intermittent crash in DD

Testing

  • Added tests
  • Modified tests
  • Manually verified

Changelog

@awush-stripe awush-stripe requested review from a team as code owners July 21, 2023 20:23
@emerge-tools
Copy link

emerge-tools bot commented Jul 21, 2023

1 build increased size

Name Version Download Change Install Change
PaymentSheet Example 20.27.2 (11) 8.0 MB ⬆️ 144.9 kB (1.84%) 15.0 MB ⬆️ 292.5 kB (1.99%)

PaymentSheet Example 20.27.2 (11)

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬆️ 292.5 kB (1.99%)
Total download size change: ⬆️ 144.9 kB (1.84%)

Largest size changes

Item Install Size Change Download Size Change
androidx.camera.core classes ⬆️ 110.2 kB ⬆️ 50.1 kB
📝 androidx.camera.camera2.internal classes ⬆️ 104.5 kB ⬆️ 47.5 kB
com.stripe.android.stripecardscan.framework classes ⬆️ 68.4 kB ⬆️ 31.1 kB
key ⬇️ -68.7 kB ⬇️ -31.0 kB
elements ⬇️ -67.3 kB ⬇️ -30.4 kB

Image of diff


🛸 Powered by Emerge Tools

@awush-stripe awush-stripe merged commit 827c1a7 into master Jul 21, 2023
@awush-stripe awush-stripe deleted the awush/use_cameraX_in_civ branch July 21, 2023 21:21
fionnbarrett-stripe pushed a commit that referenced this pull request Aug 17, 2023
* Use CameraX in CIV

* Add changelog entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants