-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for FPX #7214
Add support for FPX #7214
Conversation
5502f9b
to
816d8d2
Compare
Diffuse output:
APK
DEX
ARSC
|
@@ -841,8 +841,116 @@ | |||
"async": false, | |||
"fields": [], | |||
"selector_icon": { | |||
"light_theme_png": "https://js.stripe.com/v3/fingerprinted/img/payment-methods/icon-pm-grabpay@3x-e54da1d788668a5909e4801d5c243198.png", | |||
"light_theme_svg": "https://js.stripe.com/v3/fingerprinted/img/payment-methods/icon-pm-grabpay-97ee78fdbbf1890bdf19986e997e685d.svg" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the SVG because we don’t use them.
"ios": key_object[:key_name], | ||
"web": key_object[:key_name], | ||
"other": key_object[:key_name], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missed this in the initial Lokalise work: When we create a new key, Lokalise seems to expect values for all platforms.
1ccff4f
to
2cd6811
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
d654724
5e548b3
d654724
to
5e548b3
Compare
Summary
This pull request adds support for FPX in PaymentSheet.
Motivation
Catching up with iOS 🥵
Testing
Screen recording
Recording
fpx.mp4
Changelog
[ADDED] PaymentSheet now supports FPX for PaymentIntents.