Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for FPX #7214

Merged
merged 7 commits into from
Aug 28, 2023
Merged

Add support for FPX #7214

merged 7 commits into from
Aug 28, 2023

Conversation

tillh-stripe
Copy link
Collaborator

@tillh-stripe tillh-stripe commented Aug 28, 2023

Summary

This pull request adds support for FPX in PaymentSheet.

Motivation

Catching up with iOS 🥵

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screen recording

Recording

fpx.mp4

Changelog

[ADDED] PaymentSheet now supports FPX for PaymentIntents.

@tillh-stripe tillh-stripe force-pushed the tillh/fpx-paymentsheet branch from 5502f9b to 816d8d2 Compare August 28, 2023 13:21
@github-actions
Copy link
Contributor

github-actions bot commented Aug 28, 2023

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │            compressed            │          uncompressed           
          ├───────────┬───────────┬──────────┼───────────┬──────────┬──────────
 APK      │ old       │ new       │ diff     │ old       │ new      │ diff     
──────────┼───────────┼───────────┼──────────┼───────────┼──────────┼──────────
      dex │   3.5 MiB │   3.5 MiB │   +152 B │   7.8 MiB │  7.8 MiB │   +272 B 
     arsc │   2.1 MiB │   2.1 MiB │   +700 B │   2.1 MiB │  2.1 MiB │   +700 B 
 manifest │   4.9 KiB │   4.9 KiB │      0 B │  24.1 KiB │ 24.1 KiB │      0 B 
      res │ 876.3 KiB │ 877.3 KiB │   +986 B │   1.3 MiB │  1.3 MiB │ +1.9 KiB 
   native │   2.6 MiB │   2.6 MiB │      0 B │     6 MiB │    6 MiB │      0 B 
    asset │     3 MiB │     3 MiB │   +250 B │     3 MiB │    3 MiB │ +2.5 KiB 
    other │ 199.7 KiB │ 199.8 KiB │    +81 B │ 446.8 KiB │  447 KiB │   +164 B 
──────────┼───────────┼───────────┼──────────┼───────────┼──────────┼──────────
    total │  12.3 MiB │  12.3 MiB │ +2.1 KiB │  20.7 MiB │ 20.7 MiB │ +5.5 KiB 

 DEX     │ old   │ new   │ diff       
─────────┼───────┼───────┼────────────
   files │     1 │     1 │  0         
 strings │ 38304 │ 38307 │ +3 (+4 -1) 
   types │ 12657 │ 12657 │  0 (+0 -0) 
 classes │ 10681 │ 10681 │  0 (+0 -0) 
 methods │ 56087 │ 56087 │  0 (+0 -0) 
  fields │ 35173 │ 35174 │ +1 (+1 -0) 

 ARSC    │ old  │ new  │ diff       
─────────┼──────┼──────┼────────────
 configs │  290 │  290 │  0         
 entries │ 6925 │ 6927 │ +2 (+2 -0)
APK
     compressed      │     uncompressed     │                               
──────────┬──────────┼───────────┬──────────┤                               
 size     │ diff     │ size      │ diff     │ path                          
──────────┼──────────┼───────────┼──────────┼───────────────────────────────
    981 B │   +981 B │   1.9 KiB │ +1.9 KiB │ + res/lF.xml                  
  2.1 MiB │   +700 B │   2.1 MiB │   +700 B │ ∆ resources.arsc              
  2.7 KiB │   +251 B │  21.7 KiB │ +2.5 KiB │ ∆ assets/lpms.json            
  3.5 MiB │   +152 B │   7.8 MiB │   +272 B │ ∆ classes.dex                 
 62.7 KiB │    +45 B │ 140.9 KiB │    +82 B │ ∆ META-INF/CERT.SF            
 48.5 KiB │    +36 B │ 140.9 KiB │    +82 B │ ∆ META-INF/MANIFEST.MF        
  1,000 B │     +4 B │   2.8 KiB │      0 B │ ∆ res/XB.xml                  
  6.4 KiB │     -1 B │   6.2 KiB │     -1 B │ ∆ assets/dexopt/baseline.prof 
    880 B │     +1 B │   2.3 KiB │      0 B │ ∆ res/6i.xml                  
──────────┼──────────┼───────────┼──────────┼───────────────────────────────
  5.8 MiB │ +2.1 KiB │  10.2 MiB │ +5.5 KiB │ (total)
DEX
STRINGS:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   38304 │ 38307 │ +3 (+4 -1) 
  + FpxBank
  + MYR
  + upe.labels.fpx.bank
  + ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:b2e23df,r8-mode:full,version:8.0.46}
  
  - ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:52ee250,r8-mode:full,version:8.0.46}
  

FIELDS:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   35173 │ 35174 │ +1 (+1 -0) 
  + ne.a0 v: z
ARSC
ENTRIES:

   old  │ new  │ diff       
  ──────┼──────┼────────────
   6925 │ 6927 │ +2 (+2 -0) 
  + drawable/stripe_ic_paymentsheet_pm_fpx
  + string/stripe_paymentsheet_payment_method_fpx

@@ -841,8 +841,116 @@
"async": false,
"fields": [],
"selector_icon": {
"light_theme_png": "https://js.stripe.com/v3/fingerprinted/img/payment-methods/icon-pm-grabpay@3x-e54da1d788668a5909e4801d5c243198.png",
"light_theme_svg": "https://js.stripe.com/v3/fingerprinted/img/payment-methods/icon-pm-grabpay-97ee78fdbbf1890bdf19986e997e685d.svg"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the SVG because we don’t use them.

Comment on lines +34 to +36
"ios": key_object[:key_name],
"web": key_object[:key_name],
"other": key_object[:key_name],
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed this in the initial Lokalise work: When we create a new key, Lokalise seems to expect values for all platforms.

@tillh-stripe tillh-stripe force-pushed the tillh/fpx-paymentsheet branch from 1ccff4f to 2cd6811 Compare August 28, 2023 15:39
@tillh-stripe tillh-stripe marked this pull request as ready for review August 28, 2023 15:40
@tillh-stripe tillh-stripe requested review from a team as code owners August 28, 2023 15:40
Copy link
Collaborator

@jaynewstrom-stripe jaynewstrom-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

samer-stripe
samer-stripe previously approved these changes Aug 28, 2023
samer-stripe
samer-stripe previously approved these changes Aug 28, 2023
@tillh-stripe tillh-stripe merged commit 20d3ad2 into master Aug 28, 2023
@tillh-stripe tillh-stripe deleted the tillh/fpx-paymentsheet branch August 28, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants