Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ideal with Setup Intent and Payment Intent with setup future usage. #7269

Merged
merged 3 commits into from
Sep 6, 2023

Conversation

jaynewstrom-stripe
Copy link
Collaborator

@jaynewstrom-stripe jaynewstrom-stripe commented Sep 6, 2023

Motivation

LPM Sprint - Add more LPM support to PS.

Testing

  • Added tests
  • Modified tests
  • Manually verified

Changelog

[ADDED] PaymentSheet now supports Ideal with SetupIntent and PaymentIntent with setup for future usage.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │           compressed           │          uncompressed          
          ├───────────┬───────────┬────────┼───────────┬───────────┬────────
 APK      │ old       │ new       │ diff   │ old       │ new       │ diff   
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼────────
      dex │   3.5 MiB │   3.5 MiB │ -173 B │   7.8 MiB │   7.8 MiB │ +100 B 
     arsc │   2.1 MiB │   2.1 MiB │    0 B │   2.1 MiB │   2.1 MiB │    0 B 
 manifest │   4.9 KiB │   4.9 KiB │    0 B │  24.1 KiB │  24.1 KiB │    0 B 
      res │ 878.8 KiB │ 878.8 KiB │    0 B │   1.4 MiB │   1.4 MiB │    0 B 
   native │   2.6 MiB │   2.6 MiB │    0 B │     6 MiB │     6 MiB │    0 B 
    asset │     3 MiB │     3 MiB │   -1 B │     3 MiB │     3 MiB │   -1 B 
    other │   200 KiB │   200 KiB │   -2 B │ 447.5 KiB │ 447.5 KiB │    0 B 
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼────────
    total │  12.3 MiB │  12.3 MiB │ -176 B │  20.7 MiB │  20.7 MiB │  +99 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 38370 │ 38370 │ 0 (+0 -0) 
   types │ 12687 │ 12687 │ 0 (+0 -0) 
 classes │ 10710 │ 10710 │ 0 (+0 -0) 
 methods │ 56194 │ 56194 │ 0 (+0 -0) 
  fields │ 35246 │ 35246 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  290 │  290 │  0   
 entries │ 6932 │ 6932 │  0
APK
    compressed     │    uncompressed    │                               
──────────┬────────┼───────────┬────────┤                               
 size     │ diff   │ size      │ diff   │ path                          
──────────┼────────┼───────────┼────────┼───────────────────────────────
  3.5 MiB │ -173 B │   7.8 MiB │ +100 B │ ∆ classes.dex                 
 62.8 KiB │   -2 B │ 141.2 KiB │    0 B │ ∆ META-INF/CERT.SF            
  6.3 KiB │   -1 B │   6.2 KiB │   -1 B │ ∆ assets/dexopt/baseline.prof 
  1.2 KiB │   +1 B │   1.2 KiB │    0 B │ ∆ META-INF/CERT.RSA           
 48.6 KiB │   -1 B │ 141.1 KiB │    0 B │ ∆ META-INF/MANIFEST.MF        
──────────┼────────┼───────────┼────────┼───────────────────────────────
  3.7 MiB │ -176 B │   8.1 MiB │  +99 B │ (total)

@jaynewstrom-stripe jaynewstrom-stripe marked this pull request as ready for review September 6, 2023 14:08
@jaynewstrom-stripe jaynewstrom-stripe requested review from a team as code owners September 6, 2023 14:08
SupportedPaymentMethod(
code = "ideal",
requiresMandate = true,
mandateRequirement = MandateRequirement.Always,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t think we ever started using this 🙈 I can remove it in a separate pull request.

@jaynewstrom-stripe jaynewstrom-stripe merged commit fabee30 into master Sep 6, 2023
@jaynewstrom-stripe jaynewstrom-stripe deleted the jaynewstrom/ideal-si-piwsfu branch September 6, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants