Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for OXXO #7281

Merged
merged 9 commits into from
Sep 12, 2023
Merged

Add support for OXXO #7281

merged 9 commits into from
Sep 12, 2023

Conversation

eurias-stripe
Copy link
Contributor

Summary

Add support for OXX

Motivation

LPM Sprint

Testing

  • Added tests
  • Manually verified

Screencast

oxxo_android.mp4

Changelog

  • [ADDED] PaymentSheet now supports the following payment methods for PaymentIntents:
    • OXXO

page.waitForText("OXXO")
page.clickViewWithText("OXXO")

// Only testing that the buy button is disabled initially and enabled after entering
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │            compressed            │           uncompressed           
          ├───────────┬───────────┬──────────┼───────────┬───────────┬──────────
 APK      │ old       │ new       │ diff     │ old       │ new       │ diff     
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
      dex │   3.5 MiB │   3.5 MiB │    +46 B │   7.8 MiB │   7.8 MiB │   +168 B 
     arsc │   2.2 MiB │   2.2 MiB │   +716 B │   2.2 MiB │   2.2 MiB │   +716 B 
 manifest │   4.9 KiB │   4.9 KiB │      0 B │  24.1 KiB │  24.1 KiB │      0 B 
      res │ 879.5 KiB │ 880.5 KiB │   +1 KiB │   1.4 MiB │   1.4 MiB │ +2.2 KiB 
   native │   2.6 MiB │   2.6 MiB │      0 B │     6 MiB │     6 MiB │      0 B 
    asset │     3 MiB │     3 MiB │    +18 B │     3 MiB │     3 MiB │   +297 B 
    other │ 200.1 KiB │ 200.2 KiB │    +94 B │ 447.6 KiB │ 447.8 KiB │   +164 B 
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
    total │  12.3 MiB │  12.3 MiB │ +1.9 KiB │  20.7 MiB │  20.7 MiB │ +3.5 KiB 

 DEX     │ old   │ new   │ diff       
─────────┼───────┼───────┼────────────
   files │     1 │     1 │  0         
 strings │ 38318 │ 38319 │ +1 (+2 -1) 
   types │ 12686 │ 12686 │  0 (+0 -0) 
 classes │ 10711 │ 10711 │  0 (+0 -0) 
 methods │ 56199 │ 56199 │  0 (+0 -0) 
  fields │ 35265 │ 35266 │ +1 (+1 -0) 

 ARSC    │ old  │ new  │ diff       
─────────┼──────┼──────┼────────────
 configs │  290 │  290 │  0         
 entries │ 6941 │ 6943 │ +2 (+2 -0)
APK
     compressed      │     uncompressed     │                        
──────────┬──────────┼───────────┬──────────┤                        
 size     │ diff     │ size      │ diff     │ path                   
──────────┼──────────┼───────────┼──────────┼────────────────────────
    1 KiB │   +1 KiB │   2.2 KiB │ +2.2 KiB │ + res/0Q.xml           
  2.2 MiB │   +716 B │   2.2 MiB │   +716 B │ ∆ resources.arsc       
 62.9 KiB │    +48 B │ 141.3 KiB │    +82 B │ ∆ META-INF/CERT.SF     
  3.5 MiB │    +46 B │   7.8 MiB │   +168 B │ ∆ classes.dex          
 48.7 KiB │    +46 B │ 141.3 KiB │    +82 B │ ∆ META-INF/MANIFEST.MF 
  2.7 KiB │    +18 B │  22.7 KiB │   +297 B │ ∆ assets/lpms.json     
  1,002 B │     +4 B │   2.8 KiB │      0 B │ ∆ res/XB.xml           
    876 B │     -1 B │   2.3 KiB │      0 B │ ∆ res/6i.xml           
    950 B │     +1 B │   2.5 KiB │      0 B │ ∆ res/9N.xml           
    489 B │     -1 B │     836 B │      0 B │ ∆ res/UZ.xml           
    850 B │     +1 B │   1.8 KiB │      0 B │ ∆ res/lK.xml           
──────────┼──────────┼───────────┼──────────┼────────────────────────
  5.8 MiB │ +1.9 KiB │  10.2 MiB │ +3.5 KiB │ (total)
DEX
STRINGS:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   38318 │ 38319 │ +1 (+2 -1) 
  + MXN
  + ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:d53acea,r8-mode:full,version:8.0.46}
  
  - ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:ec53e6d,r8-mode:full,version:8.0.46}
  

FIELDS:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   35265 │ 35266 │ +1 (+1 -0) 
  + oe.v y: u
ARSC
ENTRIES:

   old  │ new  │ diff       
  ──────┼──────┼────────────
   6941 │ 6943 │ +2 (+2 -0) 
  + drawable/stripe_ic_paymentsheet_pm_oxxo
  + string/stripe_paymentsheet_payment_method_oxxo

@eurias-stripe eurias-stripe marked this pull request as draft September 11, 2023 16:37
Copy link
Collaborator

@jaynewstrom-stripe jaynewstrom-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you need to copy/pastes affirm-support.csv to oxxo-support.csv (and update it) to make the tests pass.

samer-stripe
samer-stripe previously approved these changes Sep 11, 2023
Copy link
Collaborator

@jaynewstrom-stripe jaynewstrom-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eurias-stripe looks like a rebase went bad or something.

Copy link
Collaborator

@jaynewstrom-stripe jaynewstrom-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit, but otherwise looks good.

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@jaynewstrom-stripe jaynewstrom-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eurias-stripe now that we're in the middle of release, you'll need to rebase and update the changelog to be the new version.

CHANGELOG.md Outdated
@@ -2,13 +2,16 @@

## XX.XX.XX - 2023-XX-XX

## 20.30.0 - 2023-09-11
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you killed a release :O

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh, me dumb. sorry

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But looks like the rebase wasn't done, since there was also a 20.30.1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had killed a release lol, I don't know why the first rebase I did didn't bring that change, I had to rebase again.

@eurias-stripe eurias-stripe merged commit ba0dc12 into master Sep 12, 2023
@eurias-stripe eurias-stripe deleted the eurias/oxxo branch September 12, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants