-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for OXXO #7281
Add support for OXXO #7281
Conversation
...ain/java/com/stripe/android/paymentsheet/example/playground/model/PlaygroundCheckoutModel.kt
Outdated
Show resolved
Hide resolved
page.waitForText("OXXO") | ||
page.clickViewWithText("OXXO") | ||
|
||
// Only testing that the buy button is disabled initially and enabled after entering |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could possibly use espresso intents to test that the webview is "launched"?
https://developer.android.com/training/testing/espresso/intents
Diffuse output:
APK
DEX
ARSC
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you need to copy/pastes affirm-support.csv
to oxxo-support.csv
(and update it) to make the tests pass.
paymentsheet/src/androidTest/resources/elements-sessions-mx-requires_payment_method.json
Outdated
Show resolved
Hide resolved
* Fix sepa payment methods form ui
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eurias-stripe looks like a rebase went bad or something.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small nit, but otherwise looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eurias-stripe now that we're in the middle of release, you'll need to rebase and update the changelog to be the new version.
CHANGELOG.md
Outdated
@@ -2,13 +2,16 @@ | |||
|
|||
## XX.XX.XX - 2023-XX-XX | |||
|
|||
## 20.30.0 - 2023-09-11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you killed a release :O
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohh, me dumb. sorry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But looks like the rebase wasn't done, since there was also a 20.30.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had killed a release lol, I don't know why the first rebase I did didn't bring that change, I had to rebase again.
Summary
Add support for OXX
Motivation
LPM Sprint
Testing
Screencast
oxxo_android.mp4
Changelog