-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Identity] Butter M1 UX tweaks #7638
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccen-stripe
requested review from
carlosmuvi-stripe
and removed request for
a team
November 16, 2023 03:44
@stripe/stripe-identity-observers |
ccen-stripe
force-pushed
the
ccen/butter2
branch
from
November 16, 2023 03:45
67f57fc
to
611a87c
Compare
ccen-stripe
force-pushed
the
ccen/butter2Ux
branch
from
November 16, 2023 03:45
eaf9a70
to
a20515e
Compare
Diffuse output:
APK
DEX
ARSC
|
@ccen-stripe I noticed that the Agree and Decline buttons are treated the same way (both primary buttons). Is that intentional? |
No, updated decline button to secondary |
carlosmuvi-stripe
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
UX teaks for butter M1
iOS: stripe/stripe-ios#3070
Motivation
UX tweaks
Testing
Screenshots
Changelog