Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Identity] Butter M1 UX tweaks #7638

Merged
merged 4 commits into from
Nov 16, 2023
Merged

[Identity] Butter M1 UX tweaks #7638

merged 4 commits into from
Nov 16, 2023

Conversation

ccen-stripe
Copy link
Contributor

@ccen-stripe ccen-stripe commented Nov 16, 2023

Summary

UX teaks for butter M1

  • consent
    • text/link color changed
    • vertical padding added
    • plus icon replaced by ellipsis icon
  • bottomsheet
    • subtitle color, content color, content line spacing
    • fixed bullet points padding
  • docwarmup
    • removed instructions box, instead built a string
      • note we didn't add the "and" there, since this would make translations hard, as we are hardcoding "accepted forms of ID" from client, but getting the actual ID names from server.
    • moved instructions to top of button.
  • docwarmup
    • title font - increased size
    • removed instructions box, instead built a string
      • note we didn't add the "and" there, since this would make translations hard, as we are hardcoding "accepted forms of ID" from client, but getting the actual ID names from server.
    • moved instructions to top of button.

iOS: stripe/stripe-ios#3070

Motivation

UX tweaks

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before After
androidBefore androidAfter

Changelog

@ccen-stripe ccen-stripe requested review from a team as code owners November 16, 2023 03:44
@ccen-stripe ccen-stripe requested review from carlosmuvi-stripe and removed request for a team November 16, 2023 03:44
@ccen-stripe
Copy link
Contributor Author

@stripe/stripe-identity-observers

Copy link
Contributor

github-actions bot commented Nov 16, 2023

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │            compressed            │           uncompressed           
          ├───────────┬───────────┬──────────┼───────────┬───────────┬──────────
 APK      │ old       │ new       │ diff     │ old       │ new       │ diff     
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
      dex │   1.9 MiB │   1.9 MiB │   +535 B │     4 MiB │     4 MiB │   +356 B 
     arsc │   1.4 MiB │   1.4 MiB │ +1.6 KiB │   1.4 MiB │   1.4 MiB │ +1.6 KiB 
 manifest │   2.3 KiB │   2.3 KiB │      0 B │   8.1 KiB │   8.1 KiB │      0 B 
      res │   353 KiB │ 353.2 KiB │   +213 B │ 484.8 KiB │ 485.2 KiB │   +404 B 
   native │   6.2 MiB │   6.2 MiB │      0 B │  15.8 MiB │  15.8 MiB │      0 B 
    asset │  67.4 KiB │  67.4 KiB │    -10 B │  87.4 KiB │  87.4 KiB │    -10 B 
    other │ 113.3 KiB │ 113.4 KiB │    +48 B │   261 KiB │ 261.2 KiB │   +164 B 
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
    total │    10 MiB │    10 MiB │ +2.4 KiB │  21.9 MiB │    22 MiB │ +2.5 KiB 

 DEX     │ old   │ new   │ diff       
─────────┼───────┼───────┼────────────
   files │     1 │     1 │  0         
 strings │ 20042 │ 20045 │ +3 (+7 -4) 
   types │  6156 │  6156 │  0 (+0 -0) 
 classes │  5010 │  5010 │  0 (+0 -0) 
 methods │ 30418 │ 30419 │ +1 (+8 -7) 
  fields │ 17231 │ 17231 │  0 (+3 -3) 

 ARSC    │ old  │ new  │ diff       
─────────┼──────┼──────┼────────────
 configs │  261 │  261 │  0         
 entries │ 5185 │ 5190 │ +5 (+5 -0)
APK
     compressed      │     uncompressed     │                                             
──────────┬──────────┼───────────┬──────────┤                                             
 size     │ diff     │ size      │ diff     │ path                                        
──────────┼──────────┼───────────┼──────────┼─────────────────────────────────────────────
  1.4 MiB │ +1.6 KiB │   1.4 MiB │ +1.6 KiB │ ∆ resources.arsc                            
  1.9 MiB │   +535 B │     4 MiB │   +356 B │ ∆ classes.dex                               
    477 B │   +477 B │     876 B │   +876 B │ + res/r4.xml                                
    150 B │   -262 B │     112 B │   -472 B │ ∆ res/XY.xml                                
 49.7 KiB │    +44 B │ 113.5 KiB │    +82 B │ ∆ META-INF/CERT.SF                          
  5.7 KiB │    -10 B │   5.5 KiB │    -10 B │ ∆ assets/dexopt/baseline.prof               
 31.4 KiB │     +4 B │ 113.4 KiB │    +82 B │ ∆ META-INF/MANIFEST.MF                      
    505 B │     +1 B │     916 B │      0 B │ ∆ res/-o.xml                                
    321 B │     -1 B │     484 B │      0 B │ ∆ res/NM.xml                                
    387 B │     -1 B │     464 B │      0 B │ ∆ res/color/switch_thumb_material_light.xml 
    830 B │     -1 B │   1.9 KiB │      0 B │ ∆ res/f-.xml                                
──────────┼──────────┼───────────┼──────────┼─────────────────────────────────────────────
  3.4 MiB │ +2.4 KiB │   5.6 MiB │ +2.5 KiB │ (total)
DEX
STRINGS:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   20042 │ 20045 │ +3 (+7 -4) 
  + <li>(.*?)</li>
  + <ul><li>Drivers license</li><li>Passport</li><li>National ID</li><li>Valid government-issued identification that clearly shows your face</li><ul>
  + Drivers license cloud line content with another <a href='https://stripe.com'>link</a>, with multiline content
  + Trailing(idRes=2131165428, contentDescription=
  + ^<ul>.*</ul>_
  + bullets line
  + ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:4c99e69,r8-mode:full,version:8.1.65}
  
  - _this_border
  - Trailing(idRes=2131165427, contentDescription=
  - cloud line content with another <a href='https://stripe.com'>link</a>, with multiline content
  - ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:7cb4b70,r8-mode:full,version:8.1.65}
  

METHODS:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   30418 │ 30419 │ +1 (+8 -7) 
  + androidx.compose.foundation.a e(w, i0) → l
  + androidx.compose.foundation.a f(long, x0)
  + androidx.compose.foundation.a g(l, m, i1, boolean, String, g, a) → l
  + androidx.compose.foundation.a h(l, m, e, boolean, g, a, int) → l
  + androidx.compose.foundation.a i(l, boolean, String, a, int) → l
  + androidx.compose.foundation.a j(i) → t2
  + androidx.compose.foundation.a k(float, long) → long
  + androidx.compose.foundation.a l(l, t2) → l
  
  - androidx.compose.foundation.a e(long, x0)
  - androidx.compose.foundation.a f(l, m, i1, boolean, String, g, a) → l
  - androidx.compose.foundation.a g(l, m, e, boolean, g, a, int) → l
  - androidx.compose.foundation.a h(l, boolean, String, a, int) → l
  - androidx.compose.foundation.a i(i) → t2
  - androidx.compose.foundation.a j(float, long) → long
  - androidx.compose.foundation.a k(l, t2) → l
  

FIELDS:

   old   │ new   │ diff      
  ───────┼───────┼───────────
   17231 │ 17231 │ 0 (+3 -3) 
  + i7.b1 L: b1
  + i7.b1 M: b1[]
  + u1.q i: int
  
  - i7.b1 L: b1[]
  - u1.q i: long
  - u1.q j: int
ARSC
ENTRIES:

   old  │ new  │ diff       
  ──────┼──────┼────────────
   5185 │ 5190 │ +5 (+5 -0) 
  + color/stripe_html_line
  + drawable/stripe_ellipsis_icon
  + string/stripe_accepted_forms_of_id_include
  + string/stripe_description_ellipsis
  + string/stripe_im_ready

@billchung-stripe
Copy link

@ccen-stripe I noticed that the Agree and Decline buttons are treated the same way (both primary buttons). Is that intentional?

@ccen-stripe
Copy link
Contributor Author

@ccen-stripe I noticed that the Agree and Decline buttons are treated the same way (both primary buttons). Is that intentional?

No, updated decline button to secondary

@ccen-stripe ccen-stripe merged commit d8071c6 into ccen/butter2 Nov 16, 2023
11 checks passed
@ccen-stripe ccen-stripe deleted the ccen/butter2Ux branch November 16, 2023 22:37
@ccen-stripe ccen-stripe mentioned this pull request Nov 17, 2023
3 tasks
ccen-stripe added a commit that referenced this pull request Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants