Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PaymentOption.iconPainter for easier Compose integration #7719

Merged
merged 5 commits into from
Mar 5, 2024

Conversation

tillh-stripe
Copy link
Collaborator

@tillh-stripe tillh-stripe commented Dec 12, 2023

Summary

Adds a new public API for easier compose integration.

API Review: https://jira.corp.stripe.com/browse/MOBILE_APIREVIEW-70

@tillh-stripe tillh-stripe force-pushed the tillh/payment-option-icon-painter branch from b7d090f to bbf39f6 Compare January 9, 2024 16:13
@jaynewstrom-stripe jaynewstrom-stripe force-pushed the tillh/payment-option-icon-painter branch from 91bf8e5 to 458546a Compare February 27, 2024 19:54
Copy link
Contributor

github-actions bot commented Feb 27, 2024

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │     2 MiB │     2 MiB │  0 B │   4.1 MiB │   4.1 MiB │  0 B 
     arsc │   1.4 MiB │   1.4 MiB │  0 B │   1.4 MiB │   1.4 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │   8.1 KiB │   8.1 KiB │  0 B 
      res │ 363.2 KiB │ 363.2 KiB │  0 B │ 490.6 KiB │ 490.6 KiB │  0 B 
   native │   6.2 MiB │   6.2 MiB │  0 B │  15.8 MiB │  15.8 MiB │  0 B 
    asset │  67.8 KiB │  67.8 KiB │  0 B │  87.7 KiB │  87.7 KiB │  0 B 
    other │ 114.7 KiB │ 114.7 KiB │ +2 B │ 270.3 KiB │ 270.3 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │  10.2 MiB │  10.2 MiB │ +2 B │  22.2 MiB │  22.2 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 20963 │ 20963 │ 0 (+0 -0) 
   types │  6509 │  6509 │ 0 (+0 -0) 
 classes │  5298 │  5298 │ 0 (+0 -0) 
 methods │ 30646 │ 30646 │ 0 (+0 -0) 
  fields │ 17817 │ 17817 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  262 │  262 │  0   
 entries │ 5504 │ 5504 │  0
APK
   compressed   │  uncompressed  │                     
─────────┬──────┼─────────┬──────┤                     
 size    │ diff │ size    │ diff │ path                
─────────┼──────┼─────────┼──────┼─────────────────────
 1.2 KiB │ +2 B │ 1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA 
─────────┼──────┼─────────┼──────┼─────────────────────
 1.2 KiB │ +2 B │ 1.2 KiB │  0 B │ (total)

@jaynewstrom-stripe jaynewstrom-stripe marked this pull request as ready for review February 27, 2024 21:02
@jaynewstrom-stripe jaynewstrom-stripe requested review from a team as code owners February 27, 2024 21:02
@tillh-stripe tillh-stripe enabled auto-merge (squash) March 5, 2024 15:02
@tillh-stripe tillh-stripe merged commit 29bebd1 into master Mar 5, 2024
12 checks passed
@tillh-stripe tillh-stripe deleted the tillh/payment-option-icon-painter branch March 5, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants