[FC] Removes mavericks from repositories and more panes. #8154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosmuvi-stripe
requested review from
awush-stripe and
tillh-stripe
and removed request for
a team and
awush-stripe
|
Diffuse output: |
Comment on lines
-15
to
-20
| /** | ||
| * The active auth session id. Used across process kills to prevent re-creating the session | ||
| * if one is already active. | ||
| */ | ||
| @PersistState | ||
| val activeAuthSession: String? = null, |
There was a problem hiding this comment.
realized we don't need this anymore. When loading partner auth, we'd check the active session in the cached manifest, and if there's no manifest cached (i.e. process kill) we'd refetch it from backend, getting the existing auth session as well.
| ): Job { | ||
| return viewModelScope.launch { | ||
| setState { reducer(Loading) } | ||
| setState { reducer(Loading(value = retainValue?.get(this)?.invoke())) } |
There was a problem hiding this comment.
Took this from mavericks: This allows us to optionally keep the current Async value if moving to a Loading state from Success (so that we can keep the screen content while loading)
|
|
||
| suspend fun get() = awaitState().error | ||
| private val state = MutableStateFlow(State()) |
There was a problem hiding this comment.
Why do we need a flow here?
| @@ -180,7 +181,7 @@ internal class AccountPickerViewModel @Inject constructor( | |||
| ) | |||
| } | |||
|
|
|||
| fun onAccountClicked(account: PartnerAccount) = withState { state -> | |||
There was a problem hiding this comment.
What do you think about adding a withState method to our base ViewModel?
tillh-stripe
approved these changes
Mar 26, 2024
carlosmuvi-stripe
merged commit 6ca0025
into
carlosmuvi/i/remove-mavericks
11 of 12 checks passed
carlosmuvi-stripe
added a commit
that referenced
this pull request
Mar 27, 2024
* [FC] Moves Activities and some Panes out of Mavericks (#8125) * Removes mackericks references on Consent screen. * Updates files. * Uses viewmodel factory builder. * Updates functions. * Updates execute. * Updates compose util. * Adds missing side effects. * Simplifies code. * Renames viewmodel. * Updates async. * Removes mavericks from institution picker. * Reverts rename. * Updates baseline. * Adds setState and persists state. * Renames result error to fail. * Migrates Initial activity out of mavericks. * Removes persist state. * Updates tests. * Regenerates API. * filterNotNull. * Nits. * Updates async. * use suspend block. * Update financial-connections/src/main/java/com/stripe/android/financialconnections/core/FinancialConnectionsViewModel.kt Co-authored-by: Till Hellmund <tillh@stripe.com> * Tries onAsync. * Moves activity to stripe ui core. * PR feedback. * Regenerates deps. --------- Co-authored-by: Till Hellmund <tillh@stripe.com> * [FC] Removes mavericks from repositories and more panes. (#8154) * Migrates more screens out of mavs. * Migrates partner auth. * Removes active auth session field. * Updates tests. * Updates attach payment viewmodel. * PR feedback. * Api dump. * [FC] Removes mavericks from all viewmodels and tests (#8155) * Migrates more screens out of mavs. * Migrates partner auth. * Removes active auth session field. * Updates tests. * Updates attach payment viewmodel. * PR feedback. * Api dump. * Migrates missing viewmodels. * Updates dependencies. * PR feedback. * Merge master. * [FC] Removes mavericks dependency (#8160) * Migrates more screens out of mavs. * Migrates partner auth. * Removes active auth session field. * Updates tests. * Updates attach payment viewmodel. * PR feedback. * Api dump. * Migrates missing viewmodels. * Updates dependencies. * Removes mavericks dependency. * Merge with integration. * Uses collect. * Updates dependencies * Updates Changelog. * Update CHANGELOG.md Co-authored-by: Till Hellmund <tillh@stripe.com> --------- Co-authored-by: Till Hellmund <tillh@stripe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Testing