Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FC] Remove Overscroll override on Institution Picker #8223

Merged

Conversation

carlosmuvi-stripe
Copy link
Collaborator

@carlosmuvi-stripe carlosmuvi-stripe commented Apr 4, 2024

Summary

  • Issue: We're using an experimental component to override the overscroll behavior
  • Seems like it's been moved around in Compose, causing NoClassDefFoundError on merchants using Compose 1.6+
  • We are now able to just use the default overscroll behavior

Motivation

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before After
before screenshot after screenshot

Changelog

@carlosmuvi-stripe carlosmuvi-stripe marked this pull request as ready for review April 4, 2024 21:10
@carlosmuvi-stripe carlosmuvi-stripe requested review from a team as code owners April 4, 2024 21:10
Copy link
Contributor

github-actions bot commented Apr 4, 2024

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │     2 MiB │     2 MiB │  0 B │   4.2 MiB │   4.2 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │  0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │   8.1 KiB │   8.1 KiB │  0 B 
      res │ 301.5 KiB │ 301.5 KiB │  0 B │   455 KiB │   455 KiB │  0 B 
   native │   7.3 MiB │   7.3 MiB │  0 B │  18.4 MiB │  18.4 MiB │  0 B 
    asset │   1.6 MiB │   1.6 MiB │  0 B │   1.6 MiB │   1.6 MiB │  0 B 
    other │  99.8 KiB │  99.8 KiB │ +1 B │ 206.8 KiB │ 206.8 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │  12.3 MiB │  12.3 MiB │ +1 B │  25.8 MiB │  25.8 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 21470 │ 21470 │ 0 (+0 -0) 
   types │  6645 │  6645 │ 0 (+0 -0) 
 classes │  5411 │  5411 │ 0 (+0 -0) 
 methods │ 31009 │ 31009 │ 0 (+0 -0) 
  fields │ 18100 │ 18100 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3404 │ 3404 │  0
APK
   compressed    │   uncompressed   │                        
──────────┬──────┼───────────┬──────┤                        
 size     │ diff │ size      │ diff │ path                   
──────────┼──────┼───────────┼──────┼────────────────────────
 38.2 KiB │ +4 B │  86.7 KiB │  0 B │ ∆ META-INF/CERT.SF     
 29.5 KiB │ -4 B │  86.6 KiB │  0 B │ ∆ META-INF/MANIFEST.MF 
  1.2 KiB │ +1 B │   1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA    
──────────┼──────┼───────────┼──────┼────────────────────────
 68.9 KiB │ +1 B │ 174.5 KiB │  0 B │ (total)

@carlosmuvi-stripe carlosmuvi-stripe merged commit 0c41153 into master Apr 4, 2024
12 checks passed
@carlosmuvi-stripe carlosmuvi-stripe deleted the carlosmuvi/remove-overscroll-experimental branch April 4, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants