Move FC consumer rules to payments-core.

[jaynewstrom-stripe]

Summary

We have a compile only dependency on financial connections in payments-core.

Motivation

Fixes #8243

[github-actions]

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │   3.9 MiB │   3.9 MiB │  0 B │   8.5 MiB │   8.5 MiB │  0 B 
     arsc │   2.2 MiB │   2.2 MiB │  0 B │   2.2 MiB │   2.2 MiB │  0 B 
 manifest │     5 KiB │     5 KiB │  0 B │  24.9 KiB │  24.9 KiB │  0 B 
      res │ 911.1 KiB │ 911.1 KiB │  0 B │   1.4 MiB │   1.4 MiB │  0 B 
   native │   2.6 MiB │   2.6 MiB │  0 B │     6 MiB │     6 MiB │  0 B 
    asset │     3 MiB │     3 MiB │  0 B │     3 MiB │     3 MiB │  0 B 
    other │   204 KiB │   204 KiB │ -1 B │ 444.8 KiB │ 444.8 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │  12.8 MiB │  12.8 MiB │ -1 B │  21.7 MiB │  21.7 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 42548 │ 42548 │ 0 (+0 -0) 
   types │ 14509 │ 14509 │ 0 (+0 -0) 
 classes │ 12238 │ 12238 │ 0 (+0 -0) 
 methods │ 60409 │ 60409 │ 0 (+0 -0) 
  fields │ 40058 │ 40058 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  242 │  242 │  0   
 entries │ 6029 │ 6029 │  0

APK

   compressed    │   uncompressed   │                                           
──────────┬──────┼───────────┬──────┤                                           
 size     │ diff │ size      │ diff │ path                                      
──────────┼──────┼───────────┼──────┼───────────────────────────────────────────
   62 KiB │ -3 B │ 139.7 KiB │  0 B │ ∆ META-INF/CERT.SF                        
    272 B │ +2 B │     120 B │  0 B │ ∆ META-INF/version-control-info.textproto 
──────────┼──────┼───────────┼──────┼───────────────────────────────────────────
 62.2 KiB │ -1 B │ 139.8 KiB │  0 B │ (total)

[StefMa]

I'm not 100% sure, but shouldn't it be better moved to financial-connections? 🤔
This way, the proguard config will always be used as soon as the lib is added as a compile time dependency...?! 🤔

[jaynewstrom-stripe]

payments-core is the right location :)

financial-connections wouldn't be added to your project (unless you explicitly depend on it, rendering the proguard rule useless).