Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert Maestro support for Google Pay. #8504

Merged
merged 1 commit into from
May 21, 2024

Conversation

samer-stripe
Copy link
Collaborator

@samer-stripe samer-stripe commented May 21, 2024

Summary

Revert Maestro support for Google Pay.

Motivation

Revert Maestro support for Google Pay.
#ir-oval-component

@samer-stripe samer-stripe requested review from a team as code owners May 21, 2024 16:09
@samer-stripe samer-stripe requested review from tillh-stripe and jaynewstrom-stripe and removed request for tillh-stripe May 21, 2024 16:09
@samer-stripe samer-stripe enabled auto-merge (squash) May 21, 2024 16:09
Copy link
Contributor

github-actions bot commented May 21, 2024

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │          compressed           │         uncompressed          
          ├───────────┬───────────┬───────┼───────────┬───────────┬───────
 APK      │ old       │ new       │ diff  │ old       │ new       │ diff  
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼───────
      dex │   3.9 MiB │   3.9 MiB │ +50 B │   8.6 MiB │   8.6 MiB │ -16 B 
     arsc │   2.2 MiB │   2.2 MiB │   0 B │   2.2 MiB │   2.2 MiB │   0 B 
 manifest │   5.1 KiB │   5.1 KiB │   0 B │  25.8 KiB │  25.8 KiB │   0 B 
      res │ 910.2 KiB │ 910.2 KiB │   0 B │   1.4 MiB │   1.4 MiB │   0 B 
   native │   2.6 MiB │   2.6 MiB │   0 B │     6 MiB │     6 MiB │   0 B 
    asset │   2.9 MiB │   2.9 MiB │  -1 B │   2.9 MiB │   2.9 MiB │  -1 B 
    other │ 194.3 KiB │ 194.3 KiB │  +3 B │ 424.7 KiB │ 424.7 KiB │   0 B 
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼───────
    total │  12.8 MiB │  12.8 MiB │ +52 B │  21.7 MiB │  21.7 MiB │ -17 B 

 DEX     │ old   │ new   │ diff       
─────────┼───────┼───────┼────────────
   files │     1 │     1 │  0         
 strings │ 43186 │ 43185 │ -1 (+1 -2) 
   types │ 14814 │ 14814 │  0 (+0 -0) 
 classes │ 12508 │ 12508 │  0 (+0 -0) 
 methods │ 61277 │ 61277 │  0 (+0 -0) 
  fields │ 40387 │ 40387 │  0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  242 │  242 │  0   
 entries │ 6031 │ 6031 │  0
APK
   compressed    │  uncompressed   │                                           
─────────┬───────┼─────────┬───────┤                                           
 size    │ diff  │ size    │ diff  │ path                                      
─────────┼───────┼─────────┼───────┼───────────────────────────────────────────
 3.9 MiB │ +50 B │ 8.6 MiB │ -16 B │ ∆ classes.dex                             
 1.2 KiB │  +2 B │ 1.2 KiB │   0 B │ ∆ META-INF/CERT.RSA                       
   272 B │  +1 B │   120 B │   0 B │ ∆ META-INF/version-control-info.textproto 
 7.3 KiB │  -1 B │ 7.2 KiB │  -1 B │ ∆ assets/dexopt/baseline.prof             
─────────┼───────┼─────────┼───────┼───────────────────────────────────────────
 3.9 MiB │ +52 B │ 8.6 MiB │ -17 B │ (total)
DEX
STRINGS:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   43186 │ 43185 │ -1 (+1 -2) 
  
  + ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:33a4b70,r8-mode:full,version:8.3.37}
  
  - MAESTRO
  - ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:9c5461f,r8-mode:full,version:8.3.37}

@tjclawson-stripe tjclawson-stripe self-requested a review May 21, 2024 16:19
@samer-stripe samer-stripe merged commit 432ee2a into master May 21, 2024
14 checks passed
@samer-stripe samer-stripe deleted the samer/google-pay-revert-maestro-support branch May 21, 2024 16:32
@surajnavkudkar
Copy link

@samer-stripe any reason we reverted it ? As it was added in 2.43.0 based on a feature request. Will Stripe won't support maestro cards?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants