Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with enter address manually button #8596

Merged
merged 5 commits into from
Jun 10, 2024
Merged

Conversation

amk-stripe
Copy link
Collaborator

@amk-stripe amk-stripe commented Jun 6, 2024

Summary

Set a "forceExpandedForm" field on InputAddressScreen after "Enter address manually" has been clicked to force displaying the expanded form

Motivation

Fix issue with enter address manually button

https://jira.corp.stripe.com/browse/RUN_MOBILESDK-3247

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screen recordings

Before:

address-manually.mp4

After:

enter.manually.-.after.mp4

Changelog

  • [FIXED]8596 Fixed issue where "Enter address manually" button only worked the first time it was clicked.

@amk-stripe amk-stripe marked this pull request as ready for review June 6, 2024 18:55
@amk-stripe amk-stripe requested review from a team as code owners June 6, 2024 18:55
@amk-stripe amk-stripe requested a review from samer-stripe June 6, 2024 18:55
Copy link
Contributor

github-actions bot commented Jun 6, 2024

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │     2 MiB │     2 MiB │  0 B │   4.3 MiB │   4.3 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │  0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │   8.1 KiB │   8.1 KiB │  0 B 
      res │ 301.5 KiB │ 301.5 KiB │  0 B │   455 KiB │   455 KiB │  0 B 
   native │   7.3 MiB │   7.3 MiB │  0 B │  18.4 MiB │  18.4 MiB │  0 B 
    asset │   1.5 MiB │   1.5 MiB │  0 B │   1.5 MiB │   1.5 MiB │  0 B 
    other │    87 KiB │    87 KiB │ +7 B │ 161.5 KiB │ 161.5 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │  12.2 MiB │  12.2 MiB │ +7 B │  25.8 MiB │  25.8 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 21689 │ 21689 │ 0 (+0 -0) 
   types │  6869 │  6869 │ 0 (+0 -0) 
 classes │  5634 │  5634 │ 0 (+0 -0) 
 methods │ 31456 │ 31456 │ 0 (+0 -0) 
  fields │ 18319 │ 18319 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3404 │ 3404 │  0
APK
   compressed    │   uncompressed   │                                           
──────────┬──────┼───────────┬──────┤                                           
 size     │ diff │ size      │ diff │ path                                      
──────────┼──────┼───────────┼──────┼───────────────────────────────────────────
 25.9 KiB │ +4 B │  63.9 KiB │  0 B │ ∆ META-INF/MANIFEST.MF                    
 29.1 KiB │ +3 B │    64 KiB │  0 B │ ∆ META-INF/CERT.SF                        
    272 B │ +1 B │     120 B │  0 B │ ∆ META-INF/version-control-info.textproto 
  1.2 KiB │ -1 B │   1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA                       
──────────┼──────┼───────────┼──────┼───────────────────────────────────────────
 56.3 KiB │ +7 B │ 129.2 KiB │  0 B │ (total)

samer-stripe
samer-stripe previously approved these changes Jun 6, 2024
samer-stripe
samer-stripe previously approved these changes Jun 7, 2024
@amk-stripe amk-stripe merged commit 43634b5 into master Jun 10, 2024
12 checks passed
@amk-stripe amk-stripe deleted the fix-enter-manually-bug branch June 10, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants