Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where FlowController shows an empty saved payment method screen when Google Pay is enabled. #8672

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

samer-stripe
Copy link
Collaborator

Summary

Fix issue where FlowController shows an empty saved payment method screen when Google Pay is enabled.

Motivation

Fix issue where FlowController shows an empty saved payment method screen when Google Pay is enabled.

Testing

  • Added tests
  • Modified tests
  • Manually verified

Copy link
Contributor

github-actions bot commented Jun 24, 2024

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │     2 MiB │     2 MiB │  0 B │   4.3 MiB │   4.3 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │  0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │   8.1 KiB │   8.1 KiB │  0 B 
      res │ 301.5 KiB │ 301.5 KiB │  0 B │   455 KiB │   455 KiB │  0 B 
   native │   7.3 MiB │   7.3 MiB │  0 B │  18.4 MiB │  18.4 MiB │  0 B 
    asset │   1.5 MiB │   1.5 MiB │  0 B │   1.5 MiB │   1.5 MiB │  0 B 
    other │    87 KiB │    87 KiB │ -1 B │ 161.5 KiB │ 161.5 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │  12.2 MiB │  12.2 MiB │ -1 B │  25.8 MiB │  25.8 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 21651 │ 21651 │ 0 (+0 -0) 
   types │  6873 │  6873 │ 0 (+0 -0) 
 classes │  5638 │  5638 │ 0 (+0 -0) 
 methods │ 31466 │ 31466 │ 0 (+0 -0) 
  fields │ 18327 │ 18327 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3404 │ 3404 │  0
APK
   compressed    │   uncompressed   │                                           
──────────┬──────┼───────────┬──────┤                                           
 size     │ diff │ size      │ diff │ path                                      
──────────┼──────┼───────────┼──────┼───────────────────────────────────────────
 25.9 KiB │ -3 B │  63.9 KiB │  0 B │ ∆ META-INF/MANIFEST.MF                    
  1.2 KiB │ +2 B │   1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA                       
    272 B │ +1 B │     120 B │  0 B │ ∆ META-INF/version-control-info.textproto 
 29.1 KiB │ -1 B │    64 KiB │  0 B │ ∆ META-INF/CERT.SF                        
──────────┼──────┼───────────┼──────┼───────────────────────────────────────────
 56.4 KiB │ -1 B │ 129.2 KiB │  0 B │ (total)

@jaynewstrom-stripe jaynewstrom-stripe marked this pull request as ready for review June 24, 2024 17:51
@jaynewstrom-stripe jaynewstrom-stripe requested review from a team as code owners June 24, 2024 17:51
@samer-stripe samer-stripe merged commit 2d365b3 into master Jun 24, 2024
12 of 13 checks passed
@samer-stripe samer-stripe deleted the samer/fix-flow-controller-empty-bug branch June 24, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants