Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3DS2 Req 70 Implementation #9078

Merged
merged 1 commit into from
Aug 22, 2024
Merged

3DS2 Req 70 Implementation #9078

merged 1 commit into from
Aug 22, 2024

Conversation

Twigz
Copy link
Collaborator

@Twigz Twigz commented Aug 15, 2024

Summary

Auto submits the CReq if the currently displayed UI is out of band and the user returns to the app from the background.

Motivation

Implements a new requirement from the 2.2 spec as follows:

[Req 70] During Out-of-Band (OOB) authentication, when the 3DS Requestor App comes to
the foreground, the CReq shall automatically be submitted to the ACS and the value of the
OOB Continuation Indicator field shall be set to true.

Testing

Manually verified using the playground.

  • Added tests
  • Modified tests
  • Manually verified

@Twigz Twigz requested a review from tjclawson-stripe August 15, 2024 17:04
@Twigz Twigz requested review from a team as code owners August 15, 2024 17:04
@Twigz Twigz changed the base branch from master to feature/3ds2-2.2 August 15, 2024 17:04
Copy link
Contributor

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │            compressed            │           uncompressed           
          ├─────────────┬─────────────┬──────┼─────────────┬─────────────┬──────
 APK      │ old         │ new         │ diff │ old         │ new         │ diff 
──────────┼─────────────┼─────────────┼──────┼─────────────┼─────────────┼──────
      dex │       2 MiB │       2 MiB │  0 B │     4.2 MiB │     4.2 MiB │  0 B 
     arsc │ 1,023.9 KiB │ 1,023.9 KiB │  0 B │ 1,023.8 KiB │ 1,023.8 KiB │  0 B 
 manifest │     2.3 KiB │     2.3 KiB │  0 B │       8 KiB │       8 KiB │  0 B 
      res │   301.5 KiB │   301.5 KiB │  0 B │     455 KiB │     455 KiB │  0 B 
   native │     6.2 MiB │     6.2 MiB │  0 B │    15.8 MiB │    15.8 MiB │  0 B 
    asset │     6.7 KiB │     6.7 KiB │  0 B │     6.4 KiB │     6.4 KiB │  0 B 
    other │    85.5 KiB │    85.5 KiB │ +2 B │   158.7 KiB │   158.7 KiB │  0 B 
──────────┼─────────────┼─────────────┼──────┼─────────────┼─────────────┼──────
    total │     9.6 MiB │     9.6 MiB │ +2 B │    21.6 MiB │    21.6 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 21310 │ 21310 │ 0 (+0 -0) 
   types │  6771 │  6771 │ 0 (+0 -0) 
 classes │  5560 │  5560 │ 0 (+0 -0) 
 methods │ 31123 │ 31123 │ 0 (+0 -0) 
  fields │ 18155 │ 18155 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3392 │ 3392 │  0
APK
   compressed    │   uncompressed   │                                           
──────────┬──────┼───────────┬──────┤                                           
 size     │ diff │ size      │ diff │ path                                      
──────────┼──────┼───────────┼──────┼───────────────────────────────────────────
 25.1 KiB │ +4 B │  62.5 KiB │  0 B │ ∆ META-INF/MANIFEST.MF                    
 28.3 KiB │ -3 B │  62.6 KiB │  0 B │ ∆ META-INF/CERT.SF                        
  1.2 KiB │ +2 B │   1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA                       
    271 B │ -1 B │     120 B │  0 B │ ∆ META-INF/version-control-info.textproto 
──────────┼──────┼───────────┼──────┼───────────────────────────────────────────
 54.9 KiB │ +2 B │ 126.4 KiB │  0 B │ (total)

@Twigz Twigz merged commit 6a9cec4 into feature/3ds2-2.2 Aug 22, 2024
13 checks passed
@Twigz Twigz deleted the feature/3ds2-req-70 branch August 22, 2024 16:28
tjclawson-stripe added a commit that referenced this pull request Nov 19, 2024
* Allows for auto-submittal of the challenge if the view is OOB (#9078)

* 3DS2 Req 71 Implementation (#9077)

* Adds challenge no entry value for req 71

* Updates test

* Make "Y" a constant

* 3DS2 2.2 Device Data Requirements (#9298)

* Add device information updates

* Fixing up tests

* Fix test

* Linting

* Update DeviceDataFactoryImpl.kt

* Update 3ds2sdk.api

* 3DS2 Spec Updates (#9387)

* 3DS2 Analytics Delegate (#9430)

* Allows for auto-submittal of the challenge if the view is OOB

* Analytics implementation

* Update 3ds2sdk.api

* Fix issues

* Utilizing service loader

* Move AnalyticsProvider

* Update 3ds2sdk.api

* Adds landscape layout for challenge zone view

* Update LOA

* Update message version in 3ds2 playground

* Add RestrictTo annotations to public APIs

---------

Co-authored-by: Twig <Twigz@users.noreply.github.com>
Co-authored-by: Twig <aharris.1990@gmail.com>
Co-authored-by: reuben-stripe <107846296+reuben-stripe@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants