Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PaymentSession from example code #9370

Merged
merged 3 commits into from
Oct 2, 2024

Conversation

amk-stripe
Copy link
Collaborator

@amk-stripe amk-stripe commented Sep 30, 2024

Summary

Remove PaymentSession from example code

Ensured that this didn't leave any dead code behind by using the "analyze > inspect code" tool in Android Studio

Motivation

https://jira.corp.stripe.com/browse/MOBILESDK-2405

Pre-work for deprecating basic integration is to remove our code samples that reference BI

@@ -60,7 +60,7 @@ class AddFpxPaymentMethodTest {
private fun launchBankSelector() {
// launch FPX selection activity
onView(withId(R.id.examples)).perform(
RecyclerViewActions.actionOnItemAtPosition<RecyclerView.ViewHolder>(13, click())
RecyclerViewActions.actionOnItemAtPosition<RecyclerView.ViewHolder>(12, click())
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed an item from the list above this, so the new position of the Fpx selector is 12

@@ -66,7 +66,7 @@ class AddNetbankingPaymentMethodTest {
private fun launchBankSelector() {
// launch Netbanking selection activity
onView(withId(R.id.examples)).perform(
RecyclerViewActions.actionOnItemAtPosition<RecyclerView.ViewHolder>(13, click())
RecyclerViewActions.actionOnItemAtPosition<RecyclerView.ViewHolder>(11, click())
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also needed to be updated because I removed an item from the list above this. But this previously was actually testing Fpx, not Netbanking :/ (basically the old index was wrong, which is why this is updated by two instead of one)

Copy link
Contributor

github-actions bot commented Oct 2, 2024

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │   1.9 MiB │   1.9 MiB │  0 B │     4 MiB │     4 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │  0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │     8 KiB │     8 KiB │  0 B 
      res │ 301.5 KiB │ 301.5 KiB │  0 B │   455 KiB │   455 KiB │  0 B 
   native │   6.2 MiB │   6.2 MiB │  0 B │  15.8 MiB │  15.8 MiB │  0 B 
    asset │   6.8 KiB │   6.8 KiB │  0 B │   6.5 KiB │   6.5 KiB │  0 B 
    other │  85.5 KiB │  85.5 KiB │ -7 B │ 158.7 KiB │ 158.7 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │   9.5 MiB │   9.5 MiB │ -7 B │  21.4 MiB │  21.4 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 20244 │ 20244 │ 0 (+0 -0) 
   types │  6082 │  6082 │ 0 (+0 -0) 
 classes │  4886 │  4886 │ 0 (+0 -0) 
 methods │ 29462 │ 29462 │ 0 (+0 -0) 
  fields │ 17389 │ 17389 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3608 │ 3608 │  0
APK
   compressed    │   uncompressed   │                                           
──────────┬──────┼───────────┬──────┤                                           
 size     │ diff │ size      │ diff │ path                                      
──────────┼──────┼───────────┼──────┼───────────────────────────────────────────
 25.1 KiB │ -5 B │  62.5 KiB │  0 B │ ∆ META-INF/MANIFEST.MF                    
  1.2 KiB │ -2 B │   1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA                       
    271 B │ +1 B │     120 B │  0 B │ ∆ META-INF/version-control-info.textproto 
 28.3 KiB │ -1 B │  62.6 KiB │  0 B │ ∆ META-INF/CERT.SF                        
──────────┼──────┼───────────┼──────┼───────────────────────────────────────────
 54.9 KiB │ -7 B │ 126.4 KiB │  0 B │ (total)

@amk-stripe amk-stripe marked this pull request as ready for review October 2, 2024 19:52
@amk-stripe amk-stripe requested review from a team as code owners October 2, 2024 19:52
Copy link
Collaborator

@samer-stripe samer-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@amk-stripe amk-stripe merged commit 72eb77b into master Oct 2, 2024
13 checks passed
@amk-stripe amk-stripe deleted the remove-payment-session-from-examples branch October 2, 2024 20:32
amk-stripe added a commit that referenced this pull request Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants