-
Notifications
You must be signed in to change notification settings - Fork 659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove PaymentSession from example code #9370
Conversation
@@ -60,7 +60,7 @@ class AddFpxPaymentMethodTest { | |||
private fun launchBankSelector() { | |||
// launch FPX selection activity | |||
onView(withId(R.id.examples)).perform( | |||
RecyclerViewActions.actionOnItemAtPosition<RecyclerView.ViewHolder>(13, click()) | |||
RecyclerViewActions.actionOnItemAtPosition<RecyclerView.ViewHolder>(12, click()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed an item from the list above this, so the new position of the Fpx selector is 12
@@ -66,7 +66,7 @@ class AddNetbankingPaymentMethodTest { | |||
private fun launchBankSelector() { | |||
// launch Netbanking selection activity | |||
onView(withId(R.id.examples)).perform( | |||
RecyclerViewActions.actionOnItemAtPosition<RecyclerView.ViewHolder>(13, click()) | |||
RecyclerViewActions.actionOnItemAtPosition<RecyclerView.ViewHolder>(11, click()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also needed to be updated because I removed an item from the list above this. But this previously was actually testing Fpx, not Netbanking :/ (basically the old index was wrong, which is why this is updated by two instead of one)
Diffuse output:
APK
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥳
This reverts commit 72eb77b.
Summary
Remove PaymentSession from example code
Ensured that this didn't leave any dead code behind by using the "analyze > inspect code" tool in Android Studio
Motivation
https://jira.corp.stripe.com/browse/MOBILESDK-2405
Pre-work for deprecating basic integration is to remove our code samples that reference BI