Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Payment Method Support #952

Merged
merged 56 commits into from
May 20, 2019
Merged

Payment Method Support #952

merged 56 commits into from
May 20, 2019

Conversation

jemerick-stripe
Copy link
Contributor

Summary

  • Add ability to get payment method objects from credit card input widget
  • Create payment methods asynchronously
  • Update AddSourceActivity to AddPaymentMethodActivity
  • Update MaskedCardView to accept a PaymentMethod
  • Update PaymentMethodsActivity and MaskedCardAdapter to display a list of PaymentMethods

Motivation

MOBILE3DS2-363

Testing

  • Added/updated automated tests
  • Tested adding and listing payment methods using example app

@jemerick-stripe
Add utility getters for Payment Method Card and Billing Details to Ca…
f936949 
…rd Widget
@jemerick-stripe
add PaymentMethodCallback interface
0333442
@jemerick-stripe
Add ActivityPaymentMethodCallback impl
742c0e2
@jemerick-stripe
Add ability to create payment methods with Stripe
29f3450
@jemerick-stripe
Refactor AddSourceActivity to AddPaymentMethodActivity
ebc729f
@jemerick-stripe
update tests
fb48b45
@jemerick-stripe
clean up add payment method activity
37c9678
@jemerick-stripe
update masked card view to accept a Payment Method
9edf0c9
@jemerick-stripe
make getPaymentMethods public
2536054
@jemerick-stripe
Add ActivityPaymentMethodsRetrievalListener
989d000
@jemerick-stripe
Update MaskedCardAdapter to work with PaymentMethods
cff9ef3
@jemerick-stripe
Update PaymentMethodsActivity to use payment methods
b99a3bd
@jemerick-stripe
Merge branch 'master' into payment-method-standard-integration
c006f7b
@jemerick-stripe
Map payment method brands to card brands
9a275b3
@jemerick-stripe
Update masked card adapter to preseve selected item on update
a2d29f5
@jemerick-stripe
Update masked card adapter tests
583c3ed
@jemerick-stripe
remove proxy wait delay
8b3849c
@jemerick-stripe
auto select newest added payment method
8b5b536
@jemerick-stripe
select newest payment method as default
8a0ca52
@jemerick-stripe
remove commented out code
d4c7f0a
@jemerick-stripe
update test json to match real data
5e469b4
@jemerick-stripe
update payment method tests
4ad649b
@jemerick-stripe
Merge branch 'master' into payment-method-standard-integration
f09124c
@jemerick-stripe
Fix payment method test
91347b1
@jemerick-stripe
add test to ensure newest is selected
639af1b
mshafrir-stripe
mshafrir-stripe requested changes May 16, 2019
View reviewed changes
Copy link
Collaborator

@mshafrir-stripe mshafrir-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first pass

stripe/src/main/java/com/stripe/android/ActivityPaymentMethodCallback.java Outdated Show resolved Hide resolved
stripe/src/test/java/com/stripe/android/model/PaymentMethodTest.java Outdated Show resolved Hide resolved
stripe/src/test/java/com/stripe/android/CustomerSessionTest.java Outdated Show resolved Hide resolved
stripe/src/main/java/com/stripe/android/model/PaymentMethod.java Outdated Show resolved Hide resolved
stripe/src/main/java/com/stripe/android/CustomerSession.java Outdated Show resolved Hide resolved
mshafrir-stripe
mshafrir-stripe requested changes May 17, 2019
View reviewed changes
stripe/src/main/java/com/stripe/android/CustomerSession.java Outdated Show resolved Hide resolved
stripe/src/main/java/com/stripe/android/PaymentMethodCallback.java Outdated Show resolved Hide resolved
stripe/src/main/java/com/stripe/android/Stripe.java Show resolved Hide resolved
stripe/src/main/java/com/stripe/android/Stripe.java Show resolved Hide resolved
stripe/src/main/java/com/stripe/android/model/PaymentMethod.java Show resolved Hide resolved
stripe/src/main/java/com/stripe/android/view/AddPaymentMethodActivity.java Show resolved Hide resolved
stripe/src/main/java/com/stripe/android/view/AddPaymentMethodActivity.java Outdated Show resolved Hide resolved
stripe/src/main/java/com/stripe/android/view/CardInputWidget.java Show resolved Hide resolved
stripe/src/test/java/com/stripe/android/view/MaskedCardViewTest.java Show resolved Hide resolved
@jemerick-stripe jemerick-stripe changed the title [WIP] Payment Method Support Payment Method Support May 20, 2019
mshafrir-stripe
mshafrir-stripe requested changes May 20, 2019
View reviewed changes
stripe/src/main/java/com/stripe/android/view/AddPaymentMethodActivity.java Outdated Show resolved Hide resolved
stripe/src/test/java/com/stripe/android/view/AddPaymentMethodActivityTest.java Outdated Show resolved Hide resolved
stripe/src/test/java/com/stripe/android/view/AddPaymentMethodActivityTest.java Outdated Show resolved Hide resolved
stripe/src/test/java/com/stripe/android/view/AddPaymentMethodActivityTest.java Outdated Show resolved Hide resolved
stripe/src/test/java/com/stripe/android/view/AddPaymentMethodActivityTest.java Outdated Show resolved Hide resolved
stripe/src/test/java/com/stripe/android/view/PaymentMethodsActivityTest.java Outdated Show resolved Hide resolved
stripe/src/test/java/com/stripe/android/view/MaskedCardViewTest.java Outdated Show resolved Hide resolved
@jemerick-stripe jemerick-stripe merged commit 194fef4 into master May 20, 2019
@jemerick-stripe jemerick-stripe deleted the payment-method-standard-integration branch May 20, 2019 20:25
@mshafrir-stripe mshafrir-stripe mentioned this pull request May 24, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshafrir-stripe mshafrir-stripe mshafrir-stripe approved these changes

Assignees

@jemerick-stripe jemerick-stripe

Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jemerick-stripe @mshafrir-stripe @stripe-ci