Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete FPX bank icons #9533

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Delete FPX bank icons #9533

merged 1 commit into from
Oct 31, 2024

Conversation

amk-stripe
Copy link
Collaborator

Summary

Delete FPX bank icons

Motivation

https://jira.corp.stripe.com/browse/MOBILESDK-2549

These icons are unused now that BI has been deleted.

Testing

  • Added tests
  • Modified tests
  • Manually verified

Copy link
Contributor

github-actions bot commented Oct 30, 2024

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │            compressed             │           uncompressed            
          ├───────────┬───────────┬───────────┼───────────┬───────────┬───────────
 APK      │ old       │ new       │ diff      │ old       │ new       │ diff      
──────────┼───────────┼───────────┼───────────┼───────────┼───────────┼───────────
      dex │   3.8 MiB │   3.8 MiB │      -4 B │   8.4 MiB │   8.4 MiB │       0 B 
     arsc │   2.3 MiB │   2.3 MiB │  -2.2 KiB │   2.3 MiB │   2.3 MiB │  -2.2 KiB 
 manifest │     5 KiB │     5 KiB │       0 B │  24.7 KiB │  24.7 KiB │       0 B 
      res │ 931.2 KiB │ 900.4 KiB │ -30.8 KiB │   1.5 MiB │   1.4 MiB │ -64.4 KiB 
   native │   2.6 MiB │   2.6 MiB │       0 B │     6 MiB │     6 MiB │       0 B 
    asset │   1.6 MiB │   1.6 MiB │       0 B │   1.6 MiB │   1.6 MiB │       0 B 
    other │ 200.9 KiB │ 199.6 KiB │  -1.2 KiB │ 442.4 KiB │ 439.7 KiB │  -2.7 KiB 
──────────┼───────────┼───────────┼───────────┼───────────┼───────────┼───────────
    total │  11.5 MiB │  11.4 MiB │ -34.2 KiB │  20.3 MiB │  20.2 MiB │ -69.3 KiB 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 39655 │ 39655 │ 0 (+0 -0) 
   types │ 13666 │ 13666 │ 0 (+0 -0) 
 classes │ 11364 │ 11364 │ 0 (+0 -0) 
 methods │ 58386 │ 58386 │ 0 (+0 -0) 
  fields │ 38724 │ 38724 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff         
─────────┼──────┼──────┼──────────────
 configs │  242 │  242 │   0          
 entries │ 6247 │ 6230 │ -17 (+0 -17)
APK
      compressed      │     uncompressed      │                        
──────────┬───────────┼───────────┬───────────┤                        
 size     │ diff      │ size      │ diff      │ path                   
──────────┼───────────┼───────────┼───────────┼────────────────────────
          │  -5.8 KiB │           │ -12.8 KiB │ - res/vb.xml           
          │    -5 KiB │           │ -10.8 KiB │ - res/ry.xml           
          │  -4.1 KiB │           │  -8.6 KiB │ - res/OC.xml           
          │  -2.6 KiB │           │  -5.3 KiB │ - res/eX.xml           
          │  -2.5 KiB │           │  -5.5 KiB │ - res/ZY.xml           
  2.3 MiB │  -2.2 KiB │   2.3 MiB │  -2.2 KiB │ ∆ resources.arsc       
          │  -1.4 KiB │           │  -3.1 KiB │ - res/iK.xml           
          │  -1.3 KiB │           │  -2.6 KiB │ - res/_5.xml           
          │  -1.1 KiB │           │  -2.2 KiB │ - res/uM.xml           
          │  -1.1 KiB │           │  -2.3 KiB │ - res/Jp.xml           
          │  -1.1 KiB │           │  -2.4 KiB │ - res/8B.xml           
          │    -936 B │           │  -1.7 KiB │ - res/BU.xml           
          │    -893 B │           │  -1.5 KiB │ - res/CD.xml           
          │    -687 B │           │  -1.2 KiB │ - res/mo.xml           
          │    -686 B │           │  -1.5 KiB │ - res/SP.xml           
          │    -684 B │           │  -1.2 KiB │ - res/Tj.xml           
 49.6 KiB │    -630 B │ 117.2 KiB │  -1.4 KiB │ ∆ META-INF/MANIFEST.MF 
 52.9 KiB │    -628 B │ 117.3 KiB │  -1.4 KiB │ ∆ META-INF/CERT.SF     
          │    -531 B │           │    -876 B │ - res/in.xml           
          │    -525 B │           │    -932 B │ - res/8B1.xml          
  3.8 MiB │      -4 B │   8.4 MiB │       0 B │ ∆ classes.dex          
    462 B │      +2 B │     824 B │       0 B │ ∆ res/e-.xml           
  1.1 KiB │      +1 B │   3.2 KiB │       0 B │ ∆ res/B7.xml           
    782 B │      -1 B │   1.6 KiB │       0 B │ ∆ res/Bh.xml           
    599 B │      +1 B │   1.1 KiB │       0 B │ ∆ res/JB.xml           
    650 B │      +1 B │   1.3 KiB │       0 B │ ∆ res/SJ.xml           
    757 B │      +1 B │   1.7 KiB │       0 B │ ∆ res/cZ.xml           
    725 B │      -1 B │   1.6 KiB │       0 B │ ∆ res/pq.xml           
    326 B │      +1 B │     464 B │       0 B │ ∆ res/wX.xml           
  1.2 KiB │      -1 B │   1.2 KiB │       0 B │ ∆ META-INF/CERT.RSA    
──────────┼───────────┼───────────┼───────────┼────────────────────────
  6.3 MiB │ -34.2 KiB │  10.9 MiB │ -69.3 KiB │ (total)
ARSC
ENTRIES:

   old  │ new  │ diff         
  ──────┼──────┼──────────────
   6247 │ 6230 │ -17 (+0 -17) 
  - drawable/stripe_ic_bank_affin
  - drawable/stripe_ic_bank_alliance
  - drawable/stripe_ic_bank_ambank
  - drawable/stripe_ic_bank_bsn
  - drawable/stripe_ic_bank_cimb
  - drawable/stripe_ic_bank_hong_leong
  - drawable/stripe_ic_bank_hsbc
  - drawable/stripe_ic_bank_islam
  - drawable/stripe_ic_bank_kfh
  - drawable/stripe_ic_bank_maybank
  - drawable/stripe_ic_bank_muamalat
  - drawable/stripe_ic_bank_ocbc
  - drawable/stripe_ic_bank_public
  - drawable/stripe_ic_bank_raykat
  - drawable/stripe_ic_bank_rhb
  - drawable/stripe_ic_bank_standard_chartered
  - drawable/stripe_ic_bank_uob

@amk-stripe amk-stripe marked this pull request as ready for review October 30, 2024 22:52
@amk-stripe amk-stripe requested review from a team as code owners October 30, 2024 22:52
@amk-stripe amk-stripe merged commit 1976b69 into master Oct 31, 2024
16 checks passed
@amk-stripe amk-stripe deleted the delete-fpx-icons branch October 31, 2024 16:45
amk-stripe added a commit that referenced this pull request Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants