Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove instantDebitsBillingDetails feature flag #9536

Merged
merged 1 commit into from
Nov 12, 2024
+1 −16
Merged

Remove instantDebitsBillingDetails feature flag #9536

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions ...a/com/stripe/android/paymentsheet/paymentdatacollection/ach/USBankAccountFormViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ import androidx.lifecycle.viewmodel.CreationExtras
import com.stripe.android.PaymentConfiguration
import com.stripe.android.core.strings.ResolvableString
import com.stripe.android.core.strings.resolvableString
import com.stripe.android.core.utils.FeatureFlags
import com.stripe.android.core.utils.requireApplication
import com.stripe.android.financialconnections.FinancialConnectionsSheet.ElementsSessionContext
import com.stripe.android.financialconnections.model.BankAccount
Expand Down Expand Up @@ -502,11 +501,7 @@ internal class USBankAccountFormViewModel @Inject internal constructor(
amount = args.formArgs.amount?.value,
currency = args.formArgs.amount?.currencyCode,
linkMode = args.linkMode,
billingDetails = if (FeatureFlags.instantDebitsBillingDetails.isEnabled) {
makeElementsSessionContextBillingDetails()
} else {
null
},
billingDetails = makeElementsSessionContextBillingDetails(),
prefillDetails = makePrefillDetails(),
)
}
Expand Down
9 changes: 0 additions & 9 deletions ...m/stripe/android/paymentsheet/paymentdatacollection/ach/USBankAccountFormViewModelTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import com.google.common.truth.Truth.assertThat
import com.stripe.android.ApiKeyFixtures
import com.stripe.android.PaymentConfiguration
import com.stripe.android.core.strings.resolvableString
import com.stripe.android.core.utils.FeatureFlags
import com.stripe.android.financialconnections.FinancialConnectionsSheet.ElementsSessionContext
import com.stripe.android.financialconnections.model.BankAccount
import com.stripe.android.financialconnections.model.FinancialConnectionsAccount
Expand All @@ -30,7 +29,6 @@ import com.stripe.android.paymentsheet.PaymentSheet.BillingDetailsCollectionConf
import com.stripe.android.paymentsheet.model.PaymentSelection
import com.stripe.android.paymentsheet.model.PaymentSelection.CustomerRequestedSave
import com.stripe.android.paymentsheet.paymentdatacollection.FormArguments
import com.stripe.android.testing.FeatureFlagTestRule
import com.stripe.android.ui.core.Amount
import com.stripe.android.ui.core.cbc.CardBrandChoiceEligibility
import com.stripe.android.uicore.elements.IdentifierSpec
Expand All @@ -39,7 +37,6 @@ import kotlinx.coroutines.test.UnconfinedTestDispatcher
import kotlinx.coroutines.test.resetMain
import kotlinx.coroutines.test.runTest
import kotlinx.coroutines.test.setMain
import org.junit.Rule
import org.junit.runner.RunWith
import org.mockito.kotlin.any
import org.mockito.kotlin.anyOrNull
Expand Down Expand Up @@ -85,12 +82,6 @@ class USBankAccountFormViewModelTest {
private val mockCollectBankAccountLauncher = mock<CollectBankAccountLauncher>()
private val savedStateHandle = SavedStateHandle()

@get:Rule
val instantDebitsBillingDetailsFeatureRule = FeatureFlagTestRule(
featureFlag = FeatureFlags.instantDebitsBillingDetails,
isEnabled = true,
)

@BeforeTest
fun setUp() {
Dispatchers.setMain(UnconfinedTestDispatcher())
Expand Down
1 change: 0 additions & 1 deletion stripe-core/src/main/java/com/stripe/android/core/utils/FeatureFlags.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import com.stripe.android.core.BuildConfig
object FeatureFlags {
// Add any feature flags here
val nativeLinkEnabled = FeatureFlag("Native Link")
val instantDebitsBillingDetails = FeatureFlag("IBP Billing Details")
val instantDebitsDeferredIntent = FeatureFlag("IBP Deferred")
val useNewUpdateCardScreen = FeatureFlag("Enable new update card screen")
}
Expand Down
Loading