-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify bank form screen state #9587
Conversation
Diffuse output:
APK
|
394b094
to
4333b53
Compare
4333b53
to
92fd556
Compare
updatePrimaryButton( | ||
text = screenState.primaryButtonText, | ||
text = resolvableString(StripeUiCoreR.string.stripe_continue_button_label), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We always show Continue
if we haven’t linked a bank account yet.
public synthetic fun newArray (I)[Ljava/lang/Object; | ||
} | ||
|
||
public final class com/stripe/android/paymentsheet/paymentdatacollection/ach/USBankAccountFormScreenState$VerifyWithMicrodeposits$Creator : android/os/Parcelable$Creator { | ||
public final class com/stripe/android/paymentsheet/paymentdatacollection/ach/ComposableSingletons$USBankAccountFormKt { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to restrict this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately no.
onRemoveAccount: () -> Unit, | ||
) { | ||
Column(Modifier.fillMaxWidth()) { | ||
Column(modifier.fillMaxWidth()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the fillMaxWidth
specified twice? Once here, and once at the callsite?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. Removing it!
Summary
This pull request simplifies the state management in the bank account form.
We replace
USBankAccountFormScreenState
withBankFormScreenState
, which is a simple data class with a nullablelinkedBankAccount
. This bank account contains information about the account, such as whether it is being verified via microdeposits.Motivation
Testing
Screenshots
Changelog