-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate TextField
from TextFieldSection
#9592
Conversation
) | ||
} | ||
content = content, | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I initially considered allowing multiple modifiers for TextFieldSection
: one for the Section
and one for TextField
but Jetpack Compose produces a warning if attempting to have modifiers with names other than modifier
.
I imagine this was done for better practices when writing Composables in order to indicate that a Composable
should be split up if there are multiple modifiers required in order make it work.
This is mainly why I went with the option to make TextFieldSection
a Section
that reads a textFieldController
for a majority of its values then have the consumer pass TextField
as part of its content.
Diffuse output:
APK
DEX
|
9212a5c
to
542cb7c
Compare
Summary
Separate
TextField
fromTextFieldSection
Motivation
This allows for better control of padding coming from
TextFieldSection
Testing