-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link Payment Method Rows UI #9681
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toluo-stripe
force-pushed
the
tolu/link/payment_method_rows
branch
from
November 20, 2024 18:33
521b349
to
a694583
Compare
Diffuse output:
APK
DEX
ARSC
|
toluo-stripe
force-pushed
the
tolu/link/payment_method_rows
branch
2 times, most recently
from
November 20, 2024 23:17
f2827b1
to
36b7739
Compare
toluo-stripe
changed the title
Tolu/link/payment method rows
Link Payment Method Rows UI
Nov 21, 2024
toluo-stripe
force-pushed
the
tolu/link/payment_method_rows
branch
from
November 21, 2024 18:26
1ccdab7
to
98a4d44
Compare
amk-stripe
reviewed
Nov 21, 2024
link/src/test/java/com/stripe/android/link/ui/wallet/PaymentDetailsListItemScreenShotTest.kt
Outdated
Show resolved
Hide resolved
link/src/main/java/com/stripe/android/link/ui/wallet/PaymentDetails.kt
Outdated
Show resolved
Hide resolved
link/src/main/java/com/stripe/android/link/ui/wallet/PaymentDetails.kt
Outdated
Show resolved
Hide resolved
toluo-stripe
force-pushed
the
tolu/link/payment_method_rows
branch
from
November 22, 2024 22:37
9979641
to
cb429e0
Compare
amk-stripe
previously approved these changes
Nov 22, 2024
Add screenshots Minor fixes clean up fix test theme Fix screenshots Remove strings remove unused payment details remove alpha Delete screenshots Update strings.xml Update screenshots Fix screenshots
toluo-stripe
force-pushed
the
tolu/link/payment_method_rows
branch
from
November 25, 2024 17:56
e3e9504
to
fe007af
Compare
amk-stripe
reviewed
Nov 25, 2024
link/res/values/strings.xml
Outdated
@@ -50,6 +50,10 @@ | |||
<string name="stripe_wallet_default">Default</string> | |||
<!-- Title for a section listing one or more payment methods. --> | |||
<string name="stripe_wallet_expanded_title">Payment methods</string> | |||
<!-- Prefix for last 4 digits of payment method id e.g •••• 1234 --> | |||
<string name="stripe_wallet_last4_prefix">•••• </string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you mark this one as not translatable?
amk-stripe
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Compose UI for Link Payment Method Rows
Motivation
JIRA
Testing
Screenshots
Changelog