Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link Payment Method Rows UI #9681

Merged
merged 11 commits into from
Nov 25, 2024
Merged

Conversation

toluo-stripe
Copy link
Contributor

@toluo-stripe toluo-stripe commented Nov 20, 2024

Summary

Compose UI for Link Payment Method Rows

Motivation

JIRA

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

com stripe android link ui wallet_PaymentDetailsListItemScreenShotTest_test BankAccountEnabled DarkTheme,DefaultFont

com stripe android link ui wallet_PaymentDetailsListItemScreenShotTest_test BankAccountEnabled LightTheme,DefaultFont

com stripe android link ui wallet_PaymentDetailsListItemScreenShotTest_test CardDisabledAndSelected LightTheme,LargeFont

com stripe android link ui wallet_PaymentDetailsListItemScreenShotTest_test CardEnabled LightTheme,DefaultFont

Changelog

@toluo-stripe toluo-stripe force-pushed the tolu/link/payment_method_rows branch from 521b349 to a694583 Compare November 20, 2024 18:33
Copy link
Contributor

github-actions bot commented Nov 20, 2024

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │            compressed            │          uncompressed          
          ├───────────┬───────────┬──────────┼──────────┬──────────┬──────────
 APK      │ old       │ new       │ diff     │ old      │ new      │ diff     
──────────┼───────────┼───────────┼──────────┼──────────┼──────────┼──────────
      dex │   3.9 MiB │   3.9 MiB │   +160 B │  8.5 MiB │  8.5 MiB │   +284 B 
     arsc │   2.3 MiB │   2.3 MiB │ +1.8 KiB │  2.3 MiB │  2.3 MiB │ +1.8 KiB 
 manifest │     5 KiB │     5 KiB │      0 B │ 24.9 KiB │ 24.9 KiB │      0 B 
      res │ 904.1 KiB │ 906.3 KiB │ +2.3 KiB │  1.4 MiB │  1.4 MiB │ +4.5 KiB 
   native │   2.6 MiB │   2.6 MiB │      0 B │    6 MiB │    6 MiB │      0 B 
    asset │   1.6 MiB │   1.6 MiB │      0 B │  1.6 MiB │  1.6 MiB │      0 B 
    other │   1.4 MiB │   1.4 MiB │   +237 B │  1.6 MiB │  1.6 MiB │   +496 B 
──────────┼───────────┼───────────┼──────────┼──────────┼──────────┼──────────
    total │  12.7 MiB │  12.7 MiB │ +4.4 KiB │ 21.5 MiB │ 21.5 MiB │ +7.1 KiB 

 DEX     │ old   │ new   │ diff       
─────────┼───────┼───────┼────────────
   files │     1 │     1 │  0         
 strings │ 40373 │ 40373 │  0 (+3 -3) 
   types │ 13925 │ 13925 │  0 (+0 -0) 
 classes │ 11610 │ 11610 │  0 (+0 -0) 
 methods │ 59321 │ 59321 │  0 (+1 -1) 
  fields │ 39548 │ 39554 │ +6 (+9 -3) 

 ARSC    │ old  │ new  │ diff       
─────────┼──────┼──────┼────────────
 configs │  243 │  243 │  0         
 entries │ 6197 │ 6202 │ +5 (+5 -0)
APK
     compressed      │     uncompressed     │                        
──────────┬──────────┼───────────┬──────────┤                        
 size     │ diff     │ size      │ diff     │ path                   
──────────┼──────────┼───────────┼──────────┼────────────────────────
  2.3 MiB │ +1.8 KiB │   2.3 MiB │ +1.8 KiB │ ∆ resources.arsc       
  1.1 KiB │ +1.1 KiB │   2.5 KiB │ +2.5 KiB │ + res/mU1.xml          
    633 B │   +633 B │   1.2 KiB │ +1.2 KiB │ + res/FG1.xml          
    557 B │   +557 B │     880 B │   +880 B │ + res/vB.xml           
  3.9 MiB │   +160 B │   8.5 MiB │   +284 B │ ∆ classes.dex          
 50.1 KiB │   +122 B │ 118.3 KiB │   +248 B │ ∆ META-INF/MANIFEST.MF 
 53.4 KiB │   +115 B │ 118.3 KiB │   +248 B │ ∆ META-INF/CERT.SF     
    662 B │    +31 B │   1.2 KiB │    -68 B │ ∆ res/FG.xml           
──────────┼──────────┼───────────┼──────────┼────────────────────────
  6.3 MiB │ +4.4 KiB │  11.1 MiB │ +7.1 KiB │ (total)
DEX
STRINGS:

   old   │ new   │ diff      
  ───────┼───────┼───────────
   40373 │ 40373 │ 0 (+3 -3) 
  
  + LinkColors(componentBackground=
  + VJJJJJJJJJJLJJJJL
  + ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"d5b558b","r8-mode":"full","version":"8.7.14"}
  
  - LinkColors(componentBorder=
  - VJJJJJJJJLJJJJL
  - ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"dd8e696","r8-mode":"full","version":"8.7.14"}
  

METHODS:

   old   │ new   │ diff      
  ───────┼───────┼───────────
   59321 │ 59321 │ 0 (+1 -1) 
  
  + u6.b <init>(long, long, long, long, long, long, long, long, long, long, b0, long, long, long, long, a0)
  
  - u6.b <init>(long, long, long, long, long, long, long, long, b0, long, long, long, long, a0)
  

FIELDS:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   39548 │ 39554 │ +6 (+9 -3) 
  
  + u6.a C: long
  + u6.a D: long
  + u6.a E: long
  + u6.a F: long
  + u6.b i: long
  + u6.b k: b0
  + u6.b n: long
  + u6.b o: long
  + u6.b p: a0
  
  - u6.b i: b0
  - u6.b k: long
  - u6.b n: a0
ARSC
ENTRIES:

   old  │ new  │ diff       
  ──────┼──────┼────────────
   6197 │ 6202 │ +5 (+5 -0) 
  + drawable/stripe_link_add_green
  + drawable/stripe_link_bank
  + drawable/stripe_link_chevron
  + string/stripe_wallet_last4_prefix
  + string/stripe_wallet_passthrough_description

@toluo-stripe toluo-stripe force-pushed the tolu/link/payment_method_rows branch 2 times, most recently from f2827b1 to 36b7739 Compare November 20, 2024 23:17
@toluo-stripe toluo-stripe changed the title Tolu/link/payment method rows Link Payment Method Rows UI Nov 21, 2024
@toluo-stripe toluo-stripe force-pushed the tolu/link/payment_method_rows branch from 1ccdab7 to 98a4d44 Compare November 21, 2024 18:26
@toluo-stripe toluo-stripe marked this pull request as ready for review November 21, 2024 18:27
@toluo-stripe toluo-stripe requested review from a team as code owners November 21, 2024 18:27
@toluo-stripe toluo-stripe requested a review from a team as a code owner November 22, 2024 21:49
@toluo-stripe toluo-stripe force-pushed the tolu/link/payment_method_rows branch from 9979641 to cb429e0 Compare November 22, 2024 22:37
amk-stripe
amk-stripe previously approved these changes Nov 22, 2024
@toluo-stripe toluo-stripe force-pushed the tolu/link/payment_method_rows branch from e3e9504 to fe007af Compare November 25, 2024 17:56
@@ -50,6 +50,10 @@
<string name="stripe_wallet_default">Default</string>
<!-- Title for a section listing one or more payment methods. -->
<string name="stripe_wallet_expanded_title">Payment methods</string>
<!-- Prefix for last 4 digits of payment method id e.g •••• 1234 -->
<string name="stripe_wallet_last4_prefix">•••• </string>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you mark this one as not translatable?

@toluo-stripe toluo-stripe merged commit 3c205d7 into master Nov 25, 2024
16 checks passed
@toluo-stripe toluo-stripe deleted the tolu/link/payment_method_rows branch November 25, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants