Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pre-confirm state from ConfirmationHandler #9685

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

samer-stripe
Copy link
Collaborator

@samer-stripe samer-stripe commented Nov 20, 2024

Summary

Remove pre-confirm state from ConfirmationHandler

Motivation

The pre-confirm state was mainly created to solve a use case in which pre-confirm is handled differently in PaymentSheet for Google Pay then confirmation. Rather than have a pre-confirm state, we can just have the option available through the Confirming state and remove the pre-confirm state entirely. We also no longer want to provide UI context through the confirmation state.

Testing

  • Added tests
  • Modified tests
  • Manually verified

@samer-stripe samer-stripe added the embedded-confirmation Related to Embedded project in terms of confirmation work label Nov 20, 2024
Copy link
Contributor

github-actions bot commented Nov 20, 2024

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │     2 MiB │     2 MiB │  0 B │   4.1 MiB │   4.1 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │  0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │     8 KiB │     8 KiB │  0 B 
      res │ 301.8 KiB │ 301.8 KiB │  0 B │ 455.5 KiB │ 455.5 KiB │  0 B 
   native │   6.2 MiB │   6.2 MiB │  0 B │  15.8 MiB │  15.8 MiB │  0 B 
    asset │   7.1 KiB │   7.1 KiB │  0 B │   6.9 KiB │   6.9 KiB │  0 B 
    other │  90.2 KiB │  90.2 KiB │ +6 B │ 170.3 KiB │ 170.3 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │   9.6 MiB │   9.6 MiB │ +6 B │  21.5 MiB │  21.5 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 19966 │ 19966 │ 0 (+0 -0) 
   types │  6188 │  6188 │ 0 (+0 -0) 
 classes │  4979 │  4979 │ 0 (+0 -0) 
 methods │ 29759 │ 29759 │ 0 (+0 -0) 
  fields │ 17526 │ 17526 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3622 │ 3622 │  0
APK
   compressed    │   uncompressed   │                                           
──────────┬──────┼───────────┬──────┤                                           
 size     │ diff │ size      │ diff │ path                                      
──────────┼──────┼───────────┼──────┼───────────────────────────────────────────
 25.3 KiB │ +4 B │  62.8 KiB │  0 B │ ∆ META-INF/MANIFEST.MF                    
 28.4 KiB │ +3 B │  62.9 KiB │  0 B │ ∆ META-INF/CERT.SF                        
    270 B │ -2 B │     120 B │  0 B │ ∆ META-INF/version-control-info.textproto 
  1.2 KiB │ +1 B │   1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA                       
──────────┼──────┼───────────┼──────┼───────────────────────────────────────────
 55.2 KiB │ +6 B │ 127.1 KiB │  0 B │ (total)

@samer-stripe samer-stripe force-pushed the samer/remove-preconfirm-confirmation-state branch from b44e271 to f440743 Compare November 20, 2024 23:51
@samer-stripe samer-stripe marked this pull request as ready for review November 20, 2024 23:53
@samer-stripe samer-stripe requested review from a team as code owners November 20, 2024 23:53
) {
savedStateHandle[AWAITING_CONFIRMATION_RESULT_KEY] = AwaitingConfirmationResultData(
confirmationOption = option,
receivesResultInProcess = receivesResultInProcess,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still don't know what the best name for this is. Might be worth leaving a few comments explaining it.

@samer-stripe samer-stripe enabled auto-merge (squash) November 21, 2024 00:52
@samer-stripe samer-stripe merged commit 86fd6e5 into master Nov 21, 2024
13 checks passed
@samer-stripe samer-stripe deleted the samer/remove-preconfirm-confirmation-state branch November 21, 2024 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
embedded-confirmation Related to Embedded project in terms of confirmation work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants