-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove pre-confirm state from ConfirmationHandler
#9685
Merged
samer-stripe
merged 2 commits into
master
from
samer/remove-preconfirm-confirmation-state
Nov 21, 2024
Merged
Remove pre-confirm state from ConfirmationHandler
#9685
samer-stripe
merged 2 commits into
master
from
samer/remove-preconfirm-confirmation-state
Nov 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samer-stripe
added
the
embedded-confirmation
Related to Embedded project in terms of confirmation work
label
Nov 20, 2024
Diffuse output:
APK
|
samer-stripe
force-pushed
the
samer/remove-preconfirm-confirmation-state
branch
from
November 20, 2024 23:51
b44e271
to
f440743
Compare
jaynewstrom-stripe
previously approved these changes
Nov 21, 2024
) { | ||
savedStateHandle[AWAITING_CONFIRMATION_RESULT_KEY] = AwaitingConfirmationResultData( | ||
confirmationOption = option, | ||
receivesResultInProcess = receivesResultInProcess, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still don't know what the best name for this is. Might be worth leaving a few comments explaining it.
jaynewstrom-stripe
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove pre-confirm state from
ConfirmationHandler
Motivation
The pre-confirm state was mainly created to solve a use case in which pre-confirm is handled differently in
PaymentSheet
for Google Pay then confirmation. Rather than have a pre-confirm state, we can just have the option available through theConfirming
state and remove the pre-confirm state entirely. We also no longer want to provide UI context through the confirmation state.Testing