Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch available incentives after linking bank account #9735

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

tillh-stripe
Copy link
Collaborator

@tillh-stripe tillh-stripe commented Dec 4, 2024

Summary

This pull request adds a call to consumers/incentives/update_available at the end of the Instant Bank Payments flow. This endpoint doesn’t return any available incentives yet, but will do so soon.

Depending on the response, we return eligibleForIncentive: Boolean to the MPE. With a future pull request, it’ll update the payment methods list based on the response.

Motivation

CONSUMERBANK-564

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before After
before screenshot after screenshot

Changelog

Copy link
Contributor

github-actions bot commented Dec 4, 2024

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │            compressed            │          uncompressed          
          ├───────────┬───────────┬──────────┼──────────┬──────────┬──────────
 APK      │ old       │ new       │ diff     │ old      │ new      │ diff     
──────────┼───────────┼───────────┼──────────┼──────────┼──────────┼──────────
      dex │   3.9 MiB │   3.9 MiB │ +1.4 KiB │  8.6 MiB │  8.6 MiB │ +2.7 KiB 
     arsc │   2.3 MiB │   2.3 MiB │      0 B │  2.3 MiB │  2.3 MiB │      0 B 
 manifest │     5 KiB │     5 KiB │      0 B │ 24.9 KiB │ 24.9 KiB │      0 B 
      res │ 908.2 KiB │ 908.2 KiB │      0 B │  1.4 MiB │  1.4 MiB │      0 B 
   native │   2.6 MiB │   2.6 MiB │      0 B │    6 MiB │    6 MiB │      0 B 
    asset │   1.6 MiB │   1.6 MiB │    +28 B │  1.6 MiB │  1.6 MiB │    +28 B 
    other │   1.4 MiB │   1.4 MiB │     +2 B │  1.6 MiB │  1.6 MiB │      0 B 
──────────┼───────────┼───────────┼──────────┼──────────┼──────────┼──────────
    total │  12.7 MiB │  12.7 MiB │ +1.4 KiB │ 21.6 MiB │ 21.6 MiB │ +2.7 KiB 

 DEX     │ old   │ new   │ diff            
─────────┼───────┼───────┼─────────────────
   files │     1 │     1 │   0             
 strings │ 40588 │ 40597 │  +9 (+37 -28)   
   types │ 14007 │ 14011 │  +4 (+31 -27)   
 classes │ 11683 │ 11686 │  +3 (+7 -4)     
 methods │ 59626 │ 59639 │ +13 (+700 -687) 
  fields │ 39831 │ 39845 │ +14 (+761 -747) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  243 │  243 │  0   
 entries │ 6209 │ 6209 │  0
APK
     compressed      │     uncompressed     │                                
──────────┬──────────┼───────────┬──────────┤                                
 size     │ diff     │ size      │ diff     │ path                           
──────────┼──────────┼───────────┼──────────┼────────────────────────────────
  3.9 MiB │ +1.4 KiB │   8.6 MiB │ +2.7 KiB │ ∆ classes.dex                  
  7.8 KiB │    +29 B │   7.7 KiB │    +29 B │ ∆ assets/dexopt/baseline.prof  
    988 B │     -1 B │     856 B │     -1 B │ ∆ assets/dexopt/baseline.profm 
  1.2 KiB │     +1 B │   1.2 KiB │      0 B │ ∆ META-INF/CERT.RSA            
 50.2 KiB │     +1 B │ 118.4 KiB │      0 B │ ∆ META-INF/MANIFEST.MF         
──────────┼──────────┼───────────┼──────────┼────────────────────────────────
    4 MiB │ +1.4 KiB │   8.7 MiB │ +2.7 KiB │ (total)
DEX
STRINGS:

   old   │ new   │ diff         
  ───────┼───────┼──────────────
   40588 │ 40597 │ +9 (+37 -28) 
  
  + LK6/r3;
  + LK6/s3;
  + LZ7/f;
  + Lc8/r;
  + Le6/N;
  + Lg6/v;
  + Ls5/F;
  + UpdateAvailableIncentives(data=
  + [LK6/s3;
  + [LM1/k;
  + [LS6/d;
  + [LW5/n;
  + [LX5/g1;
  + [LZ8/F;
  + [LZ8/y;
  + [Lc8/r;
  + [Lcom/google/android/material/datepicker/b;
  + [Lcom/google/android/material/datepicker/d;
  + [Lcom/google/android/material/datepicker/n;
  + [Le6/J;
  + [Le6/M;
  + [Le6/s;
  + [Lg6/u;
  + [Lh3/c;
  + [Lh8/P;
  + [Lk7/q;
  + [Ln6/k;
  + [Ls5/r;
  + [Ls5/t;
  + [Lx5/N;
  + [Lx5/b;
  + [Lx5/k;
  + consumers/incentives/update_available
  + incentive_display_text
  + incentive_params
  + link_consumer_incentive
  + ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"11b67c8","r8-mode":"full","version":"8.7.14"}
  
  - LM1/u;
  - Lcom/google/android/material/datepicker/z;
  - Lh3/k;
  - Lx5/z0;
  - [LM1/l;
  - [LS6/c;
  - [LW5/m;
  - [LX5/f1;
  - [LZ8/E;
  - [LZ8/x;
  - [Lc8/p;
  - [Lcom/google/android/material/datepicker/c;
  - [Lcom/google/android/material/datepicker/e;
  - [Lcom/google/android/material/datepicker/o;
  - [Le6/I;
  - [Le6/L;
  - [Le6/r;
  - [Lg6/t;
  - [Lh3/g;
  - [Lh8/O;
  - [Lk7/p;
  - [Ln6/j;
  - [Ls5/q;
  - [Ls5/s;
  - [Lx5/O;
  - [Lx5/c;
  - [Lx5/l;
  - ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"f78ceb0","r8-mode":"full","version":"8.7.14"}
  

TYPES:

   old   │ new   │ diff         
  ───────┼───────┼──────────────
   14007 │ 14011 │ +4 (+31 -27) 
  
  + LK6/r3;
  + LK6/s3;
  + LZ7/f;
  + Lc8/r;
  + Le6/N;
  + Lg6/v;
  + Ls5/F;
  + [LK6/s3;
  + [LM1/k;
  + [LS6/d;
  + [LW5/n;
  + [LX5/g1;
  + [LZ8/F;
  + [LZ8/y;
  + [Lc8/r;
  + [Lcom/google/android/material/datepicker/b;
  + [Lcom/google/android/material/datepicker/d;
  + [Lcom/google/android/material/datepicker/n;
  + [Le6/J;
  + [Le6/M;
  + [Le6/s;
  + [Lg6/u;
  + [Lh3/c;
  + [Lh8/P;
  + [Lk7/q;
  + [Ln6/k;
  + [Ls5/r;
  + [Ls5/t;
  + [Lx5/N;
  + [Lx5/b;
  + [Lx5/k;
  
  - LM1/u;
  - Lcom/google/android/material/datepicker/z;
  - Lh3/k;
  - Lx5/z0;
  - [LM1/l;
  - [LS6/c;
  - [LW5/m;
  - [LX5/f1;
  - [LZ8/E;
  - [LZ8/x;
  - [Lc8/p;
  - [Lcom/google/android/material/datepicker/c;
  - [Lcom/google/android/material/datepicker/e;
  - [Lcom/google/android/material/datepicker/o;
  - [Le6/I;
  - [Le6/L;
  - [Le6/r;
  - [Lg6/t;
  - [Lh3/g;
  - [Lh8/O;
  - [Lk7/p;
  - [Ln6/j;
  - [Ls5/q;
  - [Ls5/s;
  - [Lx5/O;
  - [Lx5/c;
  - [Lx5/l;
  

METHODS:

   old   │ new   │ diff            
  ───────┼───────┼─────────────────
   59626 │ 59639 │ +13 (+700 -687) 
  
  + A5.j <init>(e, S, b, F, v, y0, d)
  + A6.d <init>(c, String, u, a, p, a, int)
  + B5.d <init>(c, u, a, String, int)
  + B5.j <init>(e, S, N, V, v, x, F, D, d)
  + B5.k <init>(a, l, a, C, a, e, a, a)
  + B5.k <init>(a, a, l, a, e, a, e, a)
  + B5.k <init>(a, e, e, a, a, j, a, c)
  + C0.c W(g1) → String
  + C0.c d0(g1) → boolean
  + C7.d <init>(c, u, a, String)
  + D5.W B(v, c, p, int)
  + D5.W D(u, c, p, int)
  + D5.W E(l, p, int)
  + D5.W w(c, String, u, a, p, a, p, int)
  + D5.W x(c, u, a, String, p, int)
  + E5.w <init>(i, S, a, D, F, v, p, d, p)
  + G5.i <init>(d, S, D, t, v, F, d)
  + G5.j <init>(a, e, a, a, a, a)
  + H5.j <init>(f, S, D, S, v, F, d)
  + J5.B <init>(Y, C0, g1, G2, boolean, d)
  + J5.D <init>(a, f0, D, s0, q, v, j0, F, y0, d, s, S)
  + J5.E <init>(e, e, e, a, a, a, n, a, C, a, a)
  + J5.E <init>(a, a, a, i, b, e, a, j, a, b, c)
  + J5.E <init>(a, a, e, C, a, C, e, e, e, a, a)
  + J5.E <init>(a, e, a, a, e, a, a, c, j, e, n)
  + K5.e <init>(A, e, e, c, a, c, a, u, int)
  + K5.n <init>(D, x, l, d)
  + K5.n <init>(V, r2, F0, G2, d)
  + K5.z <init>(l, S, v, L, p, t, v0, x0, D, F, d, a, p)
  + K6.g3 <init>(s3)
  + K6.o3 <init>(ArrayList)
  + K6.o3 describeContents() → int
  + K6.o3 equals(Object) → boolean
  + K6.o3 hashCode() → int
  + K6.o3 toString() → String
  + K6.o3 writeToParcel(Parcel, int)
  + K6.q3 <init>(String, int, String)
  + K6.q3 valueOf(String) → q3
  + K6.q3 values() → q3[]
  + K6.r2 <init>(String, Long, String, m2, Long, String, Source_Flow, Boolean, o2, p2, q2, Source_Status, Map, I2, String, String, Source_Usage, s3, n2, v2, String)
  + K6.r3 <init>(int)
  + K6.r3 createFromParcel(Parcel) → Object
  + K6.r3 newArray(int) → Object[]
  + K6.s3 <clinit>()
  + K6.s3 <init>(String, String, String, String, String, String, String, String, Strin
...✂

@tillh-stripe tillh-stripe force-pushed the tillh/ibp-incentives-fetch-available-incentives branch from 33dc828 to 9ae1eba Compare December 4, 2024 13:12
@tillh-stripe tillh-stripe force-pushed the tillh/ibp-incentives-bank-form-badge branch 2 times, most recently from b07a81e to 99bd861 Compare December 5, 2024 20:51
Base automatically changed from tillh/ibp-incentives-bank-form-badge to master December 5, 2024 21:11
@tillh-stripe tillh-stripe force-pushed the tillh/ibp-incentives-fetch-available-incentives branch 4 times, most recently from ac04a94 to 2d0ba4c Compare December 9, 2024 16:56
@tillh-stripe tillh-stripe force-pushed the tillh/ibp-incentives-fetch-available-incentives branch 2 times, most recently from 1b72d1b to fe65708 Compare December 16, 2024 15:58
@tillh-stripe tillh-stripe force-pushed the tillh/ibp-incentives-fetch-available-incentives branch from fe65708 to bff3c83 Compare December 16, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant