-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fetch available incentives after linking bank account #9735
Draft
tillh-stripe
wants to merge
4
commits into
master
Choose a base branch
from
tillh/ibp-incentives-fetch-available-incentives
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Fetch available incentives after linking bank account #9735
tillh-stripe
wants to merge
4
commits into
master
from
tillh/ibp-incentives-fetch-available-incentives
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Diffuse output:
APK
DEX
|
tillh-stripe
force-pushed
the
tillh/ibp-incentives-fetch-available-incentives
branch
from
December 4, 2024 13:12
33dc828
to
9ae1eba
Compare
tillh-stripe
force-pushed
the
tillh/ibp-incentives-bank-form-badge
branch
2 times, most recently
from
December 5, 2024 20:51
b07a81e
to
99bd861
Compare
Base automatically changed from
tillh/ibp-incentives-bank-form-badge
to
master
December 5, 2024 21:11
tillh-stripe
force-pushed
the
tillh/ibp-incentives-fetch-available-incentives
branch
4 times, most recently
from
December 9, 2024 16:56
ac04a94
to
2d0ba4c
Compare
tillh-stripe
force-pushed
the
tillh/ibp-incentives-fetch-available-incentives
branch
2 times, most recently
from
December 16, 2024 15:58
1b72d1b
to
fe65708
Compare
tillh-stripe
force-pushed
the
tillh/ibp-incentives-fetch-available-incentives
branch
from
December 16, 2024 17:09
fe65708
to
bff3c83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request adds a call to
consumers/incentives/update_available
at the end of the Instant Bank Payments flow. This endpoint doesn’t return any available incentives yet, but will do so soon.Depending on the response, we return
eligibleForIncentive: Boolean
to the MPE. With a future pull request, it’ll update the payment methods list based on the response.Motivation
CONSUMERBANK-564
Testing
Screenshots
Changelog