Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[connect] Add dark mode example #9785

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Conversation

lng-stripe
Copy link
Contributor

Summary

Add "dynamic" theme from iOS and fix realtime updates to Appearance on configuration changes.

Motivation

https://jira.corp.stripe.com/browse/MXMOBILE-2989

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Screen.Recording.2024-12-13.at.1.41.29.PM-compressed.mov

@lng-stripe lng-stripe requested a review from a team as a code owner December 13, 2024 20:50
Comment on lines +129 to +133
LaunchedEffect(context) {
val appearanceInfo = settingsService.getAppearanceId()
?.let { AppearanceInfo.getAppearance(it, context).appearance }
?: return@LaunchedEffect
embeddedComponentManager.update(appearanceInfo)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not ideal because in our Example app EmbeddedComponentManager is scoped to our Application while we're updating the appearance per Activity. Practically speaking, it's OK, but it doesn't serve as a great example for integrators.

Copy link
Contributor

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │     2 MiB │     2 MiB │  0 B │   4.1 MiB │   4.1 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │  0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │     8 KiB │     8 KiB │  0 B 
      res │ 301.8 KiB │ 301.8 KiB │  0 B │ 455.5 KiB │ 455.5 KiB │  0 B 
   native │   6.2 MiB │   6.2 MiB │  0 B │  15.8 MiB │  15.8 MiB │  0 B 
    asset │   7.1 KiB │   7.1 KiB │  0 B │   6.9 KiB │   6.9 KiB │  0 B 
    other │  90.2 KiB │  90.2 KiB │ -5 B │ 170.3 KiB │ 170.3 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │   9.6 MiB │   9.6 MiB │ -5 B │  21.5 MiB │  21.5 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 19966 │ 19966 │ 0 (+0 -0) 
   types │  6188 │  6188 │ 0 (+0 -0) 
 classes │  4979 │  4979 │ 0 (+0 -0) 
 methods │ 29759 │ 29759 │ 0 (+0 -0) 
  fields │ 17526 │ 17526 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3622 │ 3622 │  0
APK
   compressed    │  uncompressed   │                     
──────────┬──────┼──────────┬──────┤                     
 size     │ diff │ size     │ diff │ path                
──────────┼──────┼──────────┼──────┼─────────────────────
 28.4 KiB │ -6 B │ 62.9 KiB │  0 B │ ∆ META-INF/CERT.SF  
  1.2 KiB │ +1 B │  1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA 
──────────┼──────┼──────────┼──────┼─────────────────────
 29.6 KiB │ -5 B │ 64.1 KiB │  0 B │ (total)

@lng-stripe lng-stripe enabled auto-merge (squash) December 18, 2024 15:46
Copy link
Collaborator

@simond-stripe simond-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 Agreed with your comment on scoping mismatch for the EmbeddedComponentManager between the Activity and the App. It's good enough though, and we can always choose to change it later

@lng-stripe lng-stripe merged commit 88adb6a into master Dec 19, 2024
13 checks passed
@lng-stripe lng-stripe deleted the lng/connect-dark-mode-example branch December 19, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants