-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[connect] Add dark mode example #9785
Conversation
LaunchedEffect(context) { | ||
val appearanceInfo = settingsService.getAppearanceId() | ||
?.let { AppearanceInfo.getAppearance(it, context).appearance } | ||
?: return@LaunchedEffect | ||
embeddedComponentManager.update(appearanceInfo) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not ideal because in our Example app EmbeddedComponentManager
is scoped to our Application while we're updating the appearance per Activity. Practically speaking, it's OK, but it doesn't serve as a great example for integrators.
Diffuse output:
APK
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍 Agreed with your comment on scoping mismatch for the EmbeddedComponentManager between the Activity and the App. It's good enough though, and we can always choose to change it later
Summary
Add "dynamic" theme from iOS and fix realtime updates to Appearance on configuration changes.
Motivation
https://jira.corp.stripe.com/browse/MXMOBILE-2989
Testing
Screenshots
Screen.Recording.2024-12-13.at.1.41.29.PM-compressed.mov