[connect] Cleanup EmbeddedComponentManager scope and setup
#9809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Diffuse output: APK |
lng-stripe
commented
Dec 19, 2024
|
|
||
| override fun onCreate(savedInstanceState: Bundle?) { | ||
| super.onCreate(savedInstanceState) | ||
|
|
||
| EmbeddedComponentManager.onActivityCreate(this@MainActivity) |
There was a problem hiding this comment.
👀 Moved to BaseActivity#onCreate()
|
|
||
| @OptIn(PrivateBetaConnectSDK::class) | ||
| @Singleton | ||
| class EmbeddedComponentManagerProvider @Inject constructor( |
There was a problem hiding this comment.
👀 Reduced to EmbeddedComponentManagerManager
| val appearanceInfo = settingsService.getAppearanceId() | ||
| ?.let { AppearanceInfo.getAppearance(it, context).appearance } | ||
| ?: return@LaunchedEffect | ||
| embeddedComponentManager.update(appearanceInfo) |
There was a problem hiding this comment.
👀 Binding the app appearance setting to the manager is now done in EmbeddedComponentLoaderViewModel
| import javax.inject.Inject | ||
|
|
||
| @Suppress("ConstPropertyName") | ||
| private object BasicComponentExampleDestination { |
There was a problem hiding this comment.
👀 nit: moved this below the Activity definition
| loadManager() | ||
| return | ||
| // Bind appearance settings to the manager. | ||
| activity.lifecycleScope.launch { |
There was a problem hiding this comment.
👀 Important that we bind in the Activity scope and not ViewModel scope, otherwise there'd be a memory leak
3 tasks
lng-stripe
force-pushed
the
lng/connect-example-manager-per-activity
branch
from
8f8ba76 to
b7a66a3
Compare
simond-stripe
requested changes
Dec 20, 2024
| @@ -37,7 +37,10 @@ fun EmbeddedComponentManagerLoader( | |||
| ) { | |||
| val embeddedComponentManager = embeddedComponentAsync() | |||
| when (embeddedComponentAsync) { | |||
| is Uninitialized, is Loading -> LoadingScreen() | |||
| is Uninitialized -> { | |||
| // Don't show anything to avoid flicker. | |||
| @@ -248,6 +248,8 @@ internal class StripeConnectWebViewContainerImpl<Listener, Props>( | |||
|
|
|||
| private fun bindViewState(state: StripeConnectWebViewContainerState) { | |||
| val viewBinding = this.viewBinding ?: return | |||
| logger.debug("Binding view state: $state") | |||
| viewBinding.root.setBackgroundColor(state.backgroundColor) | |||
There was a problem hiding this comment.
Nice! Looks like this fixes MXMOBILE-2996 - I've linked this PR and marked it as done.
lng-stripe
force-pushed
the
lng/connect-example-manager-per-activity
branch
from
b7a66a3 to
47f60e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses this PR comment.
Instead of having a singleton
EmbeddedComponentManagerapp instance in the Example app:EmbeddedComponentManagerinstances inEmbeddedComponentLoaderViewModelEmbeddedComponentManagerProviderhas been demoted to aFactory, simplifying its roleEmbeddedComponentLoaderViewModelis also responsible for binding app appearance settings to the manager inActivity#onCreate(). It does so by being being a lifecycle observer that Activities must register. This is aided by introducing aBaseActivitythat our activities should extend.Also, fixed a minor visual glitch with embedded component backgrounds.
Motivation
See comment. Overall, I think this eliminates some confusing state logic we had between
EmbeddedComponentManagerProviderandEmbeddedComponentLoaderViewModel. There are clearer separations of concerns.Testing
Screenshots
Screen.Recording.2024-12-19.at.1.20.01.PM-compressed.mov