-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FC] Updates lookup call to use mobile endpoint on verified flows #9820
base: carlosmuvi/12-21-sends_supports_app_verification_to_syncrhonize_when_integrity_available
Are you sure you want to change the base?
Conversation
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Diffuse output:
APK
MANIFEST
DEX
ARSC
|
65fa3c3
to
5da26c9
Compare
22a9cb4
to
366a2a5
Compare
5da26c9
to
ecc939b
Compare
366a2a5
to
c75c7df
Compare
ecc939b
to
30a830a
Compare
c75c7df
to
152856f
Compare
30a830a
to
b87210e
Compare
152856f
to
2cd4451
Compare
b87210e
to
b2bb731
Compare
2cd4451
to
14220fb
Compare
b2bb731
to
c053783
Compare
14220fb
to
56c663c
Compare
c053783
to
03c604c
Compare
56c663c
to
cd2aa80
Compare
03c604c
to
eed6066
Compare
cd2aa80
to
4657230
Compare
eed6066
to
ade027d
Compare
4657230
to
3c39a07
Compare
suspend fun lookupConsumerSession( | ||
email: String, | ||
clientSecret: String | ||
): ConsumerSessionLookup | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was wrongly called lookup, we were actually calling POST consumer_session
. Renamed accordingly.
06ad79c
to
d45c6e2
Compare
ade027d
to
60ad1f8
Compare
dc1ba2a
to
8886acf
Compare
@@ -328,6 +365,12 @@ class ConsumersApiServiceImpl( | |||
internal val consumerSessionLookupUrl: String = | |||
getApiUrl("consumers/sessions/lookup") | |||
|
|||
/** | |||
* @return `https://api.stripe.com/v1/consumers/sessions/lookup` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The URL in this comment should be consumers/mobile/sessions/lookup
to match the actual API endpoint being referenced in mobileConsumerSessionLookupUrl
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
60ad1f8
to
6ff391a
Compare
8886acf
to
a524088
Compare
a524088
to
05fa7ad
Compare
6ff391a
to
92d3005
Compare
05fa7ad
to
83d5bb9
Compare
Summary
mobile/lookup
call passing verification tokenPOST consumer_sessions
(does some method renaming to match this)Motivation
https://docs.google.com/document/d/1joKz5UZHLVazmecfMHbq6gB6n4wj5u8To6AtqYgq_tc/edit?tab=t.0#heading=h.cz1xkpga7giy
Testing