Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made drop down selectable. #9849

Merged
merged 2 commits into from
Jan 3, 2025
Merged

Conversation

jaynewstrom-stripe
Copy link
Collaborator

Summary

This wasn't usable from android TV before.

Motivation

https://jira.corp.stripe.com/browse/MOBILESDK-2937

Testing

  • Added tests
  • Modified tests
  • Manually verified
Screen_recording_20250102_162935.mp4

Copy link
Contributor

github-actions bot commented Jan 2, 2025

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │           compressed           │          uncompressed          
          ├───────────┬───────────┬────────┼───────────┬───────────┬────────
 APK      │ old       │ new       │ diff   │ old       │ new       │ diff   
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼────────
      dex │     2 MiB │     2 MiB │ +378 B │   4.1 MiB │   4.1 MiB │ +592 B 
     arsc │     1 MiB │     1 MiB │    0 B │     1 MiB │     1 MiB │    0 B 
 manifest │   2.3 KiB │   2.3 KiB │    0 B │     8 KiB │     8 KiB │    0 B 
      res │ 301.8 KiB │ 301.8 KiB │    0 B │ 455.5 KiB │ 455.5 KiB │    0 B 
   native │   6.2 MiB │   6.2 MiB │    0 B │  15.8 MiB │  15.8 MiB │    0 B 
    asset │   7.1 KiB │   7.2 KiB │  +40 B │   6.9 KiB │   6.9 KiB │  +40 B 
    other │  90.2 KiB │  90.2 KiB │   -2 B │ 170.3 KiB │ 170.3 KiB │    0 B 
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼────────
    total │   9.6 MiB │   9.6 MiB │ +416 B │  21.5 MiB │  21.5 MiB │ +632 B 

 DEX     │ old   │ new   │ diff           
─────────┼───────┼───────┼────────────────
   files │     1 │     1 │  0             
 strings │ 19969 │ 19971 │ +2 (+5 -3)     
   types │  6191 │  6191 │  0 (+2 -2)     
 classes │  4982 │  4982 │  0 (+2 -2)     
 methods │ 29769 │ 29771 │ +2 (+229 -227) 
  fields │ 17540 │ 17541 │ +1 (+182 -181) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3622 │ 3622 │  0
APK
    compressed     │   uncompressed    │                                           
──────────┬────────┼──────────┬────────┤                                           
 size     │ diff   │ size     │ diff   │ path                                      
──────────┼────────┼──────────┼────────┼───────────────────────────────────────────
    2 MiB │ +378 B │  4.1 MiB │ +592 B │ ∆ classes.dex                             
  6.3 KiB │  +40 B │  6.2 KiB │  +40 B │ ∆ assets/dexopt/baseline.prof             
 28.4 KiB │   -5 B │ 62.9 KiB │    0 B │ ∆ META-INF/CERT.SF                        
 25.3 KiB │   +2 B │ 62.8 KiB │    0 B │ ∆ META-INF/MANIFEST.MF                    
    272 B │   +1 B │    120 B │    0 B │ ∆ META-INF/version-control-info.textproto 
──────────┼────────┼──────────┼────────┼───────────────────────────────────────────
    2 MiB │ +416 B │  4.2 MiB │ +632 B │ (total)
DEX
STRINGS:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   19969 │ 19971 │ +2 (+5 -3) 
  
  + LZLLZLL
  + Lg0/b;
  + Lg1/b;
  + android.software.leanback
  + ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"1faa286","r8-mode":"full","version":"8.7.14"}
  
  - Li0/E0;
  - Lj0/r;
  - ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"2188fc4","r8-mode":"full","version":"8.7.14"}
  

TYPES:

   old  │ new  │ diff      
  ──────┼──────┼───────────
   6191 │ 6191 │ 0 (+2 -2) 
  
  + Lg0/b;
  + Lg1/b;
  
  - Li0/E0;
  - Lj0/r;
  

METHODS:

   old   │ new   │ diff           
  ───────┼───────┼────────────────
   29769 │ 29771 │ +2 (+229 -227) 
  
  + P2.b m0(int)
  + P2.b n0(Typeface, boolean)
  + X0.p0 <init>(z0, n, boolean)
  + X2.a m0(int)
  + X2.a n0(Typeface, boolean)
  + X2.c m0(int)
  + X2.c n0(Typeface, boolean)
  + Z.B0 <init>(boolean, boolean, z0, j, v)
  + androidx.compose.foundation.a c(n, l, a0, boolean, g, a, int) → n
  + androidx.compose.foundation.text.modifiers.SelectableTextAnnotatedStringElement <init>(e, y, l, c, int, boolean, int, int, List, c, h, E2)
  + g0.a <init>(x0, boolean, l)
  + g0.a <init>(boolean, g, a)
  + g0.a g(Object, Object, Object) → Object
  + g0.b <init>(boolean)
  + g0.b i(Object) → Object
  + g1.b a(n, L, long, s, float, a, p, int, int)
  + g1.b b(T1, n, f, p, int)
  + g1.b c(int, int) → long
  + g1.b d(V1, n, f, p, int)
  + g1.b e(String, int)
  + g1.b f(long, byte[], int, int)
  + g1.b g(View, ConstraintLayout)
  + g1.b h(long, boolean, int, float) → long
  + g1.b i(int, int) → long
  + g1.b j() → f
  + g1.b k(v) → e
  + g1.b l(v, int) → e
  + g1.b m(v, int) → e
  + g1.b n() → boolean
  + g1.b o(int) → boolean
  + g1.b p(e) → f
  + g1.b q(Size, float) → Size
  + g1.b r(A) → JSONObject
  + g1.b s(Size, Size) → Rect
  + g1.b t(Typeface, w, Context) → Typeface
  + g1.b u(D, int, int)
  + g1.b v(D, int, Object)
  + g1.b w(Size) → Rect
  + g1.b x(long) → long
  + h1.e p(b, l, y, b, l) → b
  + i0.A0 <init>(w)
  + i0.A0 a(long) → long
  + i0.A0 b(long, boolean) → int
  + i0.A0 c(long) → boolean
  + i0.A0 d(long) → long
  + i0.A0 e(long) → long
  + i0.A <init>(z0, n, boolean, i0, q)
  + i0.A <init>(z0, boolean, Y0, i0, v, q)
  + i0.B0 <init>()
  + i0.B0 a(v)
  + i0.C0 <clinit>()
  + i0.C0 a(E, e) → C
  + i0.D0 <init>(x0, int, C, c)
  + i0.D0 a(J, G, long) → I
  + i0.D0 b(c) → boolean
  + i0.D0 c(P, G, int) → int
  + i0.D0 e(P, G, int) → int
  + i0.D0 equals(Object) → boolean
  + i0.D0 f(P, G, int) → int
  + i0.D0 g(P, G, int) → int
  + i0.D0 h(Object, e) → Object
  + i0.D0 hashCode() → int
  + i0.D0 j(n) → n
  + i0.D0 toString() → String
  + i0.D <init>(boolean, boolean, z0, j)
  + i0.E <init>(q, boolean, v, i0, z0)
  + i0.F <init>(C, v, boolean, n, boolean, z0, q, i0, n)
  + i0.P <init>(x0, int, C, c)
  + i0.X j(z0)
  + i0.X m(w, z0, v, n, q)
  + i0.X t(z0, v, q)
  + i0.X v(n, e, y, c, int, boolean, int, int, l, List, c, h, E2) → n
  + i0.o0 <init>(z0, i0, v, boolean, boolean, m0, q, B0, K, x, int)
  + i0.p0 <init>(z0, i0, v, boolean, boolean, q, B0, x, int)
  + i0.q <init>(z0, V, w, i0, n, d)
  + i0.t <init>(z0, c, v, q, b, int)
  + i0.u0 <init>(x0, int)
  + i0.u <init>(i0, z0, boolean, boolean, c, v, q, b, int)
  + i0.v0 <init>(A0, x0)
  + i0.v <init>(z0, y, int, int, x0, v, E, n, n, n, n, f, i0, boolean, boolean, c, q, b)
  + i0.w0 <clinit>()
  + i0.w0 h(Object, Object) → Object
  + i0.w <init>(f, z0, y, int, int, x0, v, E, n, n, n, n, f, i0, boolean, boolean, c, q, b)
  + i0.x0 <init>(e0, float)
  + i0.x0 a(e0, d, int, int)
  + i0.x <init>(z0, int)
  + i0.y <init>(f, v, z0, A0, q, d)
  + i0.z0 <init>(i0, i0, M0)
  + i0.z0 a() → N
  + i0.z0 b() → boolean
  + i0.z0 c() → p
  + i0.z0 d() → A0
  + i0.z <init>(z0, w, boolean, boolean, v, n, q, i0, c, f)
  + j0.b <init>(l, y, b, l)
  + j0.b a(long, int) → long
  + j0.c <clinit>()
  + j0.d <init>(e, y, l, int, boolean, int, int, List)
  + j0.d a(int, l) → int
  + j0.d b(long, l) → h
  + j0.d c(b)
  + j0.d d(l) → c
  + j0.d e(l, long, h) → w
  + j0.e <init>(String, y, l, int, boolean, int, int)
  + j0.e b(long, l) → a
  + j0.e c(m)
  + j0.e d(l) → l
  + j0.f <init>(e, y, l, c, int, boolean, int, int, List, c, h, E2)
  + j0.f X(b0)
  + j0.f a(J, G, long) → I
  + j0.f b0()
  + j0.f c(P, G, int) → int
  + j0.f d(H)
  + j0.f e(P, G, int) → int
  + j0.f f(P, G, int) → int
  + j0.f g(P, G, int) → int
  + j0.g <init>(h, int)
  + j0.g a() 
...✂

@jaynewstrom-stripe jaynewstrom-stripe marked this pull request as ready for review January 2, 2025 23:53
@jaynewstrom-stripe jaynewstrom-stripe requested review from a team as code owners January 2, 2025 23:53
@jaynewstrom-stripe jaynewstrom-stripe enabled auto-merge (squash) January 3, 2025 00:01
@jaynewstrom-stripe jaynewstrom-stripe merged commit 69a3709 into master Jan 3, 2025
13 checks passed
@jaynewstrom-stripe jaynewstrom-stripe deleted the jaynewstrom/drop-down-select branch January 3, 2025 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants