-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Cvc Recollection and add fake to LinkConfirmationHandler #9884
Conversation
Diffuse output:
APK
|
...eet/src/test/java/com/stripe/android/link/confirmation/DefaultLinkConfirmationHandlerTest.kt
Show resolved
Hide resolved
@@ -8,7 +8,8 @@ import com.stripe.android.paymentelement.confirmation.ConfirmationHandler | |||
internal interface LinkConfirmationHandler { | |||
suspend fun confirm( | |||
paymentDetails: ConsumerPaymentDetails.PaymentDetails, | |||
linkAccount: LinkAccount | |||
linkAccount: LinkAccount, | |||
cvc: String? = null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little unsure of whether this is the best way to include CVC in the confirm call. Conceptually, it seems like maybe this should be part of the PaymentDetails
type (though that type is public so we probably can't change it). Also how does the CVC value here relate to the CvcCheck in the ConsumerPaymentDetails.Card type?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The cvc field is obtained after cvc recollection and he payment details represents the payment methods obtained from the backend. We could wrap both values in a new data class.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gotchaaa
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll wrap both values in my integration PR
@@ -8,7 +8,8 @@ import com.stripe.android.paymentelement.confirmation.ConfirmationHandler | |||
internal interface LinkConfirmationHandler { | |||
suspend fun confirm( | |||
paymentDetails: ConsumerPaymentDetails.PaymentDetails, | |||
linkAccount: LinkAccount | |||
linkAccount: LinkAccount, | |||
cvc: String? = null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gotchaaa
Summary
Support Cvc Recollection and add fake to LinkConfirmationHandler
Motivation
JIRA
Testing
Changelog