Default to application/octet-stream #1054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ob-stripe
force-pushed
the
ob-fix-1053
branch
from
ab1088d to
6555dea
Compare
|
@fred-stripe friendly bump on this one |
remi-stripe
approved these changes
Nov 23, 2017
| @@ -179,6 +179,11 @@ private static void ApplyMultiPartFileToRequest(HttpRequestMessage requestMessag | |||
| { | |||
| requestMessage.Headers.ExpectContinue = true; | |||
|
|
|||
| if (string.IsNullOrEmpty(fileName)) | |||
| { | |||
| fileName = "blob"; | |||
There was a problem hiding this comment.
should we be more explicit to indicate it's a hardcoded value? blob has some meaning for me as a type (like in a database) and so it felt weird the first 2 times I read the PR.
No big deal obviously but wanted to flag
There was a problem hiding this comment.
gotcha, works for me if we do this in the other libs!
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @fred-stripe
cc @stripe/api-libraries
Fixes #1053.
We could even remove
MimeTypes.csentirely and just useapplication/octet-streamalways. This is what the Python library does (here).I've also set a default value for the filename, as the API does require one (cf. stripe/stripe-python#227 for more context).