Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for source objects in Source wrapper #1096

Merged
merged 1 commit into from
Jan 19, 2018
Merged

Conversation

ob-stripe
Copy link
Contributor

r? @remi-stripe
cc @stripe/api-libraries

Tentative fix for #1090.

public StripeBankAccount BankAccount { get; set; }
public StripeCard Card { get; set; }
public StripeDeleted Deleted { get; set; }
public StripeSource SourceObject { get; set; }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not possible to have a property with the same name as the wrapping class, so I named the property SourceObject instead of just Source.

Copy link
Contributor

@remi-stripe remi-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ob-stripe ob-stripe merged commit 221cc49 into master Jan 19, 2018
@ob-stripe ob-stripe deleted the ob-fix-1090 branch January 19, 2018 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants