Make it possible to expand Product on Plan #1103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm...
If this is a temporary problem, how should I move forward from here? |
|
@jmosbech I wouldn't worry about it, we can review the code and then re-run the tests if needed. Thanks a lot for your contribution! |
|
You're welcome! Please let me know if something needs fixing. |
|
this LGTM but to be safe r? @ob-stripe |
|
LGTM as well, but re-running the test suite for safety. |
|
Released as v13.0.1. Thanks for the contribution @jmosbech, much appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it much easier to work with the plans.